From: "Darrick J. Wong" <djwong@kernel.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Dave Chinner <dchinner@redhat.com>,
Chandan Babu R <chandanrlinux@gmail.com>,
Allison Henderson <allison.henderson@oracle.com>,
Christoph Hellwig <hch@lst.de>,
linux-xfs@vger.kernel.org, linux-next@vger.kernel.org,
linux-kernel@vger.kernel.org, noreply@ellerman.id.au
Subject: Re: [PATCH] xfs: Fix 64-bit division on 32-bit in xlog_state_switch_iclogs()
Date: Thu, 10 Jun 2021 15:50:26 -0700 [thread overview]
Message-ID: <20210610225026.GD2945738@locust> (raw)
In-Reply-To: <20210610220155.GQ664593@dread.disaster.area>
On Fri, Jun 11, 2021 at 08:01:55AM +1000, Dave Chinner wrote:
> On Thu, Jun 10, 2021 at 01:00:01PM +0200, Geert Uytterhoeven wrote:
> > On 32-bit (e.g. m68k):
> >
> > ERROR: modpost: "__udivdi3" [fs/xfs/xfs.ko] undefined!
> >
> > Fix this by using a uint32_t intermediate, like before.
> >
> > Reported-by: noreply@ellerman.id.au
> > Fixes: 7660a5b48fbef958 ("xfs: log stripe roundoff is a property of the log")
> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > ---
> > Compile-tested only.
> > ---
> > fs/xfs/xfs_log.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> <sigh>
>
> 64 bit division on 32 bit platforms is still a problem in this day
> and age?
>
> Reviewed-by: Dave Chinner <dchinner@redhat.com>
>
> Maybe we should just put "requires 64 bit kernel" on XFS these days...
But then how will I recover my 100TB XFS using my TV? It only has so
much framebuffer that I can abuse for swap memory... >:O
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
>
> -Dave.
> --
> Dave Chinner
> david@fromorbit.com
next prev parent reply other threads:[~2021-06-10 22:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 11:00 [PATCH] xfs: Fix 64-bit division on 32-bit in xlog_state_switch_iclogs() Geert Uytterhoeven
2021-06-10 22:01 ` Dave Chinner
2021-06-10 22:50 ` Darrick J. Wong [this message]
2021-06-11 6:55 ` Geert Uytterhoeven
2021-06-11 22:46 ` Dave Chinner
2021-06-12 8:54 ` Geert Uytterhoeven
2021-06-14 8:18 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210610225026.GD2945738@locust \
--to=djwong@kernel.org \
--cc=allison.henderson@oracle.com \
--cc=chandanrlinux@gmail.com \
--cc=david@fromorbit.com \
--cc=dchinner@redhat.com \
--cc=geert@linux-m68k.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=noreply@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).