From: Peter Chen <peter.chen@kernel.org>
To: Baokun Li <libaokun1@huawei.com>
Cc: linux-kernel@vger.kernel.org, Pawel Laszczak <pawell@cadence.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
weiyongjun1@huawei.com, yuehaibing@huawei.com,
yangjihong1@huawei.com, yukuai3@huawei.com,
linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org,
Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next v2] usb: cdns3: cdns3-gadget: Use list_move_tail instead of list_del/list_add_tail
Date: Thu, 10 Jun 2021 22:17:12 +0800 [thread overview]
Message-ID: <20210610141712.GB7839@Peter> (raw)
In-Reply-To: <20210609072720.1358527-1-libaokun1@huawei.com>
On 21-06-09 15:27:20, Baokun Li wrote:
> Using list_move_tail() instead of list_del() + list_add_tail().
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>
> ---
> V1->V2:
> CC mailist
>
> drivers/usb/cdns3/cdns3-gadget.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/usb/cdns3/cdns3-gadget.c b/drivers/usb/cdns3/cdns3-gadget.c
> index 57adcdbfab5f..5d8c982019af 100644
> --- a/drivers/usb/cdns3/cdns3-gadget.c
> +++ b/drivers/usb/cdns3/cdns3-gadget.c
> @@ -430,9 +430,7 @@ static int cdns3_start_all_request(struct cdns3_device *priv_dev,
> if (ret)
> return ret;
>
> - list_del(&request->list);
> - list_add_tail(&request->list,
> - &priv_ep->pending_req_list);
> + list_move_tail(&request->list, &priv_ep->pending_req_list);
> if (request->stream_id != 0 || (priv_ep->flags & EP_TDLCHK_EN))
> break;
> }
>
Applied, thanks.
--
Thanks,
Peter Chen
prev parent reply other threads:[~2021-06-10 14:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 7:27 [PATCH -next v2] usb: cdns3: cdns3-gadget: Use list_move_tail instead of list_del/list_add_tail Baokun Li
2021-06-10 14:17 ` Peter Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210610141712.GB7839@Peter \
--to=peter.chen@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hulkci@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=libaokun1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pawell@cadence.com \
--cc=weiyongjun1@huawei.com \
--cc=yangjihong1@huawei.com \
--cc=yuehaibing@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).