* [PATCH 1/7] checkpatch: check Makefiles and Kconfigs for SPDX tag
2021-06-10 21:44 [PATCH 0/7] check Makefile and Kconfigs for SPDX tag trix
@ 2021-06-10 21:44 ` trix
2021-06-10 22:15 ` Joe Perches
2021-06-10 21:44 ` [PATCH 2/7] mei: hdcp: SPDX tag should be the first line trix
` (5 subsequent siblings)
6 siblings, 1 reply; 13+ messages in thread
From: trix @ 2021-06-10 21:44 UTC (permalink / raw)
To: robh+dt, tsbogend, jic23, lars, tomas.winkler, arnd, gregkh, nbd,
lorenzo.bianconi83, ryder.lee, kvalo, davem, kuba, matthias.bgg,
mcoquelin.stm32, alexandre.torgue, apw, joe, dwaipayanray1,
lukas.bulwahn, chenhuacai, jiaxun.yang, zhangqing, jbhayana,
sean.wang, shayne.chen, Soul.Huang, shorne, gsomlo, pczarnecki,
mholenko, davidgow
Cc: devicetree, linux-mips, linux-kernel, linux-iio, linux-wireless,
netdev, linux-arm-kernel, linux-mediatek, linux-stm32, Tom Rix
From: Tom Rix <trix@redhat.com>
Both Makefiles and Kconfigs should carry an SPDX tag.
Something like
# SPDX-License-Identifier: GPL-2.0-only
Add a matcher to existing check
Signed-off-by: Tom Rix <trix@redhat.com>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index dad87c3686326..7fca3a7c38791 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3572,7 +3572,7 @@ sub process {
$comment = '/*';
} elsif ($realfile =~ /\.(c|dts|dtsi)$/) {
$comment = '//';
- } elsif (($checklicenseline == 2) || $realfile =~ /\.(sh|pl|py|awk|tc|yaml)$/) {
+ } elsif (($checklicenseline == 2) || $realfile =~ /\.(sh|pl|py|awk|tc|yaml)$|Kconfig|Makefile/) {
$comment = '#';
} elsif ($realfile =~ /\.rst$/) {
$comment = '..';
--
2.26.3
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 1/7] checkpatch: check Makefiles and Kconfigs for SPDX tag
2021-06-10 21:44 ` [PATCH 1/7] checkpatch: check Makefiles " trix
@ 2021-06-10 22:15 ` Joe Perches
0 siblings, 0 replies; 13+ messages in thread
From: Joe Perches @ 2021-06-10 22:15 UTC (permalink / raw)
To: trix, robh+dt, tsbogend, jic23, lars, tomas.winkler, arnd,
gregkh, nbd, lorenzo.bianconi83, ryder.lee, kvalo, davem, kuba,
matthias.bgg, mcoquelin.stm32, alexandre.torgue, apw,
dwaipayanray1, lukas.bulwahn, chenhuacai, jiaxun.yang, zhangqing,
jbhayana, sean.wang, shayne.chen, Soul.Huang, shorne, gsomlo,
pczarnecki, mholenko, davidgow
Cc: devicetree, linux-mips, linux-kernel, linux-iio, linux-wireless,
netdev, linux-arm-kernel, linux-mediatek, linux-stm32
On Thu, 2021-06-10 at 14:44 -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> Both Makefiles and Kconfigs should carry an SPDX tag.
> Something like
> # SPDX-License-Identifier: GPL-2.0-only
>
> Add a matcher to existing check
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Seems fine, thanks.
There's a Makefile with two tags that could be updated too.
---
drivers/staging/media/atomisp/Makefile | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/Makefile b/drivers/staging/media/atomisp/Makefile
index 51498b2e85b8f..cee03e31f420d 100644
--- a/drivers/staging/media/atomisp/Makefile
+++ b/drivers/staging/media/atomisp/Makefile
@@ -11,7 +11,6 @@ DEFINES += -DDEBUG
atomisp = $(srctree)/drivers/staging/media/atomisp/
-# SPDX-License-Identifier: GPL-2.0
atomisp-objs += \
pci/atomisp_acc.o \
pci/atomisp_cmd.o \
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 2/7] mei: hdcp: SPDX tag should be the first line
2021-06-10 21:44 [PATCH 0/7] check Makefile and Kconfigs for SPDX tag trix
2021-06-10 21:44 ` [PATCH 1/7] checkpatch: check Makefiles " trix
@ 2021-06-10 21:44 ` trix
2021-06-11 16:12 ` Winkler, Tomas
2021-06-10 21:44 ` [PATCH 3/7] drivers/soc/litex: fix spelling of SPDX tag trix
` (4 subsequent siblings)
6 siblings, 1 reply; 13+ messages in thread
From: trix @ 2021-06-10 21:44 UTC (permalink / raw)
To: robh+dt, tsbogend, jic23, lars, tomas.winkler, arnd, gregkh, nbd,
lorenzo.bianconi83, ryder.lee, kvalo, davem, kuba, matthias.bgg,
mcoquelin.stm32, alexandre.torgue, apw, joe, dwaipayanray1,
lukas.bulwahn, chenhuacai, jiaxun.yang, zhangqing, jbhayana,
sean.wang, shayne.chen, Soul.Huang, shorne, gsomlo, pczarnecki,
mholenko, davidgow
Cc: devicetree, linux-mips, linux-kernel, linux-iio, linux-wireless,
netdev, linux-arm-kernel, linux-mediatek, linux-stm32, Tom Rix
From: Tom Rix <trix@redhat.com>
checkpatch looks for the tag on the first line.
So delete empty first line
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/misc/mei/hdcp/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/misc/mei/hdcp/Kconfig b/drivers/misc/mei/hdcp/Kconfig
index 95b2d6d37f102..54e1c95269096 100644
--- a/drivers/misc/mei/hdcp/Kconfig
+++ b/drivers/misc/mei/hdcp/Kconfig
@@ -1,4 +1,3 @@
-
# SPDX-License-Identifier: GPL-2.0
# Copyright (c) 2019, Intel Corporation. All rights reserved.
#
--
2.26.3
^ permalink raw reply related [flat|nested] 13+ messages in thread* RE: [PATCH 2/7] mei: hdcp: SPDX tag should be the first line
2021-06-10 21:44 ` [PATCH 2/7] mei: hdcp: SPDX tag should be the first line trix
@ 2021-06-11 16:12 ` Winkler, Tomas
0 siblings, 0 replies; 13+ messages in thread
From: Winkler, Tomas @ 2021-06-11 16:12 UTC (permalink / raw)
To: trix, robh+dt, tsbogend, jic23, lars, arnd, gregkh, nbd,
lorenzo.bianconi83, ryder.lee, kvalo, davem, kuba, matthias.bgg,
mcoquelin.stm32, alexandre.torgue, apw, joe, dwaipayanray1,
lukas.bulwahn, chenhuacai, jiaxun.yang, zhangqing, jbhayana,
sean.wang, shayne.chen, Soul.Huang, shorne, gsomlo, pczarnecki,
mholenko, davidgow
Cc: devicetree, linux-mips, linux-kernel, linux-iio, linux-wireless,
netdev, linux-arm-kernel, linux-mediatek, linux-stm32
>
> From: Tom Rix <trix@redhat.com>
>
> checkpatch looks for the tag on the first line.
> So delete empty first line
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Acked-by: Tomas Winkler <tomas.winkler@intel.com>
> ---
> drivers/misc/mei/hdcp/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/misc/mei/hdcp/Kconfig b/drivers/misc/mei/hdcp/Kconfig
> index 95b2d6d37f102..54e1c95269096 100644
> --- a/drivers/misc/mei/hdcp/Kconfig
> +++ b/drivers/misc/mei/hdcp/Kconfig
> @@ -1,4 +1,3 @@
> -
> # SPDX-License-Identifier: GPL-2.0
> # Copyright (c) 2019, Intel Corporation. All rights reserved.
> #
> --
> 2.26.3
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 3/7] drivers/soc/litex: fix spelling of SPDX tag
2021-06-10 21:44 [PATCH 0/7] check Makefile and Kconfigs for SPDX tag trix
2021-06-10 21:44 ` [PATCH 1/7] checkpatch: check Makefiles " trix
2021-06-10 21:44 ` [PATCH 2/7] mei: hdcp: SPDX tag should be the first line trix
@ 2021-06-10 21:44 ` trix
2021-06-11 20:38 ` Stafford Horne
2021-06-10 21:44 ` [PATCH 4/7] MIPS: Loongson64: " trix
` (3 subsequent siblings)
6 siblings, 1 reply; 13+ messages in thread
From: trix @ 2021-06-10 21:44 UTC (permalink / raw)
To: robh+dt, tsbogend, jic23, lars, tomas.winkler, arnd, gregkh, nbd,
lorenzo.bianconi83, ryder.lee, kvalo, davem, kuba, matthias.bgg,
mcoquelin.stm32, alexandre.torgue, apw, joe, dwaipayanray1,
lukas.bulwahn, chenhuacai, jiaxun.yang, zhangqing, jbhayana,
sean.wang, shayne.chen, Soul.Huang, shorne, gsomlo, pczarnecki,
mholenko, davidgow
Cc: devicetree, linux-mips, linux-kernel, linux-iio, linux-wireless,
netdev, linux-arm-kernel, linux-mediatek, linux-stm32, Tom Rix
From: Tom Rix <trix@redhat.com>
checkpatch looks for SPDX-License-Identifier.
So change the '_' to '-'
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/soc/litex/Kconfig | 2 +-
drivers/soc/litex/Makefile | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/soc/litex/Kconfig b/drivers/soc/litex/Kconfig
index e7011d665b151..c03b1f816cc08 100644
--- a/drivers/soc/litex/Kconfig
+++ b/drivers/soc/litex/Kconfig
@@ -1,4 +1,4 @@
-# SPDX-License_Identifier: GPL-2.0
+# SPDX-License-Identifier: GPL-2.0
menu "Enable LiteX SoC Builder specific drivers"
diff --git a/drivers/soc/litex/Makefile b/drivers/soc/litex/Makefile
index 98ff7325b1c07..aeae1f4165a70 100644
--- a/drivers/soc/litex/Makefile
+++ b/drivers/soc/litex/Makefile
@@ -1,3 +1,3 @@
-# SPDX-License_Identifier: GPL-2.0
+# SPDX-License-Identifier: GPL-2.0
obj-$(CONFIG_LITEX_SOC_CONTROLLER) += litex_soc_ctrl.o
--
2.26.3
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 3/7] drivers/soc/litex: fix spelling of SPDX tag
2021-06-10 21:44 ` [PATCH 3/7] drivers/soc/litex: fix spelling of SPDX tag trix
@ 2021-06-11 20:38 ` Stafford Horne
0 siblings, 0 replies; 13+ messages in thread
From: Stafford Horne @ 2021-06-11 20:38 UTC (permalink / raw)
To: trix
Cc: robh+dt, tsbogend, jic23, lars, tomas.winkler, arnd, gregkh, nbd,
lorenzo.bianconi83, ryder.lee, kvalo, davem, kuba, matthias.bgg,
mcoquelin.stm32, alexandre.torgue, apw, joe, dwaipayanray1,
lukas.bulwahn, chenhuacai, jiaxun.yang, zhangqing, jbhayana,
sean.wang, shayne.chen, Soul.Huang, gsomlo, pczarnecki, mholenko,
davidgow, devicetree, linux-mips, linux-kernel, linux-iio,
linux-wireless, netdev, linux-arm-kernel, linux-mediatek,
linux-stm32
On Thu, Jun 10, 2021 at 02:44:34PM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> checkpatch looks for SPDX-License-Identifier.
> So change the '_' to '-'
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Acked-by: Stafford Horne <shorne@gmail.com>
> ---
> drivers/soc/litex/Kconfig | 2 +-
> drivers/soc/litex/Makefile | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/litex/Kconfig b/drivers/soc/litex/Kconfig
> index e7011d665b151..c03b1f816cc08 100644
> --- a/drivers/soc/litex/Kconfig
> +++ b/drivers/soc/litex/Kconfig
> @@ -1,4 +1,4 @@
> -# SPDX-License_Identifier: GPL-2.0
> +# SPDX-License-Identifier: GPL-2.0
>
> menu "Enable LiteX SoC Builder specific drivers"
>
> diff --git a/drivers/soc/litex/Makefile b/drivers/soc/litex/Makefile
> index 98ff7325b1c07..aeae1f4165a70 100644
> --- a/drivers/soc/litex/Makefile
> +++ b/drivers/soc/litex/Makefile
> @@ -1,3 +1,3 @@
> -# SPDX-License_Identifier: GPL-2.0
> +# SPDX-License-Identifier: GPL-2.0
>
> obj-$(CONFIG_LITEX_SOC_CONTROLLER) += litex_soc_ctrl.o
> --
> 2.26.3
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 4/7] MIPS: Loongson64: fix spelling of SPDX tag
2021-06-10 21:44 [PATCH 0/7] check Makefile and Kconfigs for SPDX tag trix
` (2 preceding siblings ...)
2021-06-10 21:44 ` [PATCH 3/7] drivers/soc/litex: fix spelling of SPDX tag trix
@ 2021-06-10 21:44 ` trix
2021-06-21 9:46 ` Thomas Bogendoerfer
2021-06-10 21:44 ` [PATCH 5/7] iio/scmi: " trix
` (2 subsequent siblings)
6 siblings, 1 reply; 13+ messages in thread
From: trix @ 2021-06-10 21:44 UTC (permalink / raw)
To: robh+dt, tsbogend, jic23, lars, tomas.winkler, arnd, gregkh, nbd,
lorenzo.bianconi83, ryder.lee, kvalo, davem, kuba, matthias.bgg,
mcoquelin.stm32, alexandre.torgue, apw, joe, dwaipayanray1,
lukas.bulwahn, chenhuacai, jiaxun.yang, zhangqing, jbhayana,
sean.wang, shayne.chen, Soul.Huang, shorne, gsomlo, pczarnecki,
mholenko, davidgow
Cc: devicetree, linux-mips, linux-kernel, linux-iio, linux-wireless,
netdev, linux-arm-kernel, linux-mediatek, linux-stm32, Tom Rix
From: Tom Rix <trix@redhat.com>
checkpatch looks for SPDX-License-Identifier.
So change the '_' to '-'
Signed-off-by: Tom Rix <trix@redhat.com>
---
arch/mips/boot/dts/loongson/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/boot/dts/loongson/Makefile b/arch/mips/boot/dts/loongson/Makefile
index 72267bfda9b41..5c6433e441ee4 100644
--- a/arch/mips/boot/dts/loongson/Makefile
+++ b/arch/mips/boot/dts/loongson/Makefile
@@ -1,4 +1,4 @@
-# SPDX_License_Identifier: GPL_2.0
+# SPDX-License-Identifier: GPL-2.0
dtb-$(CONFIG_MACH_LOONGSON64) += loongson64_2core_2k1000.dtb
dtb-$(CONFIG_MACH_LOONGSON64) += loongson64c_4core_ls7a.dtb
dtb-$(CONFIG_MACH_LOONGSON64) += loongson64c_4core_rs780e.dtb
--
2.26.3
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 4/7] MIPS: Loongson64: fix spelling of SPDX tag
2021-06-10 21:44 ` [PATCH 4/7] MIPS: Loongson64: " trix
@ 2021-06-21 9:46 ` Thomas Bogendoerfer
0 siblings, 0 replies; 13+ messages in thread
From: Thomas Bogendoerfer @ 2021-06-21 9:46 UTC (permalink / raw)
To: trix
Cc: robh+dt, jic23, lars, tomas.winkler, arnd, gregkh, nbd,
lorenzo.bianconi83, ryder.lee, kvalo, davem, kuba, matthias.bgg,
mcoquelin.stm32, alexandre.torgue, apw, joe, dwaipayanray1,
lukas.bulwahn, chenhuacai, jiaxun.yang, zhangqing, jbhayana,
sean.wang, shayne.chen, Soul.Huang, shorne, gsomlo, pczarnecki,
mholenko, davidgow, devicetree, linux-mips, linux-kernel,
linux-iio, linux-wireless, netdev, linux-arm-kernel,
linux-mediatek, linux-stm32
On Thu, Jun 10, 2021 at 02:44:35PM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> checkpatch looks for SPDX-License-Identifier.
> So change the '_' to '-'
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> arch/mips/boot/dts/loongson/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 5/7] iio/scmi: fix spelling of SPDX tag
2021-06-10 21:44 [PATCH 0/7] check Makefile and Kconfigs for SPDX tag trix
` (3 preceding siblings ...)
2021-06-10 21:44 ` [PATCH 4/7] MIPS: Loongson64: " trix
@ 2021-06-10 21:44 ` trix
2021-06-11 17:37 ` Jonathan Cameron
2021-06-10 21:44 ` [PATCH 6/7] mt76: add a space between comment char and " trix
2021-06-10 21:44 ` [PATCH 7/7] mt76: use SPDX header file comment style trix
6 siblings, 1 reply; 13+ messages in thread
From: trix @ 2021-06-10 21:44 UTC (permalink / raw)
To: robh+dt, tsbogend, jic23, lars, tomas.winkler, arnd, gregkh, nbd,
lorenzo.bianconi83, ryder.lee, kvalo, davem, kuba, matthias.bgg,
mcoquelin.stm32, alexandre.torgue, apw, joe, dwaipayanray1,
lukas.bulwahn, chenhuacai, jiaxun.yang, zhangqing, jbhayana,
sean.wang, shayne.chen, Soul.Huang, shorne, gsomlo, pczarnecki,
mholenko, davidgow
Cc: devicetree, linux-mips, linux-kernel, linux-iio, linux-wireless,
netdev, linux-arm-kernel, linux-mediatek, linux-stm32, Tom Rix
From: Tom Rix <trix@redhat.com>
checkpatch looks for SPDX-License-Identifier.
Remove the extra spaces.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/iio/common/scmi_sensors/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/common/scmi_sensors/Makefile b/drivers/iio/common/scmi_sensors/Makefile
index f13140a2575a4..645e0fce1a739 100644
--- a/drivers/iio/common/scmi_sensors/Makefile
+++ b/drivers/iio/common/scmi_sensors/Makefile
@@ -1,4 +1,4 @@
-# SPDX - License - Identifier : GPL - 2.0 - only
+# SPDX-License-Identifier: GPL-2.0-only
#
# Makefile for the IIO over SCMI
#
--
2.26.3
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 5/7] iio/scmi: fix spelling of SPDX tag
2021-06-10 21:44 ` [PATCH 5/7] iio/scmi: " trix
@ 2021-06-11 17:37 ` Jonathan Cameron
0 siblings, 0 replies; 13+ messages in thread
From: Jonathan Cameron @ 2021-06-11 17:37 UTC (permalink / raw)
To: trix
Cc: robh+dt, tsbogend, lars, tomas.winkler, arnd, gregkh, nbd,
lorenzo.bianconi83, ryder.lee, kvalo, davem, kuba, matthias.bgg,
mcoquelin.stm32, alexandre.torgue, apw, joe, dwaipayanray1,
lukas.bulwahn, chenhuacai, jiaxun.yang, zhangqing, jbhayana,
sean.wang, shayne.chen, Soul.Huang, shorne, gsomlo, pczarnecki,
mholenko, davidgow, devicetree, linux-mips, linux-kernel,
linux-iio, linux-wireless, netdev, linux-arm-kernel,
linux-mediatek, linux-stm32
On Thu, 10 Jun 2021 14:44:36 -0700
trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> checkpatch looks for SPDX-License-Identifier.
> Remove the extra spaces.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Applied this one to the togreg branch of iio.git (initially pushed out as testing
to let 0-day have first poke at it). Thanks,
Jonathan
> ---
> drivers/iio/common/scmi_sensors/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/common/scmi_sensors/Makefile b/drivers/iio/common/scmi_sensors/Makefile
> index f13140a2575a4..645e0fce1a739 100644
> --- a/drivers/iio/common/scmi_sensors/Makefile
> +++ b/drivers/iio/common/scmi_sensors/Makefile
> @@ -1,4 +1,4 @@
> -# SPDX - License - Identifier : GPL - 2.0 - only
> +# SPDX-License-Identifier: GPL-2.0-only
> #
> # Makefile for the IIO over SCMI
> #
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 6/7] mt76: add a space between comment char and SPDX tag
2021-06-10 21:44 [PATCH 0/7] check Makefile and Kconfigs for SPDX tag trix
` (4 preceding siblings ...)
2021-06-10 21:44 ` [PATCH 5/7] iio/scmi: " trix
@ 2021-06-10 21:44 ` trix
2021-06-10 21:44 ` [PATCH 7/7] mt76: use SPDX header file comment style trix
6 siblings, 0 replies; 13+ messages in thread
From: trix @ 2021-06-10 21:44 UTC (permalink / raw)
To: robh+dt, tsbogend, jic23, lars, tomas.winkler, arnd, gregkh, nbd,
lorenzo.bianconi83, ryder.lee, kvalo, davem, kuba, matthias.bgg,
mcoquelin.stm32, alexandre.torgue, apw, joe, dwaipayanray1,
lukas.bulwahn, chenhuacai, jiaxun.yang, zhangqing, jbhayana,
sean.wang, shayne.chen, Soul.Huang, shorne, gsomlo, pczarnecki,
mholenko, davidgow
Cc: devicetree, linux-mips, linux-kernel, linux-iio, linux-wireless,
netdev, linux-arm-kernel, linux-mediatek, linux-stm32, Tom Rix
From: Tom Rix <trix@redhat.com>
checkpatch expects a space between '#' and 'SPDX...'
Add a space.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/net/wireless/mediatek/mt76/mt7615/Makefile | 2 +-
drivers/net/wireless/mediatek/mt76/mt7915/Makefile | 2 +-
drivers/net/wireless/mediatek/mt76/mt7921/Makefile | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/Makefile b/drivers/net/wireless/mediatek/mt76/mt7615/Makefile
index e8fc4a7ae9bc2..83f9861ff5226 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7615/Makefile
+++ b/drivers/net/wireless/mediatek/mt76/mt7615/Makefile
@@ -1,4 +1,4 @@
-#SPDX-License-Identifier: ISC
+# SPDX-License-Identifier: ISC
obj-$(CONFIG_MT7615_COMMON) += mt7615-common.o
obj-$(CONFIG_MT7615E) += mt7615e.o
diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/Makefile b/drivers/net/wireless/mediatek/mt76/mt7915/Makefile
index 40c8061787e94..80e49244348e2 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7915/Makefile
+++ b/drivers/net/wireless/mediatek/mt76/mt7915/Makefile
@@ -1,4 +1,4 @@
-#SPDX-License-Identifier: ISC
+# SPDX-License-Identifier: ISC
obj-$(CONFIG_MT7915E) += mt7915e.o
diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/Makefile b/drivers/net/wireless/mediatek/mt76/mt7921/Makefile
index e531666f9fb43..0ebb59966a083 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7921/Makefile
+++ b/drivers/net/wireless/mediatek/mt76/mt7921/Makefile
@@ -1,4 +1,4 @@
-#SPDX-License-Identifier: ISC
+# SPDX-License-Identifier: ISC
obj-$(CONFIG_MT7921E) += mt7921e.o
--
2.26.3
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH 7/7] mt76: use SPDX header file comment style
2021-06-10 21:44 [PATCH 0/7] check Makefile and Kconfigs for SPDX tag trix
` (5 preceding siblings ...)
2021-06-10 21:44 ` [PATCH 6/7] mt76: add a space between comment char and " trix
@ 2021-06-10 21:44 ` trix
6 siblings, 0 replies; 13+ messages in thread
From: trix @ 2021-06-10 21:44 UTC (permalink / raw)
To: robh+dt, tsbogend, jic23, lars, tomas.winkler, arnd, gregkh, nbd,
lorenzo.bianconi83, ryder.lee, kvalo, davem, kuba, matthias.bgg,
mcoquelin.stm32, alexandre.torgue, apw, joe, dwaipayanray1,
lukas.bulwahn, chenhuacai, jiaxun.yang, zhangqing, jbhayana,
sean.wang, shayne.chen, Soul.Huang, shorne, gsomlo, pczarnecki,
mholenko, davidgow
Cc: devicetree, linux-mips, linux-kernel, linux-iio, linux-wireless,
netdev, linux-arm-kernel, linux-mediatek, linux-stm32, Tom Rix
From: Tom Rix <trix@redhat.com>
header files should use '/* SPDX ... */
Change from c file comment syle to header style
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/net/wireless/mediatek/mt76/mt7615/sdio.h | 2 +-
drivers/net/wireless/mediatek/mt76/mt7915/testmode.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/sdio.h b/drivers/net/wireless/mediatek/mt76/mt7615/sdio.h
index 05180971de841..03877d89e1520 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7615/sdio.h
+++ b/drivers/net/wireless/mediatek/mt76/mt7615/sdio.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: ISC
+/* SPDX-License-Identifier: ISC */
/* Copyright (C) 2020 MediaTek Inc.
*
* Author: Sean Wang <sean.wang@mediatek.com>
diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/testmode.h b/drivers/net/wireless/mediatek/mt76/mt7915/testmode.h
index 8f8533ef9859f..397a6b5532bcc 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7915/testmode.h
+++ b/drivers/net/wireless/mediatek/mt76/mt7915/testmode.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: ISC
+/* SPDX-License-Identifier: ISC */
/* Copyright (C) 2020 MediaTek Inc. */
#ifndef __MT7915_TESTMODE_H
--
2.26.3
^ permalink raw reply related [flat|nested] 13+ messages in thread