linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] quota: finish disable quotactl_path syscall
@ 2021-06-14 15:37 Marcin Juszkiewicz
  2021-06-14 16:44 ` Jan Kara
  0 siblings, 1 reply; 6+ messages in thread
From: Marcin Juszkiewicz @ 2021-06-14 15:37 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: linux-kernel, Jan Kara, Christian Brauner, Sascha Hauer,
	linux-arch, Marcin Juszkiewicz

In commit 5b9fedb31e47 ("quota: Disable quotactl_path syscall") Jan Kara
disabled quotactl_path syscall on several architectures.

This commit disables it on all architectures using unified list of
system calls:

- arm64
- arc
- csky
- h8300
- hexagon
- nds32
- nios2
- openrisc
- riscv (32/64)

CC: Jan Kara <jack@suse.cz>
CC: Christian Brauner <christian.brauner@ubuntu.com>
CC: Sascha Hauer <s.hauer@pengutronix.de>
Link: https://lore.kernel.org/lkml/20210512153621.n5u43jsytbik4yze@wittgenstein

Signed-off-by: Marcin Juszkiewicz <marcin@juszkiewicz.com.pl>
---
 include/uapi/asm-generic/unistd.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/uapi/asm-generic/unistd.h b/include/uapi/asm-generic/unistd.h
index 6de5a7fc066b..d2a942086fcb 100644
--- a/include/uapi/asm-generic/unistd.h
+++ b/include/uapi/asm-generic/unistd.h
@@ -863,8 +863,7 @@ __SYSCALL(__NR_process_madvise, sys_process_madvise)
 __SC_COMP(__NR_epoll_pwait2, sys_epoll_pwait2, compat_sys_epoll_pwait2)
 #define __NR_mount_setattr 442
 __SYSCALL(__NR_mount_setattr, sys_mount_setattr)
-#define __NR_quotactl_path 443
-__SYSCALL(__NR_quotactl_path, sys_quotactl_path)
+/* 443 is reserved for quotactl_path */
 
 #define __NR_landlock_create_ruleset 444
 __SYSCALL(__NR_landlock_create_ruleset, sys_landlock_create_ruleset)
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] quota: finish disable quotactl_path syscall
  2021-06-14 15:37 [PATCH] quota: finish disable quotactl_path syscall Marcin Juszkiewicz
@ 2021-06-14 16:44 ` Jan Kara
  2021-06-15  8:45   ` Arnd Bergmann
  2021-06-15  8:47   ` Jan Kara
  0 siblings, 2 replies; 6+ messages in thread
From: Jan Kara @ 2021-06-14 16:44 UTC (permalink / raw)
  To: Marcin Juszkiewicz
  Cc: Arnd Bergmann, linux-kernel, Jan Kara, Christian Brauner,
	Sascha Hauer, linux-arch

On Mon 14-06-21 17:37:12, Marcin Juszkiewicz wrote:
> In commit 5b9fedb31e47 ("quota: Disable quotactl_path syscall") Jan Kara
> disabled quotactl_path syscall on several architectures.
> 
> This commit disables it on all architectures using unified list of
> system calls:
> 
> - arm64
> - arc
> - csky
> - h8300
> - hexagon
> - nds32
> - nios2
> - openrisc
> - riscv (32/64)
> 
> CC: Jan Kara <jack@suse.cz>
> CC: Christian Brauner <christian.brauner@ubuntu.com>
> CC: Sascha Hauer <s.hauer@pengutronix.de>
> Link: https://lore.kernel.org/lkml/20210512153621.n5u43jsytbik4yze@wittgenstein
> 
> Signed-off-by: Marcin Juszkiewicz <marcin@juszkiewicz.com.pl>

Aha, I've missed that one. Thanks for catching this. Arnd, will you take
this patch or should I take it through my tree?

								Honza

> ---
>  include/uapi/asm-generic/unistd.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/include/uapi/asm-generic/unistd.h b/include/uapi/asm-generic/unistd.h
> index 6de5a7fc066b..d2a942086fcb 100644
> --- a/include/uapi/asm-generic/unistd.h
> +++ b/include/uapi/asm-generic/unistd.h
> @@ -863,8 +863,7 @@ __SYSCALL(__NR_process_madvise, sys_process_madvise)
>  __SC_COMP(__NR_epoll_pwait2, sys_epoll_pwait2, compat_sys_epoll_pwait2)
>  #define __NR_mount_setattr 442
>  __SYSCALL(__NR_mount_setattr, sys_mount_setattr)
> -#define __NR_quotactl_path 443
> -__SYSCALL(__NR_quotactl_path, sys_quotactl_path)
> +/* 443 is reserved for quotactl_path */
>  
>  #define __NR_landlock_create_ruleset 444
>  __SYSCALL(__NR_landlock_create_ruleset, sys_landlock_create_ruleset)
> -- 
> 2.31.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] quota: finish disable quotactl_path syscall
  2021-06-14 16:44 ` Jan Kara
@ 2021-06-15  8:45   ` Arnd Bergmann
  2021-06-15  9:05     ` Jan Kara
  2021-06-15  8:47   ` Jan Kara
  1 sibling, 1 reply; 6+ messages in thread
From: Arnd Bergmann @ 2021-06-15  8:45 UTC (permalink / raw)
  To: Jan Kara
  Cc: Marcin Juszkiewicz, Linux Kernel Mailing List, Christian Brauner,
	Sascha Hauer, linux-arch

On Mon, Jun 14, 2021 at 6:45 PM Jan Kara <jack@suse.cz> wrote:
>
> On Mon 14-06-21 17:37:12, Marcin Juszkiewicz wrote:
> > In commit 5b9fedb31e47 ("quota: Disable quotactl_path syscall") Jan Kara
> > disabled quotactl_path syscall on several architectures.
> >
> > This commit disables it on all architectures using unified list of
> > system calls:
> >
> > - arm64
> > - arc
> > - csky
> > - h8300
> > - hexagon
> > - nds32
> > - nios2
> > - openrisc
> > - riscv (32/64)
> >
> > CC: Jan Kara <jack@suse.cz>
> > CC: Christian Brauner <christian.brauner@ubuntu.com>
> > CC: Sascha Hauer <s.hauer@pengutronix.de>
> > Link: https://lore.kernel.org/lkml/20210512153621.n5u43jsytbik4yze@wittgenstein
> >
> > Signed-off-by: Marcin Juszkiewicz <marcin@juszkiewicz.com.pl>
>
> Aha, I've missed that one. Thanks for catching this. Arnd, will you take
> this patch or should I take it through my tree?

I don't have any other fixes for 5.13 at the moment, so I would prefer it if
you could pick it up.

       Arnd

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] quota: finish disable quotactl_path syscall
  2021-06-14 16:44 ` Jan Kara
  2021-06-15  8:45   ` Arnd Bergmann
@ 2021-06-15  8:47   ` Jan Kara
  2021-06-15  9:16     ` Christian Brauner
  1 sibling, 1 reply; 6+ messages in thread
From: Jan Kara @ 2021-06-15  8:47 UTC (permalink / raw)
  To: Marcin Juszkiewicz
  Cc: Arnd Bergmann, linux-kernel, Jan Kara, Christian Brauner,
	Sascha Hauer, linux-arch

On Mon 14-06-21 18:44:54, Jan Kara wrote:
> On Mon 14-06-21 17:37:12, Marcin Juszkiewicz wrote:
> > In commit 5b9fedb31e47 ("quota: Disable quotactl_path syscall") Jan Kara
> > disabled quotactl_path syscall on several architectures.
> > 
> > This commit disables it on all architectures using unified list of
> > system calls:
> > 
> > - arm64
> > - arc
> > - csky
> > - h8300
> > - hexagon
> > - nds32
> > - nios2
> > - openrisc
> > - riscv (32/64)
> > 
> > CC: Jan Kara <jack@suse.cz>
> > CC: Christian Brauner <christian.brauner@ubuntu.com>
> > CC: Sascha Hauer <s.hauer@pengutronix.de>
> > Link: https://lore.kernel.org/lkml/20210512153621.n5u43jsytbik4yze@wittgenstein
> > 
> > Signed-off-by: Marcin Juszkiewicz <marcin@juszkiewicz.com.pl>
> 
> Aha, I've missed that one. Thanks for catching this. Arnd, will you take
> this patch or should I take it through my tree?

OK, I want this to make it for rc7 so I've pulled this patch to my tree and
will push it to Linus in a few days.

								Honza

> > diff --git a/include/uapi/asm-generic/unistd.h b/include/uapi/asm-generic/unistd.h
> > index 6de5a7fc066b..d2a942086fcb 100644
> > --- a/include/uapi/asm-generic/unistd.h
> > +++ b/include/uapi/asm-generic/unistd.h
> > @@ -863,8 +863,7 @@ __SYSCALL(__NR_process_madvise, sys_process_madvise)
> >  __SC_COMP(__NR_epoll_pwait2, sys_epoll_pwait2, compat_sys_epoll_pwait2)
> >  #define __NR_mount_setattr 442
> >  __SYSCALL(__NR_mount_setattr, sys_mount_setattr)
> > -#define __NR_quotactl_path 443
> > -__SYSCALL(__NR_quotactl_path, sys_quotactl_path)
> > +/* 443 is reserved for quotactl_path */
> >  
> >  #define __NR_landlock_create_ruleset 444
> >  __SYSCALL(__NR_landlock_create_ruleset, sys_landlock_create_ruleset)
> > -- 
> > 2.31.1
> > 
> -- 
> Jan Kara <jack@suse.com>
> SUSE Labs, CR
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] quota: finish disable quotactl_path syscall
  2021-06-15  8:45   ` Arnd Bergmann
@ 2021-06-15  9:05     ` Jan Kara
  0 siblings, 0 replies; 6+ messages in thread
From: Jan Kara @ 2021-06-15  9:05 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Jan Kara, Marcin Juszkiewicz, Linux Kernel Mailing List,
	Christian Brauner, Sascha Hauer, linux-arch

On Tue 15-06-21 10:45:38, Arnd Bergmann wrote:
> On Mon, Jun 14, 2021 at 6:45 PM Jan Kara <jack@suse.cz> wrote:
> >
> > On Mon 14-06-21 17:37:12, Marcin Juszkiewicz wrote:
> > > In commit 5b9fedb31e47 ("quota: Disable quotactl_path syscall") Jan Kara
> > > disabled quotactl_path syscall on several architectures.
> > >
> > > This commit disables it on all architectures using unified list of
> > > system calls:
> > >
> > > - arm64
> > > - arc
> > > - csky
> > > - h8300
> > > - hexagon
> > > - nds32
> > > - nios2
> > > - openrisc
> > > - riscv (32/64)
> > >
> > > CC: Jan Kara <jack@suse.cz>
> > > CC: Christian Brauner <christian.brauner@ubuntu.com>
> > > CC: Sascha Hauer <s.hauer@pengutronix.de>
> > > Link: https://lore.kernel.org/lkml/20210512153621.n5u43jsytbik4yze@wittgenstein
> > >
> > > Signed-off-by: Marcin Juszkiewicz <marcin@juszkiewicz.com.pl>
> >
> > Aha, I've missed that one. Thanks for catching this. Arnd, will you take
> > this patch or should I take it through my tree?
> 
> I don't have any other fixes for 5.13 at the moment, so I would prefer it if
> you could pick it up.

OK, thanks for letting me know. I've picked it up.

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] quota: finish disable quotactl_path syscall
  2021-06-15  8:47   ` Jan Kara
@ 2021-06-15  9:16     ` Christian Brauner
  0 siblings, 0 replies; 6+ messages in thread
From: Christian Brauner @ 2021-06-15  9:16 UTC (permalink / raw)
  To: Jan Kara
  Cc: Marcin Juszkiewicz, Arnd Bergmann, linux-kernel, Sascha Hauer,
	linux-arch

On Tue, Jun 15, 2021 at 10:47:28AM +0200, Jan Kara wrote:
> On Mon 14-06-21 18:44:54, Jan Kara wrote:
> > On Mon 14-06-21 17:37:12, Marcin Juszkiewicz wrote:
> > > In commit 5b9fedb31e47 ("quota: Disable quotactl_path syscall") Jan Kara
> > > disabled quotactl_path syscall on several architectures.
> > > 
> > > This commit disables it on all architectures using unified list of
> > > system calls:
> > > 
> > > - arm64
> > > - arc
> > > - csky
> > > - h8300
> > > - hexagon
> > > - nds32
> > > - nios2
> > > - openrisc
> > > - riscv (32/64)
> > > 
> > > CC: Jan Kara <jack@suse.cz>
> > > CC: Christian Brauner <christian.brauner@ubuntu.com>
> > > CC: Sascha Hauer <s.hauer@pengutronix.de>
> > > Link: https://lore.kernel.org/lkml/20210512153621.n5u43jsytbik4yze@wittgenstein
> > > 
> > > Signed-off-by: Marcin Juszkiewicz <marcin@juszkiewicz.com.pl>
> > 
> > Aha, I've missed that one. Thanks for catching this. Arnd, will you take
> > this patch or should I take it through my tree?
> 
> OK, I want this to make it for rc7 so I've pulled this patch to my tree and
> will push it to Linus in a few days.

Looks good, thanks!
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>

> 
> 								Honza
> 
> > > diff --git a/include/uapi/asm-generic/unistd.h b/include/uapi/asm-generic/unistd.h
> > > index 6de5a7fc066b..d2a942086fcb 100644
> > > --- a/include/uapi/asm-generic/unistd.h
> > > +++ b/include/uapi/asm-generic/unistd.h
> > > @@ -863,8 +863,7 @@ __SYSCALL(__NR_process_madvise, sys_process_madvise)
> > >  __SC_COMP(__NR_epoll_pwait2, sys_epoll_pwait2, compat_sys_epoll_pwait2)
> > >  #define __NR_mount_setattr 442
> > >  __SYSCALL(__NR_mount_setattr, sys_mount_setattr)
> > > -#define __NR_quotactl_path 443
> > > -__SYSCALL(__NR_quotactl_path, sys_quotactl_path)
> > > +/* 443 is reserved for quotactl_path */
> > >  
> > >  #define __NR_landlock_create_ruleset 444
> > >  __SYSCALL(__NR_landlock_create_ruleset, sys_landlock_create_ruleset)
> > > -- 
> > > 2.31.1
> > > 
> > -- 
> > Jan Kara <jack@suse.com>
> > SUSE Labs, CR
> -- 
> Jan Kara <jack@suse.com>
> SUSE Labs, CR

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-06-15  9:16 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-14 15:37 [PATCH] quota: finish disable quotactl_path syscall Marcin Juszkiewicz
2021-06-14 16:44 ` Jan Kara
2021-06-15  8:45   ` Arnd Bergmann
2021-06-15  9:05     ` Jan Kara
2021-06-15  8:47   ` Jan Kara
2021-06-15  9:16     ` Christian Brauner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).