* [PATCH -next] ASoC: hdmi-codec: Make symbol 'hdmi_codec_controls' static
@ 2021-06-15 17:21 Wei Yongjun
2021-06-16 8:21 ` Maxime Ripard
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2021-06-15 17:21 UTC (permalink / raw)
To: weiyongjun1, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Maxime Ripard, Kuninori Morimoto,
Pierre-Louis Bossart, Cheng-Yi Chiang, Stephan Gerhold,
Shengjiu Wang
Cc: alsa-devel, linux-kernel, kernel-janitors, Hulk Robot
The sparse tool complains as follows:
sound/soc/codecs/hdmi-codec.c:750:25: warning:
symbol 'hdmi_codec_controls' was not declared. Should it be static?
This symbol is not used outside of hdmi-codec.c, so marks it static.
Fixes: 366b45b97448 ("ASoC: hdmi-codec: Rework to support more controls")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
sound/soc/codecs/hdmi-codec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/hdmi-codec.c b/sound/soc/codecs/hdmi-codec.c
index e0460a9bd17a..b61f980cabdc 100644
--- a/sound/soc/codecs/hdmi-codec.c
+++ b/sound/soc/codecs/hdmi-codec.c
@@ -747,7 +747,7 @@ static const struct snd_soc_dai_ops hdmi_codec_spdif_dai_ops = {
SNDRV_PCM_FMTBIT_S32_LE | SNDRV_PCM_FMTBIT_S32_BE |\
SNDRV_PCM_FMTBIT_IEC958_SUBFRAME_LE)
-struct snd_kcontrol_new hdmi_codec_controls[] = {
+static struct snd_kcontrol_new hdmi_codec_controls[] = {
{
.access = SNDRV_CTL_ELEM_ACCESS_READ,
.iface = SNDRV_CTL_ELEM_IFACE_PCM,
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] ASoC: hdmi-codec: Make symbol 'hdmi_codec_controls' static
2021-06-15 17:21 [PATCH -next] ASoC: hdmi-codec: Make symbol 'hdmi_codec_controls' static Wei Yongjun
@ 2021-06-16 8:21 ` Maxime Ripard
0 siblings, 0 replies; 2+ messages in thread
From: Maxime Ripard @ 2021-06-16 8:21 UTC (permalink / raw)
To: Wei Yongjun
Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Kuninori Morimoto, Pierre-Louis Bossart, Cheng-Yi Chiang,
Stephan Gerhold, Shengjiu Wang, alsa-devel, linux-kernel,
kernel-janitors, Hulk Robot
On Tue, Jun 15, 2021 at 05:21:56PM +0000, Wei Yongjun wrote:
> The sparse tool complains as follows:
>
> sound/soc/codecs/hdmi-codec.c:750:25: warning:
> symbol 'hdmi_codec_controls' was not declared. Should it be static?
>
> This symbol is not used outside of hdmi-codec.c, so marks it static.
>
> Fixes: 366b45b97448 ("ASoC: hdmi-codec: Rework to support more controls")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Maxime Ripard <maxime@cerno.tech>
Thanks!
Maxime
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-16 8:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-15 17:21 [PATCH -next] ASoC: hdmi-codec: Make symbol 'hdmi_codec_controls' static Wei Yongjun
2021-06-16 8:21 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).