* [PATCH net-next] qlcnic: Use list_for_each_entry() to simplify code in qlcnic_main.c
@ 2021-06-16 4:21 Wang Hai
2021-06-16 7:50 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Wang Hai @ 2021-06-16 4:21 UTC (permalink / raw)
To: davem, kuba, shshaikh, manishc; +Cc: GR-Linux-NIC-Dev, netdev, linux-kernel
Convert list_for_each() to list_for_each_entry() where
applicable. This simplifies the code.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
index 96b947fde646..8a31ce29ecfc 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
@@ -319,10 +319,8 @@ int qlcnic_read_mac_addr(struct qlcnic_adapter *adapter)
static void qlcnic_delete_adapter_mac(struct qlcnic_adapter *adapter)
{
struct qlcnic_mac_vlan_list *cur;
- struct list_head *head;
- list_for_each(head, &adapter->mac_list) {
- cur = list_entry(head, struct qlcnic_mac_vlan_list, list);
+ list_for_each_entry(cur, &adapter->mac_list, list) {
if (ether_addr_equal_unaligned(adapter->mac_addr, cur->mac_addr)) {
qlcnic_sre_macaddr_change(adapter, cur->mac_addr,
0, QLCNIC_MAC_DEL);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] qlcnic: Use list_for_each_entry() to simplify code in qlcnic_main.c
2021-06-16 4:21 [PATCH net-next] qlcnic: Use list_for_each_entry() to simplify code in qlcnic_main.c Wang Hai
@ 2021-06-16 7:50 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-06-16 7:50 UTC (permalink / raw)
To: Wang Hai
Cc: davem, kuba, shshaikh, manishc, GR-Linux-NIC-Dev, netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Wed, 16 Jun 2021 12:21:06 +0800 you wrote:
> Convert list_for_each() to list_for_each_entry() where
> applicable. This simplifies the code.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Hai <wanghai38@huawei.com>
> ---
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Here is the summary with links:
- [net-next] qlcnic: Use list_for_each_entry() to simplify code in qlcnic_main.c
https://git.kernel.org/netdev/net-next/c/56b57b809f9c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-16 7:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-16 4:21 [PATCH net-next] qlcnic: Use list_for_each_entry() to simplify code in qlcnic_main.c Wang Hai
2021-06-16 7:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).