From: 周琰杰 <zhouyanjie@wanyeetech.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Giuseppe CAVALLARO <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
netdev <netdev@vger.kernel.org>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"moderated list:ARM/STM32 ARCHITECTURE"
<linux-stm32@st-md-mailman.stormreply.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
dongsheng.qiu@ingenic.com, aric.pzqi@ingenic.com,
rick.tyliu@ingenic.com, sihui.liu@ingenic.com,
jun.jiang@ingenic.com, sernia.zhou@foxmail.com
Subject: Re: [PATCH v3 1/2] dt-bindings: dwmac: Add bindings for new Ingenic SoCs.
Date: Wed, 16 Jun 2021 15:45:26 +0800 [thread overview]
Message-ID: <20210616154526.54481912@zhouyanjie-virtual-machine> (raw)
In-Reply-To: <CAL_Jsq+7v6GRMfxWhA6g2r0GaZSO_AztgSz7rheJsE9jKYd8uQ@mail.gmail.com>
Hi Rob,
于 Tue, 15 Jun 2021 17:05:45 -0600
Rob Herring <robh+dt@kernel.org> 写道:
> On Mon, Jun 14, 2021 at 11:18 AM 周琰杰 (Zhou Yanjie)
> <zhouyanjie@wanyeetech.com> wrote:
> >
> > Add the dwmac bindings for the JZ4775 SoC, the X1000 SoC,
> > the X1600 SoC, the X1830 SoC and the X2000 SoC from Ingenic.
> >
> > Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
> > ---
> >
> > Notes:
> > v1->v2:
> > No change.
> >
> > v2->v3:
> > Add "ingenic,mac.yaml" for Ingenic SoCs.
> >
> > .../devicetree/bindings/net/ingenic,mac.yaml | 76
> > ++++++++++++++++++++++ .../devicetree/bindings/net/snps,dwmac.yaml
> > | 15 +++++ 2 files changed, 91 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/net/ingenic,mac.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/net/ingenic,mac.yaml
> > b/Documentation/devicetree/bindings/net/ingenic,mac.yaml new file
> > mode 100644 index 00000000..5fe2e81
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/net/ingenic,mac.yaml
> > @@ -0,0 +1,76 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/net/ingenic,mac.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Bindings for MAC in Ingenic SoCs
> > +
> > +maintainers:
> > + - 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
> > +
> > +description:
> > + The Ethernet Media Access Controller in Ingenic SoCs.
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - ingenic,jz4775-mac
> > + - ingenic,x1000-mac
> > + - ingenic,x1600-mac
> > + - ingenic,x1830-mac
> > + - ingenic,x2000-mac
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + interrupt-names:
> > + const: macirq
> > +
> > + clocks:
> > + maxItems: 1
> > +
> > + clock-names:
> > + const: stmmaceth
> > +
> > + mode-reg:
> > + description: An extra syscon register that control ethernet
> > interface and timing delay
>
> Needs a vendor prefix and type.
>
> > +
> > + rx-clk-delay-ps:
> > + description: RGMII receive clock delay defined in pico seconds
> > +
> > + tx-clk-delay-ps:
> > + description: RGMII transmit clock delay defined in pico seconds
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - interrupts
> > + - interrupt-names
> > + - clocks
> > + - clock-names
> > + - mode-reg
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/clock/x1000-cgu.h>
> > +
> > + mac: ethernet@134b0000 {
> > + compatible = "ingenic,x1000-mac", "snps,dwmac";
>
> Doesn't match the schema.
Sorry for that, somehow when I run "make dt_bindings_check", there is no
warrning or error message about this file. I am sure that yamllint is
installed and dtschema has been upgraded to 2021.6.
I will send a fix.
Thanks and best regards!
>
> > + reg = <0x134b0000 0x2000>;
> > +
> > + interrupt-parent = <&intc>;
> > + interrupts = <55>;
> > + interrupt-names = "macirq";
> > +
> > + clocks = <&cgu X1000_CLK_MAC>;
> > + clock-names = "stmmaceth";
> > +
> > + mode-reg = <&mac_phy_ctrl>;
> > + };
> > +...
> > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > b/Documentation/devicetree/bindings/net/snps,dwmac.yaml index
> > 2edd8be..9c0ce92 100644 ---
> > a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++
> > b/Documentation/devicetree/bindings/net/snps,dwmac.yaml @@ -56,6
> > +56,11 @@ properties:
> > - amlogic,meson8m2-dwmac
> > - amlogic,meson-gxbb-dwmac
> > - amlogic,meson-axg-dwmac
> > + - ingenic,jz4775-mac
> > + - ingenic,x1000-mac
> > + - ingenic,x1600-mac
> > + - ingenic,x1830-mac
> > + - ingenic,x2000-mac
> > - rockchip,px30-gmac
> > - rockchip,rk3128-gmac
> > - rockchip,rk3228-gmac
> > @@ -310,6 +315,11 @@ allOf:
> > - allwinner,sun8i-r40-emac
> > - allwinner,sun8i-v3s-emac
> > - allwinner,sun50i-a64-emac
> > + - ingenic,jz4775-mac
> > + - ingenic,x1000-mac
> > + - ingenic,x1600-mac
> > + - ingenic,x1830-mac
> > + - ingenic,x2000-mac
> > - snps,dwxgmac
> > - snps,dwxgmac-2.10
> > - st,spear600-gmac
> > @@ -353,6 +363,11 @@ allOf:
> > - allwinner,sun8i-r40-emac
> > - allwinner,sun8i-v3s-emac
> > - allwinner,sun50i-a64-emac
> > + - ingenic,jz4775-mac
> > + - ingenic,x1000-mac
> > + - ingenic,x1600-mac
> > + - ingenic,x1830-mac
> > + - ingenic,x2000-mac
> > - snps,dwmac-4.00
> > - snps,dwmac-4.10a
> > - snps,dwmac-4.20a
> > --
> > 2.7.4
>
next prev parent reply other threads:[~2021-06-16 7:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 17:15 [PATCH v3 0/2] Add Ingenic SoCs MAC support 周琰杰 (Zhou Yanjie)
2021-06-14 17:15 ` [PATCH v3 1/2] dt-bindings: dwmac: Add bindings for new Ingenic SoCs 周琰杰 (Zhou Yanjie)
2021-06-14 17:36 ` Andrew Lunn
2021-06-15 14:04 ` Rob Herring
2021-06-15 23:05 ` Rob Herring
2021-06-16 7:45 ` 周琰杰 [this message]
2021-06-17 3:24 ` 周琰杰
2021-06-18 19:50 ` Rob Herring
2021-06-14 17:15 ` [PATCH v3 2/2] net: stmmac: Add Ingenic SoCs MAC support 周琰杰 (Zhou Yanjie)
2021-06-14 17:36 ` Andrew Lunn
2021-06-14 20:20 ` [PATCH v3 0/2] " patchwork-bot+netdevbpf
2021-06-15 23:03 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210616154526.54481912@zhouyanjie-virtual-machine \
--to=zhouyanjie@wanyeetech.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alexandre.torgue@st.com \
--cc=aric.pzqi@ingenic.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dongsheng.qiu@ingenic.com \
--cc=joabreu@synopsys.com \
--cc=jun.jiang@ingenic.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=rick.tyliu@ingenic.com \
--cc=robh+dt@kernel.org \
--cc=sernia.zhou@foxmail.com \
--cc=sihui.liu@ingenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).