From: Rob Herring <robh@kernel.org>
To: "周琰杰 (Zhou Yanjie)" <zhouyanjie@wanyeetech.com>
Cc: linux-mediatek@lists.infradead.org, dongsheng.qiu@ingenic.com,
netdev@vger.kernel.org, peppe.cavallaro@st.com,
devicetree@vger.kernel.org, joabreu@synopsys.com,
kuba@kernel.org, davem@davemloft.net, sihui.liu@ingenic.com,
alexandre.torgue@st.com, mcoquelin.stm32@gmail.com,
aric.pzqi@ingenic.com, linux-kernel@vger.kernel.org,
matthias.bgg@gmail.com, linux-stm32@st-md-mailman.stormreply.com,
jun.jiang@ingenic.com, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org, rick.tyliu@ingenic.com,
sernia.zhou@foxmail.com, alexandre.torgue@foss.st.com
Subject: Re: [PATCH v3 1/2] dt-bindings: dwmac: Add bindings for new Ingenic SoCs.
Date: Tue, 15 Jun 2021 08:04:53 -0600 [thread overview]
Message-ID: <1623765893.376832.487354.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <1623690937-52389-2-git-send-email-zhouyanjie@wanyeetech.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 2082 bytes --]
On Tue, 15 Jun 2021 01:15:36 +0800, 周琰杰 (Zhou Yanjie) wrote:
> Add the dwmac bindings for the JZ4775 SoC, the X1000 SoC,
> the X1600 SoC, the X1830 SoC and the X2000 SoC from Ingenic.
>
> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
> ---
>
> Notes:
> v1->v2:
> No change.
>
> v2->v3:
> Add "ingenic,mac.yaml" for Ingenic SoCs.
>
> .../devicetree/bindings/net/ingenic,mac.yaml | 76 ++++++++++++++++++++++
> .../devicetree/bindings/net/snps,dwmac.yaml | 15 +++++
> 2 files changed, 91 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/ingenic,mac.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/ingenic,mac.example.dt.yaml: ethernet@134b0000: compatible: ['ingenic,x1000-mac', 'snps,dwmac'] is too long
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/ingenic,mac.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/ingenic,mac.example.dt.yaml: ethernet@134b0000: compatible: Additional items are not allowed ('snps,dwmac' was unexpected)
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/ingenic,mac.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/ingenic,mac.example.dt.yaml: ethernet@134b0000: 'phy-mode' is a required property
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/snps,dwmac.yaml
\ndoc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1491797
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2021-06-15 14:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 17:15 [PATCH v3 0/2] Add Ingenic SoCs MAC support 周琰杰 (Zhou Yanjie)
2021-06-14 17:15 ` [PATCH v3 1/2] dt-bindings: dwmac: Add bindings for new Ingenic SoCs 周琰杰 (Zhou Yanjie)
2021-06-14 17:36 ` Andrew Lunn
2021-06-15 14:04 ` Rob Herring [this message]
2021-06-15 23:05 ` Rob Herring
2021-06-16 7:45 ` 周琰杰
2021-06-17 3:24 ` 周琰杰
2021-06-18 19:50 ` Rob Herring
2021-06-14 17:15 ` [PATCH v3 2/2] net: stmmac: Add Ingenic SoCs MAC support 周琰杰 (Zhou Yanjie)
2021-06-14 17:36 ` Andrew Lunn
2021-06-14 20:20 ` [PATCH v3 0/2] " patchwork-bot+netdevbpf
2021-06-15 23:03 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1623765893.376832.487354.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=alexandre.torgue@st.com \
--cc=aric.pzqi@ingenic.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dongsheng.qiu@ingenic.com \
--cc=joabreu@synopsys.com \
--cc=jun.jiang@ingenic.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=rick.tyliu@ingenic.com \
--cc=robh+dt@kernel.org \
--cc=sernia.zhou@foxmail.com \
--cc=sihui.liu@ingenic.com \
--cc=zhouyanjie@wanyeetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).