From: Guenter Roeck <linux@roeck-us.net>
To: "Enrico Weigelt, metux IT consult" <info@metux.net>
Cc: linux-kernel@vger.kernel.org, wim@linux-watchdog.org,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH 2/2] watchdog: iTCO_wdt: use dev_err() instead of pr_err()
Date: Wed, 16 Jun 2021 19:02:21 -0700 [thread overview]
Message-ID: <20210617020221.GB3214397@roeck-us.net> (raw)
In-Reply-To: <20210616181708.19530-2-info@metux.net>
On Wed, Jun 16, 2021 at 08:17:08PM +0200, Enrico Weigelt, metux IT consult wrote:
> Use dev_err() instead of pr_err(), so device name is also shown in the log.
>
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/iTCO_wdt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/watchdog/iTCO_wdt.c b/drivers/watchdog/iTCO_wdt.c
> index 6ba2b2f60737..35ff8d3fd9fc 100644
> --- a/drivers/watchdog/iTCO_wdt.c
> +++ b/drivers/watchdog/iTCO_wdt.c
> @@ -479,13 +479,13 @@ static int iTCO_wdt_probe(struct platform_device *pdev)
> if (!devm_request_region(dev, p->smi_res->start,
> resource_size(p->smi_res),
> pdev->name)) {
> - pr_err("I/O address 0x%04llx already in use, device disabled\n",
> + dev_err(dev, "I/O address 0x%04llx already in use, device disabled\n",
> (u64)SMI_EN(p));
> return -EBUSY;
> }
> } else if (iTCO_vendorsupport ||
> turn_SMI_watchdog_clear_off >= p->iTCO_version) {
> - pr_err("SMI I/O resource is missing\n");
> + dev_err(dev, "SMI I/O resource is missing\n");
> return -ENODEV;
> }
>
> --
> 2.20.1
>
next prev parent reply other threads:[~2021-06-17 2:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 18:17 [PATCH 1/2] watchdog: iTCO_wdt: use pm_ptr() Enrico Weigelt, metux IT consult
2021-06-16 18:17 ` [PATCH 2/2] watchdog: iTCO_wdt: use dev_err() instead of pr_err() Enrico Weigelt, metux IT consult
2021-06-17 2:02 ` Guenter Roeck [this message]
2021-06-17 2:02 ` [PATCH 1/2] watchdog: iTCO_wdt: use pm_ptr() Guenter Roeck
2021-06-19 22:27 ` kernel test robot
2021-06-19 23:19 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210617020221.GB3214397@roeck-us.net \
--to=linux@roeck-us.net \
--cc=info@metux.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).