From: Guenter Roeck <linux@roeck-us.net>
To: kernel test robot <lkp@intel.com>
Cc: "Enrico Weigelt, metux IT consult" <info@metux.net>,
linux-kernel@vger.kernel.org, kbuild-all@lists.01.org,
wim@linux-watchdog.org, linux-watchdog@vger.kernel.org
Subject: Re: [PATCH 1/2] watchdog: iTCO_wdt: use pm_ptr()
Date: Sat, 19 Jun 2021 16:19:33 -0700 [thread overview]
Message-ID: <20210619231933.GA3821829@roeck-us.net> (raw)
In-Reply-To: <202106200634.4MqYLYfW-lkp@intel.com>
On Sun, Jun 20, 2021 at 06:27:52AM +0800, kernel test robot wrote:
> Hi "Enrico,
>
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on linux/master]
> [also build test ERROR on hwmon/hwmon-next linus/master v5.13-rc6 next-20210618]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url: https://github.com/0day-ci/linux/commits/Enrico-Weigelt-metux-IT-consult/watchdog-iTCO_wdt-use-pm_ptr/20210617-024441
> base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git dd860052c99b1e088352bdd4fb7aef46f8d2ef47
> config: ia64-allmodconfig (attached as .config)
> compiler: ia64-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://github.com/0day-ci/linux/commit/670a790c3acfccf4b5405459048ba2a05b912eef
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review Enrico-Weigelt-metux-IT-consult/watchdog-iTCO_wdt-use-pm_ptr/20210617-024441
> git checkout 670a790c3acfccf4b5405459048ba2a05b912eef
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> In file included from include/linux/device.h:25,
> from include/linux/acpi.h:15,
> from drivers/watchdog/iTCO_wdt.c:48:
> >> drivers/watchdog/iTCO_wdt.c:645:21: error: 'iTCO_wdt_pm' undeclared here (not in a function); did you mean 'iTCO_wdt_ops'?
> 645 | .pm = pm_ptr(&iTCO_wdt_pm),
> | ^~~~~~~~~~~
> include/linux/pm.h:377:23: note: in definition of macro 'pm_ptr'
> 377 | #define pm_ptr(_ptr) (_ptr)
> | ^~~~
>
>
> vim +645 drivers/watchdog/iTCO_wdt.c
>
> 640
> 641 static struct platform_driver iTCO_wdt_driver = {
> 642 .probe = iTCO_wdt_probe,
> 643 .driver = {
> 644 .name = DRV_NAME,
> > 645 .pm = pm_ptr(&iTCO_wdt_pm),
I'll drop this patch for now.
Guenter
> 646 },
> 647 };
> 648
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
prev parent reply other threads:[~2021-06-19 23:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 18:17 [PATCH 1/2] watchdog: iTCO_wdt: use pm_ptr() Enrico Weigelt, metux IT consult
2021-06-16 18:17 ` [PATCH 2/2] watchdog: iTCO_wdt: use dev_err() instead of pr_err() Enrico Weigelt, metux IT consult
2021-06-17 2:02 ` Guenter Roeck
2021-06-17 2:02 ` [PATCH 1/2] watchdog: iTCO_wdt: use pm_ptr() Guenter Roeck
2021-06-19 22:27 ` kernel test robot
2021-06-19 23:19 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210619231933.GA3821829@roeck-us.net \
--to=linux@roeck-us.net \
--cc=info@metux.net \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=lkp@intel.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).