* [PATCH v1 1/4] platform/x86: Remove "default n" entries
@ 2021-06-17 18:30 Andy Shevchenko
2021-06-17 18:30 ` [PATCH v1 2/4] platform/x86: intel_skl_int3472: Fix dependencies (drop CLKDEV_LOOKUP) Andy Shevchenko
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Andy Shevchenko @ 2021-06-17 18:30 UTC (permalink / raw)
To: Hans de Goede, Mario Limonciello, Andy Shevchenko, Daniel Scally,
Heikki Krogerus, linux-kernel, platform-driver-x86
Cc: Mark Gross
Linus already once did that for PDx86, don't repeat our mistakes.
TL;DR: 'n' *is* the default 'default'.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/platform/x86/Kconfig | 1 -
drivers/platform/x86/dell/Kconfig | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 4fd792f2a10a..ccb827b57f1f 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -1092,7 +1092,6 @@ config TOUCHSCREEN_DMI
config FW_ATTR_CLASS
tristate
- default n
config INTEL_IMR
bool "Intel Isolated Memory Region support"
diff --git a/drivers/platform/x86/dell/Kconfig b/drivers/platform/x86/dell/Kconfig
index 9b0a4d080f43..9e7314d90bea 100644
--- a/drivers/platform/x86/dell/Kconfig
+++ b/drivers/platform/x86/dell/Kconfig
@@ -5,7 +5,6 @@
menuconfig X86_PLATFORM_DRIVERS_DELL
bool "Dell X86 Platform Specific Device Drivers"
- default n
depends on X86_PLATFORM_DEVICES
help
Say Y here to get to see options for device drivers for various
--
2.30.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v1 2/4] platform/x86: intel_skl_int3472: Fix dependencies (drop CLKDEV_LOOKUP)
2021-06-17 18:30 [PATCH v1 1/4] platform/x86: Remove "default n" entries Andy Shevchenko
@ 2021-06-17 18:30 ` Andy Shevchenko
2021-06-17 22:50 ` Daniel Scally
2021-06-17 18:30 ` [PATCH v1 3/4] platform/x86: intel_skl_int3472: Move to intel/ subfolder Andy Shevchenko
2021-06-17 18:30 ` [PATCH v1 4/4] platform/x86: intel_cht_int33fe: Move to its own subfolder Andy Shevchenko
2 siblings, 1 reply; 7+ messages in thread
From: Andy Shevchenko @ 2021-06-17 18:30 UTC (permalink / raw)
To: Hans de Goede, Mario Limonciello, Andy Shevchenko, Daniel Scally,
Heikki Krogerus, linux-kernel, platform-driver-x86
Cc: Mark Gross
Besides the fact that COMMON_CLK selects CLKDEV_LOOKUP, the latter
is going to be removed from clock framework.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/platform/x86/intel-int3472/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/intel-int3472/Kconfig b/drivers/platform/x86/intel-int3472/Kconfig
index c112878e833b..62e5d4cf9ee5 100644
--- a/drivers/platform/x86/intel-int3472/Kconfig
+++ b/drivers/platform/x86/intel-int3472/Kconfig
@@ -1,7 +1,7 @@
config INTEL_SKL_INT3472
tristate "Intel SkyLake ACPI INT3472 Driver"
depends on ACPI
- depends on COMMON_CLK && CLKDEV_LOOKUP
+ depends on COMMON_CLK
depends on I2C
depends on GPIOLIB
depends on REGULATOR
--
2.30.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v1 3/4] platform/x86: intel_skl_int3472: Move to intel/ subfolder
2021-06-17 18:30 [PATCH v1 1/4] platform/x86: Remove "default n" entries Andy Shevchenko
2021-06-17 18:30 ` [PATCH v1 2/4] platform/x86: intel_skl_int3472: Fix dependencies (drop CLKDEV_LOOKUP) Andy Shevchenko
@ 2021-06-17 18:30 ` Andy Shevchenko
2021-06-17 18:30 ` [PATCH v1 4/4] platform/x86: intel_cht_int33fe: Move to its own subfolder Andy Shevchenko
2 siblings, 0 replies; 7+ messages in thread
From: Andy Shevchenko @ 2021-06-17 18:30 UTC (permalink / raw)
To: Hans de Goede, Mario Limonciello, Andy Shevchenko, Daniel Scally,
Heikki Krogerus, linux-kernel, platform-driver-x86
Cc: Mark Gross
Start collecting Intel x86 related drivers in its own subfolder.
Move intel_skl_int3472 first.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/platform/x86/Kconfig | 4 ++--
drivers/platform/x86/Makefile | 3 ++-
drivers/platform/x86/intel/Kconfig | 21 +++++++++++++++++++
drivers/platform/x86/intel/Makefile | 7 +++++++
.../{intel-int3472 => intel/int3472}/Kconfig | 0
.../{intel-int3472 => intel/int3472}/Makefile | 0
.../intel_skl_int3472_clk_and_regulator.c | 0
.../int3472}/intel_skl_int3472_common.c | 0
.../int3472}/intel_skl_int3472_common.h | 0
.../int3472}/intel_skl_int3472_discrete.c | 0
.../int3472}/intel_skl_int3472_tps68470.c | 0
11 files changed, 32 insertions(+), 3 deletions(-)
create mode 100644 drivers/platform/x86/intel/Kconfig
create mode 100644 drivers/platform/x86/intel/Makefile
rename drivers/platform/x86/{intel-int3472 => intel/int3472}/Kconfig (100%)
rename drivers/platform/x86/{intel-int3472 => intel/int3472}/Makefile (100%)
rename drivers/platform/x86/{intel-int3472 => intel/int3472}/intel_skl_int3472_clk_and_regulator.c (100%)
rename drivers/platform/x86/{intel-int3472 => intel/int3472}/intel_skl_int3472_common.c (100%)
rename drivers/platform/x86/{intel-int3472 => intel/int3472}/intel_skl_int3472_common.h (100%)
rename drivers/platform/x86/{intel-int3472 => intel/int3472}/intel_skl_int3472_discrete.c (100%)
rename drivers/platform/x86/{intel-int3472 => intel/int3472}/intel_skl_int3472_tps68470.c (100%)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index ccb827b57f1f..79d095c0ab61 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -651,6 +651,8 @@ config THINKPAD_LMI
To compile this driver as a module, choose M here: the module will
be called think-lmi.
+source "drivers/platform/x86/intel/Kconfig"
+
config INTEL_ATOMISP2_LED
tristate "Intel AtomISP2 camera LED driver"
depends on GPIOLIB && LEDS_GPIO
@@ -709,8 +711,6 @@ config INTEL_CHT_INT33FE
device and CONFIG_TYPEC_FUSB302=m and CONFIG_BATTERY_MAX17042=m
for Type-C device.
-source "drivers/platform/x86/intel-int3472/Kconfig"
-
config INTEL_HID_EVENT
tristate "INTEL HID Event"
depends on ACPI
diff --git a/drivers/platform/x86/Makefile b/drivers/platform/x86/Makefile
index a1f64613af71..e03b59ce3f9f 100644
--- a/drivers/platform/x86/Makefile
+++ b/drivers/platform/x86/Makefile
@@ -66,6 +66,8 @@ obj-$(CONFIG_THINKPAD_ACPI) += thinkpad_acpi.o
obj-$(CONFIG_THINKPAD_LMI) += think-lmi.o
# Intel
+obj-$(CONFIG_X86_PLATFORM_DRIVERS_INTEL) += intel/
+
obj-$(CONFIG_INTEL_ATOMISP2_LED) += intel_atomisp2_led.o
obj-$(CONFIG_INTEL_ATOMISP2_PM) += intel_atomisp2_pm.o
obj-$(CONFIG_INTEL_CHT_INT33FE) += intel_cht_int33fe.o
@@ -76,7 +78,6 @@ obj-$(CONFIG_INTEL_HID_EVENT) += intel-hid.o
obj-$(CONFIG_INTEL_INT0002_VGPIO) += intel_int0002_vgpio.o
obj-$(CONFIG_INTEL_MENLOW) += intel_menlow.o
obj-$(CONFIG_INTEL_OAKTRAIL) += intel_oaktrail.o
-obj-$(CONFIG_INTEL_SKL_INT3472) += intel-int3472/
obj-$(CONFIG_INTEL_VBTN) += intel-vbtn.o
# MSI
diff --git a/drivers/platform/x86/intel/Kconfig b/drivers/platform/x86/intel/Kconfig
new file mode 100644
index 000000000000..33f2dab03d3d
--- /dev/null
+++ b/drivers/platform/x86/intel/Kconfig
@@ -0,0 +1,21 @@
+# SPDX-License-Identifier: GPL-2.0-only
+#
+# Intel x86 Platform Specific Drivers
+#
+
+menuconfig X86_PLATFORM_DRIVERS_INTEL
+ bool "Intel x86 Platform Specific Device Drivers"
+ default y
+ help
+ Say Y here to get to see options for device drivers for
+ various Intel x86 platforms, including vendor-specific
+ drivers. This option alone does not add any kernel code.
+
+ If you say N, all options in this submenu will be skipped
+ and disabled.
+
+if X86_PLATFORM_DRIVERS_INTEL
+
+source "drivers/platform/x86/intel/int3472/Kconfig"
+
+endif # X86_PLATFORM_DRIVERS_INTEL
diff --git a/drivers/platform/x86/intel/Makefile b/drivers/platform/x86/intel/Makefile
new file mode 100644
index 000000000000..3ac795d810f1
--- /dev/null
+++ b/drivers/platform/x86/intel/Makefile
@@ -0,0 +1,7 @@
+# SPDX-License-Identifier: GPL-2.0
+#
+# Makefile for drivers/platform/x86/intel
+# Intel x86 Platform-Specific Drivers
+#
+
+obj-$(CONFIG_INTEL_SKL_INT3472) += int3472/
diff --git a/drivers/platform/x86/intel-int3472/Kconfig b/drivers/platform/x86/intel/int3472/Kconfig
similarity index 100%
rename from drivers/platform/x86/intel-int3472/Kconfig
rename to drivers/platform/x86/intel/int3472/Kconfig
diff --git a/drivers/platform/x86/intel-int3472/Makefile b/drivers/platform/x86/intel/int3472/Makefile
similarity index 100%
rename from drivers/platform/x86/intel-int3472/Makefile
rename to drivers/platform/x86/intel/int3472/Makefile
diff --git a/drivers/platform/x86/intel-int3472/intel_skl_int3472_clk_and_regulator.c b/drivers/platform/x86/intel/int3472/intel_skl_int3472_clk_and_regulator.c
similarity index 100%
rename from drivers/platform/x86/intel-int3472/intel_skl_int3472_clk_and_regulator.c
rename to drivers/platform/x86/intel/int3472/intel_skl_int3472_clk_and_regulator.c
diff --git a/drivers/platform/x86/intel-int3472/intel_skl_int3472_common.c b/drivers/platform/x86/intel/int3472/intel_skl_int3472_common.c
similarity index 100%
rename from drivers/platform/x86/intel-int3472/intel_skl_int3472_common.c
rename to drivers/platform/x86/intel/int3472/intel_skl_int3472_common.c
diff --git a/drivers/platform/x86/intel-int3472/intel_skl_int3472_common.h b/drivers/platform/x86/intel/int3472/intel_skl_int3472_common.h
similarity index 100%
rename from drivers/platform/x86/intel-int3472/intel_skl_int3472_common.h
rename to drivers/platform/x86/intel/int3472/intel_skl_int3472_common.h
diff --git a/drivers/platform/x86/intel-int3472/intel_skl_int3472_discrete.c b/drivers/platform/x86/intel/int3472/intel_skl_int3472_discrete.c
similarity index 100%
rename from drivers/platform/x86/intel-int3472/intel_skl_int3472_discrete.c
rename to drivers/platform/x86/intel/int3472/intel_skl_int3472_discrete.c
diff --git a/drivers/platform/x86/intel-int3472/intel_skl_int3472_tps68470.c b/drivers/platform/x86/intel/int3472/intel_skl_int3472_tps68470.c
similarity index 100%
rename from drivers/platform/x86/intel-int3472/intel_skl_int3472_tps68470.c
rename to drivers/platform/x86/intel/int3472/intel_skl_int3472_tps68470.c
--
2.30.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v1 4/4] platform/x86: intel_cht_int33fe: Move to its own subfolder
2021-06-17 18:30 [PATCH v1 1/4] platform/x86: Remove "default n" entries Andy Shevchenko
2021-06-17 18:30 ` [PATCH v1 2/4] platform/x86: intel_skl_int3472: Fix dependencies (drop CLKDEV_LOOKUP) Andy Shevchenko
2021-06-17 18:30 ` [PATCH v1 3/4] platform/x86: intel_skl_int3472: Move to intel/ subfolder Andy Shevchenko
@ 2021-06-17 18:30 ` Andy Shevchenko
2 siblings, 0 replies; 7+ messages in thread
From: Andy Shevchenko @ 2021-06-17 18:30 UTC (permalink / raw)
To: Hans de Goede, Mario Limonciello, Andy Shevchenko, Daniel Scally,
Heikki Krogerus, linux-kernel, platform-driver-x86
Cc: Mark Gross
Since we have started collecting Intel x86 specific drivers in its own folder,
Move intel_cht_int33fe to own subfolder there.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/platform/x86/Kconfig | 24 ------------------
drivers/platform/x86/Makefile | 4 ---
drivers/platform/x86/intel/Kconfig | 1 +
drivers/platform/x86/intel/Makefile | 1 +
drivers/platform/x86/intel/int33fe/Kconfig | 25 +++++++++++++++++++
drivers/platform/x86/intel/int33fe/Makefile | 5 ++++
.../int33fe}/intel_cht_int33fe_common.c | 0
.../int33fe}/intel_cht_int33fe_common.h | 0
.../int33fe}/intel_cht_int33fe_microb.c | 0
.../int33fe}/intel_cht_int33fe_typec.c | 0
10 files changed, 32 insertions(+), 28 deletions(-)
create mode 100644 drivers/platform/x86/intel/int33fe/Kconfig
create mode 100644 drivers/platform/x86/intel/int33fe/Makefile
rename drivers/platform/x86/{ => intel/int33fe}/intel_cht_int33fe_common.c (100%)
rename drivers/platform/x86/{ => intel/int33fe}/intel_cht_int33fe_common.h (100%)
rename drivers/platform/x86/{ => intel/int33fe}/intel_cht_int33fe_microb.c (100%)
rename drivers/platform/x86/{ => intel/int33fe}/intel_cht_int33fe_typec.c (100%)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 79d095c0ab61..7d385c3b2239 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -687,30 +687,6 @@ config INTEL_ATOMISP2_PM
To compile this driver as a module, choose M here: the module
will be called intel_atomisp2_pm.
-config INTEL_CHT_INT33FE
- tristate "Intel Cherry Trail ACPI INT33FE Driver"
- depends on X86 && ACPI && I2C && REGULATOR
- depends on CHARGER_BQ24190=y || (CHARGER_BQ24190=m && m)
- depends on USB_ROLES_INTEL_XHCI=y || (USB_ROLES_INTEL_XHCI=m && m)
- depends on TYPEC_MUX_PI3USB30532=y || (TYPEC_MUX_PI3USB30532=m && m)
- help
- This driver add support for the INT33FE ACPI device found on
- some Intel Cherry Trail devices.
-
- There are two kinds of INT33FE ACPI device possible: for hardware
- with USB Type-C and Micro-B connectors. This driver supports both.
-
- The INT33FE ACPI device has a CRS table with I2cSerialBusV2
- resources for Fuel Gauge Controller and (in the Type-C variant)
- FUSB302 USB Type-C Controller and PI3USB30532 USB switch.
- This driver instantiates i2c-clients for these, so that standard
- i2c drivers for these chips can bind to the them.
-
- If you enable this driver it is advised to also select
- CONFIG_BATTERY_BQ27XXX=m or CONFIG_BATTERY_BQ27XXX_I2C=m for Micro-B
- device and CONFIG_TYPEC_FUSB302=m and CONFIG_BATTERY_MAX17042=m
- for Type-C device.
-
config INTEL_HID_EVENT
tristate "INTEL HID Event"
depends on ACPI
diff --git a/drivers/platform/x86/Makefile b/drivers/platform/x86/Makefile
index e03b59ce3f9f..7ee369aab10d 100644
--- a/drivers/platform/x86/Makefile
+++ b/drivers/platform/x86/Makefile
@@ -70,10 +70,6 @@ obj-$(CONFIG_X86_PLATFORM_DRIVERS_INTEL) += intel/
obj-$(CONFIG_INTEL_ATOMISP2_LED) += intel_atomisp2_led.o
obj-$(CONFIG_INTEL_ATOMISP2_PM) += intel_atomisp2_pm.o
-obj-$(CONFIG_INTEL_CHT_INT33FE) += intel_cht_int33fe.o
-intel_cht_int33fe-objs := intel_cht_int33fe_common.o \
- intel_cht_int33fe_typec.o \
- intel_cht_int33fe_microb.o
obj-$(CONFIG_INTEL_HID_EVENT) += intel-hid.o
obj-$(CONFIG_INTEL_INT0002_VGPIO) += intel_int0002_vgpio.o
obj-$(CONFIG_INTEL_MENLOW) += intel_menlow.o
diff --git a/drivers/platform/x86/intel/Kconfig b/drivers/platform/x86/intel/Kconfig
index 33f2dab03d3d..f2eef337eb98 100644
--- a/drivers/platform/x86/intel/Kconfig
+++ b/drivers/platform/x86/intel/Kconfig
@@ -16,6 +16,7 @@ menuconfig X86_PLATFORM_DRIVERS_INTEL
if X86_PLATFORM_DRIVERS_INTEL
+source "drivers/platform/x86/intel/int33fe/Kconfig"
source "drivers/platform/x86/intel/int3472/Kconfig"
endif # X86_PLATFORM_DRIVERS_INTEL
diff --git a/drivers/platform/x86/intel/Makefile b/drivers/platform/x86/intel/Makefile
index 3ac795d810f1..0653055942d5 100644
--- a/drivers/platform/x86/intel/Makefile
+++ b/drivers/platform/x86/intel/Makefile
@@ -4,4 +4,5 @@
# Intel x86 Platform-Specific Drivers
#
+obj-$(CONFIG_INTEL_CHT_INT33FE) += int33fe/
obj-$(CONFIG_INTEL_SKL_INT3472) += int3472/
diff --git a/drivers/platform/x86/intel/int33fe/Kconfig b/drivers/platform/x86/intel/int33fe/Kconfig
new file mode 100644
index 000000000000..c7efb461d97d
--- /dev/null
+++ b/drivers/platform/x86/intel/int33fe/Kconfig
@@ -0,0 +1,25 @@
+# SPDX-License-Identifier: GPL-2.0-only
+config INTEL_CHT_INT33FE
+ tristate "Intel Cherry Trail ACPI INT33FE Driver"
+ depends on X86 && ACPI && I2C && REGULATOR
+ depends on CHARGER_BQ24190=y || (CHARGER_BQ24190=m && m)
+ depends on USB_ROLES_INTEL_XHCI=y || (USB_ROLES_INTEL_XHCI=m && m)
+ depends on TYPEC_MUX_PI3USB30532=y || (TYPEC_MUX_PI3USB30532=m && m)
+ help
+ This driver add support for the INT33FE ACPI device found on
+ some Intel Cherry Trail devices.
+
+ There are two kinds of INT33FE ACPI device possible: for hardware
+ with USB Type-C and Micro-B connectors. This driver supports both.
+
+ The INT33FE ACPI device has a CRS table with I2cSerialBusV2
+ resources for Fuel Gauge Controller and (in the Type-C variant)
+ FUSB302 USB Type-C Controller and PI3USB30532 USB switch.
+ This driver instantiates i2c-clients for these, so that standard
+ i2c drivers for these chips can bind to the them.
+
+ If you enable this driver it is advised to also select
+ CONFIG_BATTERY_BQ27XXX=m or CONFIG_BATTERY_BQ27XXX_I2C=m for Micro-B
+ device and CONFIG_TYPEC_FUSB302=m and CONFIG_BATTERY_MAX17042=m
+ for Type-C device.
+
diff --git a/drivers/platform/x86/intel/int33fe/Makefile b/drivers/platform/x86/intel/int33fe/Makefile
new file mode 100644
index 000000000000..cc11183ce179
--- /dev/null
+++ b/drivers/platform/x86/intel/int33fe/Makefile
@@ -0,0 +1,5 @@
+# SPDX-License-Identifier: GPL-2.0-only
+obj-$(CONFIG_INTEL_CHT_INT33FE) += intel_cht_int33fe.o
+intel_cht_int33fe-objs := intel_cht_int33fe_common.o \
+ intel_cht_int33fe_typec.o \
+ intel_cht_int33fe_microb.o
diff --git a/drivers/platform/x86/intel_cht_int33fe_common.c b/drivers/platform/x86/intel/int33fe/intel_cht_int33fe_common.c
similarity index 100%
rename from drivers/platform/x86/intel_cht_int33fe_common.c
rename to drivers/platform/x86/intel/int33fe/intel_cht_int33fe_common.c
diff --git a/drivers/platform/x86/intel_cht_int33fe_common.h b/drivers/platform/x86/intel/int33fe/intel_cht_int33fe_common.h
similarity index 100%
rename from drivers/platform/x86/intel_cht_int33fe_common.h
rename to drivers/platform/x86/intel/int33fe/intel_cht_int33fe_common.h
diff --git a/drivers/platform/x86/intel_cht_int33fe_microb.c b/drivers/platform/x86/intel/int33fe/intel_cht_int33fe_microb.c
similarity index 100%
rename from drivers/platform/x86/intel_cht_int33fe_microb.c
rename to drivers/platform/x86/intel/int33fe/intel_cht_int33fe_microb.c
diff --git a/drivers/platform/x86/intel_cht_int33fe_typec.c b/drivers/platform/x86/intel/int33fe/intel_cht_int33fe_typec.c
similarity index 100%
rename from drivers/platform/x86/intel_cht_int33fe_typec.c
rename to drivers/platform/x86/intel/int33fe/intel_cht_int33fe_typec.c
--
2.30.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v1 2/4] platform/x86: intel_skl_int3472: Fix dependencies (drop CLKDEV_LOOKUP)
2021-06-17 18:30 ` [PATCH v1 2/4] platform/x86: intel_skl_int3472: Fix dependencies (drop CLKDEV_LOOKUP) Andy Shevchenko
@ 2021-06-17 22:50 ` Daniel Scally
2021-06-18 12:56 ` Andy Shevchenko
0 siblings, 1 reply; 7+ messages in thread
From: Daniel Scally @ 2021-06-17 22:50 UTC (permalink / raw)
To: Andy Shevchenko, Hans de Goede, Mario Limonciello,
Heikki Krogerus, linux-kernel, platform-driver-x86
Cc: Mark Gross
Hi Andy
On 17/06/2021 19:30, Andy Shevchenko wrote:
> Besides the fact that COMMON_CLK selects CLKDEV_LOOKUP
So it does - thanks
> , the latter
> is going to be removed from clock framework.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Daniel Scally <djrscally@gmail.com>
> ---
> drivers/platform/x86/intel-int3472/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel-int3472/Kconfig b/drivers/platform/x86/intel-int3472/Kconfig
> index c112878e833b..62e5d4cf9ee5 100644
> --- a/drivers/platform/x86/intel-int3472/Kconfig
> +++ b/drivers/platform/x86/intel-int3472/Kconfig
> @@ -1,7 +1,7 @@
> config INTEL_SKL_INT3472
> tristate "Intel SkyLake ACPI INT3472 Driver"
> depends on ACPI
> - depends on COMMON_CLK && CLKDEV_LOOKUP
> + depends on COMMON_CLK
> depends on I2C
> depends on GPIOLIB
> depends on REGULATOR
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1 2/4] platform/x86: intel_skl_int3472: Fix dependencies (drop CLKDEV_LOOKUP)
2021-06-17 22:50 ` Daniel Scally
@ 2021-06-18 12:56 ` Andy Shevchenko
2021-06-18 13:06 ` Daniel Scally
0 siblings, 1 reply; 7+ messages in thread
From: Andy Shevchenko @ 2021-06-18 12:56 UTC (permalink / raw)
To: Daniel Scally
Cc: Hans de Goede, Mario Limonciello, Heikki Krogerus, linux-kernel,
platform-driver-x86, Mark Gross
On Thu, Jun 17, 2021 at 11:50:36PM +0100, Daniel Scally wrote:
> Hi Andy
>
> On 17/06/2021 19:30, Andy Shevchenko wrote:
> > Besides the fact that COMMON_CLK selects CLKDEV_LOOKUP
>
>
> So it does - thanks
>
> > , the latter
> > is going to be removed from clock framework.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
>
> Reviewed-by: Daniel Scally <djrscally@gmail.com>
Thanks!
I have sent v2 with more patches added (twice bigger than this).
Would you be able to test them?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1 2/4] platform/x86: intel_skl_int3472: Fix dependencies (drop CLKDEV_LOOKUP)
2021-06-18 12:56 ` Andy Shevchenko
@ 2021-06-18 13:06 ` Daniel Scally
0 siblings, 0 replies; 7+ messages in thread
From: Daniel Scally @ 2021-06-18 13:06 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Hans de Goede, Mario Limonciello, Heikki Krogerus, linux-kernel,
platform-driver-x86, Mark Gross
Hi Andy
On 18/06/2021 13:56, Andy Shevchenko wrote:
> On Thu, Jun 17, 2021 at 11:50:36PM +0100, Daniel Scally wrote:
>> Hi Andy
>>
>> On 17/06/2021 19:30, Andy Shevchenko wrote:
>>> Besides the fact that COMMON_CLK selects CLKDEV_LOOKUP
>>
>> So it does - thanks
>>
>>> , the latter
>>> is going to be removed from clock framework.
>>>
>>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>>
>> Reviewed-by: Daniel Scally <djrscally@gmail.com>
> Thanks!
> I have sent v2 with more patches added (twice bigger than this).
> Would you be able to test them?
>
Sure - I'll test them later tonight - thanks!
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-06-18 13:06 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-17 18:30 [PATCH v1 1/4] platform/x86: Remove "default n" entries Andy Shevchenko
2021-06-17 18:30 ` [PATCH v1 2/4] platform/x86: intel_skl_int3472: Fix dependencies (drop CLKDEV_LOOKUP) Andy Shevchenko
2021-06-17 22:50 ` Daniel Scally
2021-06-18 12:56 ` Andy Shevchenko
2021-06-18 13:06 ` Daniel Scally
2021-06-17 18:30 ` [PATCH v1 3/4] platform/x86: intel_skl_int3472: Move to intel/ subfolder Andy Shevchenko
2021-06-17 18:30 ` [PATCH v1 4/4] platform/x86: intel_cht_int33fe: Move to its own subfolder Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).