From: Steven Rostedt <rostedt@goodmis.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Ingo Molnar <mingo@redhat.com>, Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests/ftrace: fix event-no-pid on 1-core machine
Date: Wed, 23 Jun 2021 08:52:17 -0400 [thread overview]
Message-ID: <20210623085217.036b7e8d@gandalf.local.home> (raw)
In-Reply-To: <20210623070431.16592-1-krzysztof.kozlowski@canonical.com>
On Wed, 23 Jun 2021 09:04:31 +0200
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote:
> When running event-no-pid test on a small machines (e.g. cloud 1-core
> instance), other events might not happen:
>
> + cat trace
> + cnt=0
> + [ 0 -eq 0 ]
> + fail No other events were recorded
> [15] event tracing - restricts events based on pid notrace filtering [FAIL]
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Shua, do you want to take this?
-- Steve
>
> Schedule a simple sleep task to be sure that some other process events
> get recorder.
>
> Fixes: ebed9628f5c2 ("selftests/ftrace: Add test to test new set_event_notrace_pid file")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
> .../testing/selftests/ftrace/test.d/event/event-no-pid.tc | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/tools/testing/selftests/ftrace/test.d/event/event-no-pid.tc b/tools/testing/selftests/ftrace/test.d/event/event-no-pid.tc
> index e6eb78f0b954..9933ed24f901 100644
> --- a/tools/testing/selftests/ftrace/test.d/event/event-no-pid.tc
> +++ b/tools/testing/selftests/ftrace/test.d/event/event-no-pid.tc
> @@ -57,6 +57,10 @@ enable_events() {
> echo 1 > tracing_on
> }
>
> +other_task() {
> + sleep .001 || usleep 1 || sleep 1
> +}
> +
> echo 0 > options/event-fork
>
> do_reset
> @@ -94,6 +98,9 @@ child=$!
> echo "child = $child"
> wait $child
>
> +# Be sure some other events will happen for small systems (e.g. 1 core)
> +other_task
> +
> echo 0 > tracing_on
>
> cnt=`count_pid $mypid`
next prev parent reply other threads:[~2021-06-23 12:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 7:04 [PATCH] selftests/ftrace: fix event-no-pid on 1-core machine Krzysztof Kozlowski
2021-06-23 12:52 ` Steven Rostedt [this message]
2021-06-23 13:36 ` Krzysztof Kozlowski
2021-06-23 13:39 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210623085217.036b7e8d@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).