From: Alan Stern <stern@rowland.harvard.edu>
To: Claudiu.Beznea@microchip.com
Cc: gregkh@linuxfoundation.org, Nicolas.Ferre@microchip.com,
alexandre.belloni@bootlin.com, Ludovic.Desroches@microchip.com,
Cristian.Birsan@microchip.com, linux-usb@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: host: ohci-at91: suspend/resume ports after/before OHCI accesses
Date: Wed, 23 Jun 2021 12:41:48 -0400 [thread overview]
Message-ID: <20210623164148.GC499969@rowland.harvard.edu> (raw)
In-Reply-To: <8bff20a7-8eb8-276a-086e-f1729fbbdbe4@microchip.com>
On Wed, Jun 23, 2021 at 02:33:14PM +0000, Claudiu.Beznea@microchip.com wrote:
> On 23.06.2021 17:19, Alan Stern wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> >
> > On Wed, Jun 23, 2021 at 02:09:16PM +0000, Claudiu.Beznea@microchip.com wrote:
> >> On 23.06.2021 16:59, Alan Stern wrote:
> >>> One thing you might consider changing: The name of the
> >>> ohci_at91_port_suspend routine is misleading. It doesn't really
> >>> handle suspending the port; instead it handles the clocks that drive
> >>> the entire OHCI controller. Right?
> >>
> >> It does both as far as I can tell at the moment.
> >
> > But the name suggests that it only handles suspending a port. That's
> > misleading.
> >
> > And the way it is used in the SetPortFeature(USB_PORT_FEAT_SUSPEND)
> > case in ohci_at91_hub_control is just plain wrong. It won't merely
> > suspend a single port; it will disable the entire OHCI controller.
>
> Agree with all the above!
Are there any systems beside the SAMA7G5 and others you tested which
might be affected by this patch? Do they all work pretty much the
same way? (I want to make sure no others will be adversely affected
by this change.)
Alan Stern
next prev parent reply other threads:[~2021-06-23 16:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 12:10 [PATCH] usb: host: ohci-at91: suspend/resume ports after/before OHCI accesses Claudiu Beznea
2021-06-09 12:40 ` Nicolas Ferre
2021-06-09 23:07 ` Alan Stern
2021-06-23 12:47 ` Claudiu.Beznea
2021-06-23 13:59 ` Alan Stern
2021-06-23 14:09 ` Claudiu.Beznea
2021-06-23 14:19 ` Alan Stern
2021-06-23 14:33 ` Claudiu.Beznea
2021-06-23 16:41 ` Alan Stern [this message]
2021-06-24 6:40 ` Claudiu.Beznea
2021-06-24 6:54 ` Claudiu.Beznea
2021-06-24 13:23 ` Alan Stern
2021-06-30 14:46 ` Claudiu.Beznea
2021-06-30 18:21 ` Alan Stern
2021-07-01 5:45 ` Claudiu.Beznea
2021-07-01 14:01 ` Alan Stern
2021-06-30 14:47 ` Claudiu.Beznea
2021-07-21 8:08 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210623164148.GC499969@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=Claudiu.Beznea@microchip.com \
--cc=Cristian.Birsan@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).