* [PATCH v2 -next] crypto: sl3516 - Fix build warning without CONFIG_PM
@ 2021-06-18 9:35 YueHaibing
2021-06-24 7:36 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2021-06-18 9:35 UTC (permalink / raw)
To: ulli.kroll, linus.walleij, clabbe, herbert, davem
Cc: linux-arm-kernel, linux-crypto, linux-kernel, YueHaibing
drivers/crypto/gemini/sl3516-ce-core.c:345:12:
warning: ‘sl3516_ce_pm_resume’ defined but not used [-Wunused-function]
static int sl3516_ce_pm_resume(struct device *dev)
^~~~~~~~~~~~~~~~~~~
The driver needs PM, otherwise clock and resets are never set.
So make it depends on PM to fix this warning.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Suggested-by: LABBE Corentin <clabbe@baylibre.com>
---
v2: Using depends on PM instead of #ifdef macro
drivers/crypto/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index 99b090790178..6f14f39d32e3 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -273,6 +273,7 @@ config CRYPTO_DEV_SL3516
select CRYPTO_ECB
select CRYPTO_AES
select HW_RANDOM
+ depends on PM
help
This option allows you to have support for SL3516 crypto offloader.
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 -next] crypto: sl3516 - Fix build warning without CONFIG_PM
2021-06-18 9:35 [PATCH v2 -next] crypto: sl3516 - Fix build warning without CONFIG_PM YueHaibing
@ 2021-06-24 7:36 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2021-06-24 7:36 UTC (permalink / raw)
To: YueHaibing
Cc: ulli.kroll, linus.walleij, clabbe, davem, linux-arm-kernel,
linux-crypto, linux-kernel
On Fri, Jun 18, 2021 at 05:35:51PM +0800, YueHaibing wrote:
> drivers/crypto/gemini/sl3516-ce-core.c:345:12:
> warning: ‘sl3516_ce_pm_resume’ defined but not used [-Wunused-function]
> static int sl3516_ce_pm_resume(struct device *dev)
> ^~~~~~~~~~~~~~~~~~~
>
> The driver needs PM, otherwise clock and resets are never set.
> So make it depends on PM to fix this warning.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> Suggested-by: LABBE Corentin <clabbe@baylibre.com>
> ---
> v2: Using depends on PM instead of #ifdef macro
>
> drivers/crypto/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-24 7:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-18 9:35 [PATCH v2 -next] crypto: sl3516 - Fix build warning without CONFIG_PM YueHaibing
2021-06-24 7:36 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).