* [PATCH] drm/gma500: Add the missed drm_gem_object_put() in psb_user_framebuffer_create()
@ 2021-06-29 11:59 Jing Xiangfeng
2021-07-09 19:35 ` Patrik Jakobsson
0 siblings, 1 reply; 2+ messages in thread
From: Jing Xiangfeng @ 2021-06-29 11:59 UTC (permalink / raw)
To: patrik.r.jakobsson, airlied, daniel
Cc: dri-devel, linux-kernel, jingxiangfeng
psb_user_framebuffer_create() misses to call drm_gem_object_put() in an
error path. Add the missed function call to fix it.
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
---
drivers/gpu/drm/gma500/framebuffer.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c
index ebe9dccf2d83..0b8648396fb2 100644
--- a/drivers/gpu/drm/gma500/framebuffer.c
+++ b/drivers/gpu/drm/gma500/framebuffer.c
@@ -352,6 +352,7 @@ static struct drm_framebuffer *psb_user_framebuffer_create
const struct drm_mode_fb_cmd2 *cmd)
{
struct drm_gem_object *obj;
+ struct drm_framebuffer *fb;
/*
* Find the GEM object and thus the gtt range object that is
@@ -362,7 +363,11 @@ static struct drm_framebuffer *psb_user_framebuffer_create
return ERR_PTR(-ENOENT);
/* Let the core code do all the work */
- return psb_framebuffer_create(dev, cmd, obj);
+ fb = psb_framebuffer_create(dev, cmd, obj);
+ if (IS_ERR(fb))
+ drm_gem_object_put(obj);
+
+ return fb;
}
static int psbfb_probe(struct drm_fb_helper *fb_helper,
--
2.26.0.106.g9fadedd
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/gma500: Add the missed drm_gem_object_put() in psb_user_framebuffer_create()
2021-06-29 11:59 [PATCH] drm/gma500: Add the missed drm_gem_object_put() in psb_user_framebuffer_create() Jing Xiangfeng
@ 2021-07-09 19:35 ` Patrik Jakobsson
0 siblings, 0 replies; 2+ messages in thread
From: Patrik Jakobsson @ 2021-07-09 19:35 UTC (permalink / raw)
To: Jing Xiangfeng; +Cc: David Airlie, Daniel Vetter, dri-devel, linux-kernel
On Tue, Jun 29, 2021 at 1:52 PM Jing Xiangfeng <jingxiangfeng@huawei.com> wrote:
>
> psb_user_framebuffer_create() misses to call drm_gem_object_put() in an
> error path. Add the missed function call to fix it.
>
Sorry for the delay, I'm currently on vacation.
Looks good. Thanks for the patch.
Applied to drm-misc-next
-Patrik
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
> ---
> drivers/gpu/drm/gma500/framebuffer.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c
> index ebe9dccf2d83..0b8648396fb2 100644
> --- a/drivers/gpu/drm/gma500/framebuffer.c
> +++ b/drivers/gpu/drm/gma500/framebuffer.c
> @@ -352,6 +352,7 @@ static struct drm_framebuffer *psb_user_framebuffer_create
> const struct drm_mode_fb_cmd2 *cmd)
> {
> struct drm_gem_object *obj;
> + struct drm_framebuffer *fb;
>
> /*
> * Find the GEM object and thus the gtt range object that is
> @@ -362,7 +363,11 @@ static struct drm_framebuffer *psb_user_framebuffer_create
> return ERR_PTR(-ENOENT);
>
> /* Let the core code do all the work */
> - return psb_framebuffer_create(dev, cmd, obj);
> + fb = psb_framebuffer_create(dev, cmd, obj);
> + if (IS_ERR(fb))
> + drm_gem_object_put(obj);
> +
> + return fb;
> }
>
> static int psbfb_probe(struct drm_fb_helper *fb_helper,
> --
> 2.26.0.106.g9fadedd
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-09 19:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-29 11:59 [PATCH] drm/gma500: Add the missed drm_gem_object_put() in psb_user_framebuffer_create() Jing Xiangfeng
2021-07-09 19:35 ` Patrik Jakobsson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).