* [PATCH] pinctrl: ralink: rt305x: add missing include
@ 2021-06-29 14:34 Sergio Paracuellos
2021-06-30 0:40 ` Linus Walleij
0 siblings, 1 reply; 3+ messages in thread
From: Sergio Paracuellos @ 2021-06-29 14:34 UTC (permalink / raw)
To: linus.walleij; +Cc: linux-gpio, linux-kernel, kernel test robot
Header 'rt305x.h' is ralink architecture dependent file where
other general definitions which are in 'ralink_regs.h' are
being used. This 'rt305x.h' is only being included in two
different files: 'rt305x.c' and 'pinctrl-rt305x.c'. When
file 'pinctrl-rt305x.c' is being compiled definitions in
'ralink_regs.h' are need to build it properly. Hence, add
missing include 'ralink_regs.h' in 'pinctrl-rt305x.c'
source to avoid compilation problems.
Fixes: 3a1b0ca5a83b ("pinctrl: ralink: move RT305X SoC pinmux config into a new 'pinctrl-rt305x.c' file")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
---
drivers/pinctrl/ralink/pinctrl-rt305x.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/ralink/pinctrl-rt305x.c b/drivers/pinctrl/ralink/pinctrl-rt305x.c
index 699fe18e7000..5d8fa156c003 100644
--- a/drivers/pinctrl/ralink/pinctrl-rt305x.c
+++ b/drivers/pinctrl/ralink/pinctrl-rt305x.c
@@ -1,5 +1,6 @@
// SPDX-License-Identifier: GPL-2.0-only
+#include <asm/mach-ralink/ralink_regs.h>
#include <asm/mach-ralink/rt305x.h>
#include <linux/module.h>
#include <linux/platform_device.h>
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: ralink: rt305x: add missing include
2021-06-29 14:34 [PATCH] pinctrl: ralink: rt305x: add missing include Sergio Paracuellos
@ 2021-06-30 0:40 ` Linus Walleij
2021-06-30 6:38 ` Sergio Paracuellos
0 siblings, 1 reply; 3+ messages in thread
From: Linus Walleij @ 2021-06-30 0:40 UTC (permalink / raw)
To: Sergio Paracuellos
Cc: open list:GPIO SUBSYSTEM, linux-kernel, kernel test robot
On Tue, Jun 29, 2021 at 4:34 PM Sergio Paracuellos
<sergio.paracuellos@gmail.com> wrote:
> Header 'rt305x.h' is ralink architecture dependent file where
> other general definitions which are in 'ralink_regs.h' are
> being used. This 'rt305x.h' is only being included in two
> different files: 'rt305x.c' and 'pinctrl-rt305x.c'. When
> file 'pinctrl-rt305x.c' is being compiled definitions in
> 'ralink_regs.h' are need to build it properly. Hence, add
> missing include 'ralink_regs.h' in 'pinctrl-rt305x.c'
> source to avoid compilation problems.
>
> Fixes: 3a1b0ca5a83b ("pinctrl: ralink: move RT305X SoC pinmux config into a new 'pinctrl-rt305x.c' file")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Patch applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: ralink: rt305x: add missing include
2021-06-30 0:40 ` Linus Walleij
@ 2021-06-30 6:38 ` Sergio Paracuellos
0 siblings, 0 replies; 3+ messages in thread
From: Sergio Paracuellos @ 2021-06-30 6:38 UTC (permalink / raw)
To: Linus Walleij; +Cc: open list:GPIO SUBSYSTEM, linux-kernel, kernel test robot
On Wed, Jun 30, 2021 at 2:40 AM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Tue, Jun 29, 2021 at 4:34 PM Sergio Paracuellos
> <sergio.paracuellos@gmail.com> wrote:
>
> > Header 'rt305x.h' is ralink architecture dependent file where
> > other general definitions which are in 'ralink_regs.h' are
> > being used. This 'rt305x.h' is only being included in two
> > different files: 'rt305x.c' and 'pinctrl-rt305x.c'. When
> > file 'pinctrl-rt305x.c' is being compiled definitions in
> > 'ralink_regs.h' are need to build it properly. Hence, add
> > missing include 'ralink_regs.h' in 'pinctrl-rt305x.c'
> > source to avoid compilation problems.
> >
> > Fixes: 3a1b0ca5a83b ("pinctrl: ralink: move RT305X SoC pinmux config into a new 'pinctrl-rt305x.c' file")
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
>
> Patch applied!
Thanks!
Best regards,
Sergio Paracuellos
>
> Yours,
> Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-30 6:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-29 14:34 [PATCH] pinctrl: ralink: rt305x: add missing include Sergio Paracuellos
2021-06-30 0:40 ` Linus Walleij
2021-06-30 6:38 ` Sergio Paracuellos
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).