[PATCH v1 0/1] mtd: spi-nor: Add some M45PEx ids

linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH v1 0/1] mtd: spi-nor: Add some M45PEx ids
@ 2021-06-29 15:08 Hongwei Zhang
  2021-06-29 15:08 ` [PATCH v1 1/1] " Hongwei Zhang
  0 siblings, 1 reply; 6+ messages in thread
From: Hongwei Zhang @ 2021-06-29 15:08 UTC (permalink / raw)
  To: Tudor Ambarus, Michael Walle, Pratyush Yadav
  Cc: Hongwei Zhang, linux-mtd, linux-kernel

Dear Reviewer,

Add some Micron M45PEx flash memeories into the IDs table.

Hongwei Zhang (1):
  mtd: spi-nor: Add some M45PEx ids

 drivers/mtd/spi-nor/micron-st.c | 4 ++++
 1 file changed, 4 insertions(+)

-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v1 1/1] mtd: spi-nor: Add some M45PEx ids
  2021-06-29 15:08 [PATCH v1 0/1] mtd: spi-nor: Add some M45PEx ids Hongwei Zhang
@ 2021-06-29 15:08 ` Hongwei Zhang
  2021-06-30 13:56   ` Michael Walle
                     ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Hongwei Zhang @ 2021-06-29 15:08 UTC (permalink / raw)
  To: Tudor Ambarus, Michael Walle, Pratyush Yadav
  Cc: Hongwei Zhang, linux-mtd, linux-kernel

Add some Micron M45PEx flash memeories into the IDs table.

Fixes: dd1e9367157f900616f (ARM: dts: everest: Add phase corrections for
eMMC)

Signed-off-by: Hongwei Zhang <hongweiz@ami.com>
---
 drivers/mtd/spi-nor/micron-st.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/mtd/spi-nor/micron-st.c b/drivers/mtd/spi-nor/micron-st.c
index ef3695080710..379b14e339ff 100644
--- a/drivers/mtd/spi-nor/micron-st.c
+++ b/drivers/mtd/spi-nor/micron-st.c
@@ -95,8 +95,12 @@ static const struct flash_info st_parts[] = {
 	{ "m25p128-nonjedec", INFO(0, 0, 256 * 1024,  64, 0) },
 
 	{ "m45pe10", INFO(0x204011,  0, 64 * 1024,    2, 0) },
+	{ "m45pe20", INFO(0x204012,  0, 64 * 1024,    4, 0) },
+	{ "m45pe40", INFO(0x204013,  0, 64 * 1024,    8, 0) },
 	{ "m45pe80", INFO(0x204014,  0, 64 * 1024,   16, 0) },
 	{ "m45pe16", INFO(0x204015,  0, 64 * 1024,   32, 0) },
+	{ "m45pe32", INFO(0x204016,  0, 64 * 1024,   64, 0) },
+	{ "m45pe64", INFO(0x204017,  0, 64 * 1024,  128, 0) },
 
 	{ "m25pe20", INFO(0x208012,  0, 64 * 1024,  4,       0) },
 	{ "m25pe80", INFO(0x208014,  0, 64 * 1024, 16,       0) },
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v1 1/1] mtd: spi-nor: Add some M45PEx ids
  2021-06-29 15:08 ` [PATCH v1 1/1] " Hongwei Zhang
@ 2021-06-30 13:56   ` Michael Walle
  2021-06-30 18:20   ` Hongwei Zhang
  2021-07-01 15:18   ` Hongwei Zhang
  2 siblings, 0 replies; 6+ messages in thread
From: Michael Walle @ 2021-06-30 13:56 UTC (permalink / raw)
  To: Hongwei Zhang; +Cc: Tudor Ambarus, Pratyush Yadav, linux-mtd, linux-kernel

Hi Hongwei,

Am 2021-06-29 17:08, schrieb Hongwei Zhang:
> Add some Micron M45PEx flash memeories into the IDs table.

Did you test all these flashes?

> Fixes: dd1e9367157f900616f (ARM: dts: everest: Add phase corrections 
> for
> eMMC)

Bogus Fixes tag. First, I cannot find this commit id, which tree is
that? Secondly, adding new flash ids don't fix anything, esp not
something related to eMMC.

> 
> Signed-off-by: Hongwei Zhang <hongweiz@ami.com>
> ---
>  drivers/mtd/spi-nor/micron-st.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/mtd/spi-nor/micron-st.c 
> b/drivers/mtd/spi-nor/micron-st.c
> index ef3695080710..379b14e339ff 100644
> --- a/drivers/mtd/spi-nor/micron-st.c
> +++ b/drivers/mtd/spi-nor/micron-st.c
> @@ -95,8 +95,12 @@ static const struct flash_info st_parts[] = {
>  	{ "m25p128-nonjedec", INFO(0, 0, 256 * 1024,  64, 0) },
> 
>  	{ "m45pe10", INFO(0x204011,  0, 64 * 1024,    2, 0) },
> +	{ "m45pe20", INFO(0x204012,  0, 64 * 1024,    4, 0) },
> +	{ "m45pe40", INFO(0x204013,  0, 64 * 1024,    8, 0) },
>  	{ "m45pe80", INFO(0x204014,  0, 64 * 1024,   16, 0) },
>  	{ "m45pe16", INFO(0x204015,  0, 64 * 1024,   32, 0) },
> +	{ "m45pe32", INFO(0x204016,  0, 64 * 1024,   64, 0) },
> +	{ "m45pe64", INFO(0x204017,  0, 64 * 1024,  128, 0) },
> 
>  	{ "m25pe20", INFO(0x208012,  0, 64 * 1024,  4,       0) },
>  	{ "m25pe80", INFO(0x208014,  0, 64 * 1024, 16,       0) },

-- 
-michael

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v1 1/1] mtd: spi-nor: Add some M45PEx ids
  2021-06-29 15:08 ` [PATCH v1 1/1] " Hongwei Zhang
  2021-06-30 13:56   ` Michael Walle
@ 2021-06-30 18:20   ` Hongwei Zhang
  2021-07-01 10:02     ` Michael Walle
  2021-07-01 15:18   ` Hongwei Zhang
  2 siblings, 1 reply; 6+ messages in thread
From: Hongwei Zhang @ 2021-06-30 18:20 UTC (permalink / raw)
  To: Michael Walle
  Cc: Hongwei Zhang, Tudor Ambarus, Pratyush Yadav, linux-mtd, linux-kernel

Hi Michael,

>Subject:	[EXTERNAL] Re: [PATCH v1 1/1] mtd: spi-nor: Add some M45PEx ids
>
>Hi Hongwei,
>
>Am 2021-06-29 17:08, schrieb Hongwei Zhang:
>> Add some Micron M45PEx flash memeories into the IDs table.
>
>Did you test all these flashes?
>
No, the patch was added in porting drivers related to AST2600 EVB.

>> Fixes: dd1e9367157f900616f (ARM: dts: everest: Add phase corrections
>> for
>> eMMC)
>
>Bogus Fixes tag. First, I cannot find this commit id, which tree is
>that? Secondly, adding new flash ids don't fix anything, esp not
>something related to eMMC.
>
Sorry for the confusion, I thought Fixes tag could be also used for referencing
the revision base for the patch to aplly on.
I used dev-5.10 branch from https://github.com/openbmc/linux.git , should I
use a different repository?

Thanks,
--Hongwei
>>
>> Signed-off-by: Hongwei Zhang <hongweiz@ami.com>
>> ---
>>  drivers/mtd/spi-nor/micron-st.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/mtd/spi-nor/micron-st.c
>> b/drivers/mtd/spi-nor/micron-st.c
>> index ef3695080710..379b14e339ff 100644
>> --- a/drivers/mtd/spi-nor/micron-st.c
>> +++ b/drivers/mtd/spi-nor/micron-st.c
>> @@ -95,8 +95,12 @@ static const struct flash_info st_parts[] = {
>>       { "m25p128-nonjedec", INFO(0, 0, 256 * 1024,  64, 0) },
>>
>>       { "m45pe10", INFO(0x204011,  0, 64 * 1024,    2, 0) },
>> +     { "m45pe20", INFO(0x204012,  0, 64 * 1024,    4, 0) },
>> +     { "m45pe40", INFO(0x204013,  0, 64 * 1024,    8, 0) },
>>       { "m45pe80", INFO(0x204014,  0, 64 * 1024,   16, 0) },
>>       { "m45pe16", INFO(0x204015,  0, 64 * 1024,   32, 0) },
>> +     { "m45pe32", INFO(0x204016,  0, 64 * 1024,   64, 0) },
>> +     { "m45pe64", INFO(0x204017,  0, 64 * 1024,  128, 0) },
>>
>>       { "m25pe20", INFO(0x208012,  0, 64 * 1024,  4,       0) },
>>       { "m25pe80", INFO(0x208014,  0, 64 * 1024, 16,       0) },
>
>--
>-michael
>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v1 1/1] mtd: spi-nor: Add some M45PEx ids
  2021-06-30 18:20   ` Hongwei Zhang
@ 2021-07-01 10:02     ` Michael Walle
  0 siblings, 0 replies; 6+ messages in thread
From: Michael Walle @ 2021-07-01 10:02 UTC (permalink / raw)
  To: Hongwei Zhang; +Cc: Tudor Ambarus, Pratyush Yadav, linux-mtd, linux-kernel

Hi Hongwei,

Am 2021-06-30 20:20, schrieb Hongwei Zhang:
>> Am 2021-06-29 17:08, schrieb Hongwei Zhang:
>>> Add some Micron M45PEx flash memeories into the IDs table.
>> 
>> Did you test all these flashes?
>> 
> No, the patch was added in porting drivers related to AST2600 EVB.

Please note, that all flashes which are added must be tested.

>>> Fixes: dd1e9367157f900616f (ARM: dts: everest: Add phase corrections
>>> for
>>> eMMC)
>> 
>> Bogus Fixes tag. First, I cannot find this commit id, which tree is
>> that? Secondly, adding new flash ids don't fix anything, esp not
>> something related to eMMC.
>> 
> Sorry for the confusion, I thought Fixes tag could be also used for 
> referencing
> the revision base for the patch to aplly on.
> I used dev-5.10 branch from https://github.com/openbmc/linux.git , 
> should I
> use a different repository?

AFAIK commits in fixes tags must be relative to Linus Torvalds' tree
(or a subtree must not rebase, like the networking trees, which means
they will end up in Torvalds' tree).

Anyway, this is not a fix and therefore there must be no Fixes: tag.

-michael

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v1 1/1] mtd: spi-nor: Add some M45PEx ids
  2021-06-29 15:08 ` [PATCH v1 1/1] " Hongwei Zhang
  2021-06-30 13:56   ` Michael Walle
  2021-06-30 18:20   ` Hongwei Zhang
@ 2021-07-01 15:18   ` Hongwei Zhang
  2 siblings, 0 replies; 6+ messages in thread
From: Hongwei Zhang @ 2021-07-01 15:18 UTC (permalink / raw)
  To: Michael Walle
  Cc: Hongwei Zhang, Tudor Ambarus, Pratyush Yadav, linux-mtd, linux-kernel

Hi Michael,

Ok, I will separately resubmit a revised patch with update later.

Regards,
--Hongwei

>Subject:	[EXTERNAL] Re: [PATCH v1 1/1] mtd: spi-nor: Add some M45PEx ids
>
>>> Am 2021-06-29 17:08, schrieb Hongwei Zhang:
>>>> Add some Micron M45PEx flash memeories into the IDs table.
>>>
>>> Did you test all these flashes?
>>>
>> No, the patch was added in porting drivers related to AST2600 EVB.
>
>Please note, that all flashes which are added must be tested.
>
>>>> Fixes: dd1e9367157f900616f (ARM: dts: everest: Add phase corrections 
>>>> for
>>>> eMMC)
>>>
>>> Bogus Fixes tag. First, I cannot find this commit id, which tree is 
>>> that? Secondly, adding new flash ids don't fix anything, esp not 
>>> something related to eMMC.
>>>
>> Sorry for the confusion, I thought Fixes tag could be also used for 
>> referencing the revision base for the patch to aplly on.
>> I used dev-5.10 branch from 
>> https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
>> 
>ub.com%2Fopenbmc%2Flinux.git&amp;data=04%7C01%7Chongweiz%40ami.com%7C72a7d2569f6a4cb
>629fe08d93c775f8a%7C27e97857e15f486cb58e86c2b3040f93%7C1%7C0%7C637607305682606148%7
>CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0
>%3D%7C1000&amp;sdata=h%2BoFfg9m0udXdQgb85oq0NKEIcL1DFNha186lP0HwG8%3D&amp;reserve
>d=0 , should I use a different repository?
>
>AFAIK commits in fixes tags must be relative to Linus Torvalds' tree (or a subtree must not rebase, like 
>the networking trees, which means they will end up in Torvalds' tree).
>
>Anyway, this is not a fix and therefore there must be no Fixes: tag.
>
>-michael

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-07-01 15:19 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-29 15:08 [PATCH v1 0/1] mtd: spi-nor: Add some M45PEx ids Hongwei Zhang
2021-06-29 15:08 ` [PATCH v1 1/1] " Hongwei Zhang
2021-06-30 13:56   ` Michael Walle
2021-06-30 18:20   ` Hongwei Zhang
2021-07-01 10:02     ` Michael Walle
2021-07-01 15:18   ` Hongwei Zhang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).