* [PATCH v2] tools: bpftool: close va_list 'ap' by va_end()
@ 2021-07-06 1:11 gushengxian
0 siblings, 0 replies; only message in thread
From: gushengxian @ 2021-07-06 1:11 UTC (permalink / raw)
To: ast, daniel, andrii; +Cc: netdev, bpf, linux-kernel, gushengxian
From: gushengxian <gushengxian@yulong.com>
va_list 'ap' was opened but not closed by va_end(). It should be
closed by va_end() before return.
According to suggestion of Daniel Borkmann <daniel@iogearbox.net>.
Signed-off-by: gushengxian <gushengxian@yulong.com>
---
tools/bpf/bpftool/jit_disasm.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/bpf/bpftool/jit_disasm.c b/tools/bpf/bpftool/jit_disasm.c
index e7e7eee9f172..24734f2249d6 100644
--- a/tools/bpf/bpftool/jit_disasm.c
+++ b/tools/bpf/bpftool/jit_disasm.c
@@ -43,11 +43,13 @@ static int fprintf_json(void *out, const char *fmt, ...)
{
va_list ap;
char *s;
+ int err;
va_start(ap, fmt);
- if (vasprintf(&s, fmt, ap) < 0)
- return -1;
+ err = vasprintf(&s, fmt, ap);
va_end(ap);
+ if (err < 0)
+ return -1;
if (!oper_count) {
int i;
--
2.25.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-07-06 1:12 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-06 1:11 [PATCH v2] tools: bpftool: close va_list 'ap' by va_end() gushengxian
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).