[PATCH] ARM: dts: sun8i: h3: orangepi-plus: Fix ethernet phy-mode

[PATCH] ARM: dts: sun8i: h3: orangepi-plus: Fix ethernet phy-mode

[Salvatore Bonaccorso]

Commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay
config") sets the RX/TX delay according to the phy-mode property in the
device tree. For the Orange Pi Plus board this is "rgmii", which is the
wrong setting.

Following the example of a900cac3750b ("ARM: dts: sun7i: a20: bananapro:
Fix ethernet phy-mode") the phy-mode is changed to "rgmii-id" which gets
the Ethernet working again on this board.

Fixes: bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config")
Reported-by: "B.R. Oake" <broake@mailfence.com>
Reported-by: Vagrant Cascadian <vagrant@reproducible-builds.org>
Link: https://bugs.debian.org/988574
Signed-off-by: Salvatore Bonaccorso <carnil@debian.org>
---

v2:
 - Add a Reported-by for "B.R. Oake" <broake@mailfence.com>
---
 arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts
index 97f497854e05..d05fa679dcd3 100644
--- a/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts
+++ b/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts
@@ -85,7 +85,7 @@ &emac {
 	pinctrl-0 = <&emac_rgmii_pins>;
 	phy-supply = <&reg_gmac_3v3>;
 	phy-handle = <&ext_rgmii_phy>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 
 	status = "okay";
 };
-- 
2.32.0.rc0

Re: [PATCH] ARM: dts: sun8i: h3: orangepi-plus: Fix ethernet phy-mode

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 837 bytes --]

On Mon, May 24, 2021 at 02:21:11PM +0200, Salvatore Bonaccorso wrote:
> Commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay
> config") sets the RX/TX delay according to the phy-mode property in the
> device tree. For the Orange Pi Plus board this is "rgmii", which is the
> wrong setting.
> 
> Following the example of a900cac3750b ("ARM: dts: sun7i: a20: bananapro:
> Fix ethernet phy-mode") the phy-mode is changed to "rgmii-id" which gets
> the Ethernet working again on this board.
> 
> Fixes: bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config")
> Reported-by: "B.R. Oake" <broake@mailfence.com>
> Reported-by: Vagrant Cascadian <vagrant@reproducible-builds.org>
> Link: https://bugs.debian.org/988574
> Signed-off-by: Salvatore Bonaccorso <carnil@debian.org>

Applied, thanks!
Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH] ARM: dts: sun8i: h3: orangepi-plus: Fix ethernet phy-mode

[Salvatore Bonaccorso]

Hi Maxime,

On Mon, May 24, 2021 at 02:35:06PM +0200, Maxime Ripard wrote:
> On Mon, May 24, 2021 at 02:21:11PM +0200, Salvatore Bonaccorso wrote:
> > Commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay
> > config") sets the RX/TX delay according to the phy-mode property in the
> > device tree. For the Orange Pi Plus board this is "rgmii", which is the
> > wrong setting.
> > 
> > Following the example of a900cac3750b ("ARM: dts: sun7i: a20: bananapro:
> > Fix ethernet phy-mode") the phy-mode is changed to "rgmii-id" which gets
> > the Ethernet working again on this board.
> > 
> > Fixes: bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config")
> > Reported-by: "B.R. Oake" <broake@mailfence.com>
> > Reported-by: Vagrant Cascadian <vagrant@reproducible-builds.org>
> > Link: https://bugs.debian.org/988574
> > Signed-off-by: Salvatore Bonaccorso <carnil@debian.org>
> 
> Applied, thanks!

Did this fall trough the cracks? 

I see it in
https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git/commit/?id=b19d3479f25e8a0ff24df0b46c82e50ef0f900dd
but got not merged yet in mainline.

Thank you for your work!

Regards,
Salvatore

Re: [PATCH] ARM: dts: sun8i: h3: orangepi-plus: Fix ethernet phy-mode

[Maxime Ripard]

Hi Salvatore,

On Sat, Jul 10, 2021 at 03:09:55PM +0200, Salvatore Bonaccorso wrote:
> Hi Maxime,
> 
> On Mon, May 24, 2021 at 02:35:06PM +0200, Maxime Ripard wrote:
> > On Mon, May 24, 2021 at 02:21:11PM +0200, Salvatore Bonaccorso wrote:
> > > Commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay
> > > config") sets the RX/TX delay according to the phy-mode property in the
> > > device tree. For the Orange Pi Plus board this is "rgmii", which is the
> > > wrong setting.
> > > 
> > > Following the example of a900cac3750b ("ARM: dts: sun7i: a20: bananapro:
> > > Fix ethernet phy-mode") the phy-mode is changed to "rgmii-id" which gets
> > > the Ethernet working again on this board.
> > > 
> > > Fixes: bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config")
> > > Reported-by: "B.R. Oake" <broake@mailfence.com>
> > > Reported-by: Vagrant Cascadian <vagrant@reproducible-builds.org>
> > > Link: https://bugs.debian.org/988574
> > > Signed-off-by: Salvatore Bonaccorso <carnil@debian.org>
> > 
> > Applied, thanks!
> 
> Did this fall trough the cracks? 
> 
> I see it in
> https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git/commit/?id=b19d3479f25e8a0ff24df0b46c82e50ef0f900dd
> but got not merged yet in mainline.

I'm not really sure what happened, but I did send it as part of a fix PR
here:

https://lore.kernel.org/linux-arm-kernel/ad7ba352-315c-4201-b922-4bf914a00d98.lettre@localhost/

But it was sent as part of one of the arm-soc PR for 5.14:

https://lore.kernel.org/linux-arm-kernel/20210709234054.10288-1-olof@lixom.net/

I'm not sure if it didn't get applied to the right branch, but it
doesn't seem to be part of the proper PR either.

Anyway, this is on its way to Linus, will be part of 5.14 and picked up
by the stable tree at some point in a 5.13.* kernel

Maxime