* [PATCH] fs:xfs: cleanup __FUNCTION__ usage
@ 2021-07-11 8:51 Dwaipayan Ray
2021-07-11 22:46 ` Dave Chinner
2021-07-14 23:27 ` Darrick J. Wong
0 siblings, 2 replies; 3+ messages in thread
From: Dwaipayan Ray @ 2021-07-11 8:51 UTC (permalink / raw)
To: djwong; +Cc: linux-xfs, linux-kernel, lukas.bulwahn, Dwaipayan Ray
__FUNCTION__ exists only for backwards compatibility reasons
with old gcc versions. Replace it with __func__.
Signed-off-by: Dwaipayan Ray <dwaipayanray1@gmail.com>
---
fs/xfs/xfs_icreate_item.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/xfs/xfs_icreate_item.c b/fs/xfs/xfs_icreate_item.c
index 9b3994b9c716..017904a34c02 100644
--- a/fs/xfs/xfs_icreate_item.c
+++ b/fs/xfs/xfs_icreate_item.c
@@ -201,7 +201,7 @@ xlog_recover_icreate_commit_pass2(
if (length != igeo->ialloc_blks &&
length != igeo->ialloc_min_blks) {
xfs_warn(log->l_mp,
- "%s: unsupported chunk length", __FUNCTION__);
+ "%s: unsupported chunk length", __func__);
return -EINVAL;
}
@@ -209,7 +209,7 @@ xlog_recover_icreate_commit_pass2(
if ((count >> mp->m_sb.sb_inopblog) != length) {
xfs_warn(log->l_mp,
"%s: inconsistent inode count and chunk length",
- __FUNCTION__);
+ __func__);
return -EINVAL;
}
--
2.28.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fs:xfs: cleanup __FUNCTION__ usage
2021-07-11 8:51 [PATCH] fs:xfs: cleanup __FUNCTION__ usage Dwaipayan Ray
@ 2021-07-11 22:46 ` Dave Chinner
2021-07-14 23:27 ` Darrick J. Wong
1 sibling, 0 replies; 3+ messages in thread
From: Dave Chinner @ 2021-07-11 22:46 UTC (permalink / raw)
To: Dwaipayan Ray; +Cc: djwong, linux-xfs, linux-kernel, lukas.bulwahn
On Sun, Jul 11, 2021 at 02:21:53PM +0530, Dwaipayan Ray wrote:
> __FUNCTION__ exists only for backwards compatibility reasons
> with old gcc versions. Replace it with __func__.
>
> Signed-off-by: Dwaipayan Ray <dwaipayanray1@gmail.com>
> ---
> fs/xfs/xfs_icreate_item.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/xfs/xfs_icreate_item.c b/fs/xfs/xfs_icreate_item.c
> index 9b3994b9c716..017904a34c02 100644
> --- a/fs/xfs/xfs_icreate_item.c
> +++ b/fs/xfs/xfs_icreate_item.c
> @@ -201,7 +201,7 @@ xlog_recover_icreate_commit_pass2(
> if (length != igeo->ialloc_blks &&
> length != igeo->ialloc_min_blks) {
> xfs_warn(log->l_mp,
> - "%s: unsupported chunk length", __FUNCTION__);
> + "%s: unsupported chunk length", __func__);
> return -EINVAL;
> }
>
> @@ -209,7 +209,7 @@ xlog_recover_icreate_commit_pass2(
> if ((count >> mp->m_sb.sb_inopblog) != length) {
> xfs_warn(log->l_mp,
> "%s: inconsistent inode count and chunk length",
> - __FUNCTION__);
> + __func__);
> return -EINVAL;
> }
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
For future reference, the subject only needs "xfs:", you can drop
the "fs:" prefix from it.
-Dave.
--
Dave Chinner
david@fromorbit.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fs:xfs: cleanup __FUNCTION__ usage
2021-07-11 8:51 [PATCH] fs:xfs: cleanup __FUNCTION__ usage Dwaipayan Ray
2021-07-11 22:46 ` Dave Chinner
@ 2021-07-14 23:27 ` Darrick J. Wong
1 sibling, 0 replies; 3+ messages in thread
From: Darrick J. Wong @ 2021-07-14 23:27 UTC (permalink / raw)
To: Dwaipayan Ray; +Cc: linux-xfs, linux-kernel, lukas.bulwahn
On Sun, Jul 11, 2021 at 02:21:53PM +0530, Dwaipayan Ray wrote:
> __FUNCTION__ exists only for backwards compatibility reasons
> with old gcc versions. Replace it with __func__.
>
> Signed-off-by: Dwaipayan Ray <dwaipayanray1@gmail.com>
LGTM
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> fs/xfs/xfs_icreate_item.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/xfs/xfs_icreate_item.c b/fs/xfs/xfs_icreate_item.c
> index 9b3994b9c716..017904a34c02 100644
> --- a/fs/xfs/xfs_icreate_item.c
> +++ b/fs/xfs/xfs_icreate_item.c
> @@ -201,7 +201,7 @@ xlog_recover_icreate_commit_pass2(
> if (length != igeo->ialloc_blks &&
> length != igeo->ialloc_min_blks) {
> xfs_warn(log->l_mp,
> - "%s: unsupported chunk length", __FUNCTION__);
> + "%s: unsupported chunk length", __func__);
> return -EINVAL;
> }
>
> @@ -209,7 +209,7 @@ xlog_recover_icreate_commit_pass2(
> if ((count >> mp->m_sb.sb_inopblog) != length) {
> xfs_warn(log->l_mp,
> "%s: inconsistent inode count and chunk length",
> - __FUNCTION__);
> + __func__);
> return -EINVAL;
> }
>
> --
> 2.28.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-14 23:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-11 8:51 [PATCH] fs:xfs: cleanup __FUNCTION__ usage Dwaipayan Ray
2021-07-11 22:46 ` Dave Chinner
2021-07-14 23:27 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).