* [PATCH] speakup: use C99 syntax for array initializers
@ 2021-07-15 16:31 Colin King
2021-07-16 8:35 ` Samuel Thibault
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2021-07-15 16:31 UTC (permalink / raw)
To: array, initializers, Chris Brannon, Kirk Reiser, Samuel Thibault,
Greg Kroah-Hartman, speakup
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The older obsolete array initializer syntax is currently being used
for some of the array elements. Fix this by using the preferred C99
array initializers syntax.
Fixes: 5b5140bf5182 ("speakup: Separate out translations for bright colors names")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/accessibility/speakup/i18n.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/accessibility/speakup/i18n.c b/drivers/accessibility/speakup/i18n.c
index bc7b47d1876f..d62079b1661f 100644
--- a/drivers/accessibility/speakup/i18n.c
+++ b/drivers/accessibility/speakup/i18n.c
@@ -90,13 +90,13 @@ static char *speakup_default_msgs[MSG_LAST_INDEX] = {
[MSG_COLOR_YELLOW] = "yellow",
[MSG_COLOR_WHITE] = "white",
[MSG_COLOR_GREY] = "grey",
- [MSG_COLOR_BRIGHTBLUE] "bright blue",
- [MSG_COLOR_BRIGHTGREEN] "bright green",
- [MSG_COLOR_BRIGHTCYAN] "bright cyan",
- [MSG_COLOR_BRIGHTRED] "bright red",
- [MSG_COLOR_BRIGHTMAGENTA] "bright magenta",
- [MSG_COLOR_BRIGHTYELLOW] "bright yellow",
- [MSG_COLOR_BRIGHTWHITE] "bright white",
+ [MSG_COLOR_BRIGHTBLUE] = "bright blue",
+ [MSG_COLOR_BRIGHTGREEN] = "bright green",
+ [MSG_COLOR_BRIGHTCYAN] = "bright cyan",
+ [MSG_COLOR_BRIGHTRED] = "bright red",
+ [MSG_COLOR_BRIGHTMAGENTA] = "bright magenta",
+ [MSG_COLOR_BRIGHTYELLOW] = "bright yellow",
+ [MSG_COLOR_BRIGHTWHITE] = "bright white",
/* Names of key states. */
[MSG_STATE_DOUBLE] = "double",
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] speakup: use C99 syntax for array initializers
2021-07-15 16:31 [PATCH] speakup: use C99 syntax for array initializers Colin King
@ 2021-07-16 8:35 ` Samuel Thibault
0 siblings, 0 replies; 2+ messages in thread
From: Samuel Thibault @ 2021-07-16 8:35 UTC (permalink / raw)
To: Colin King
Cc: array, initializers, Chris Brannon, Kirk Reiser,
Greg Kroah-Hartman, speakup, kernel-janitors, linux-kernel
Colin King, le jeu. 15 juil. 2021 17:31:22 +0100, a ecrit:
> From: Colin Ian King <colin.king@canonical.com>
>
> The older obsolete array initializer syntax is currently being used
> for some of the array elements. Fix this by using the preferred C99
> array initializers syntax.
>
> Fixes: 5b5140bf5182 ("speakup: Separate out translations for bright colors names")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
> drivers/accessibility/speakup/i18n.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/accessibility/speakup/i18n.c b/drivers/accessibility/speakup/i18n.c
> index bc7b47d1876f..d62079b1661f 100644
> --- a/drivers/accessibility/speakup/i18n.c
> +++ b/drivers/accessibility/speakup/i18n.c
> @@ -90,13 +90,13 @@ static char *speakup_default_msgs[MSG_LAST_INDEX] = {
> [MSG_COLOR_YELLOW] = "yellow",
> [MSG_COLOR_WHITE] = "white",
> [MSG_COLOR_GREY] = "grey",
> - [MSG_COLOR_BRIGHTBLUE] "bright blue",
> - [MSG_COLOR_BRIGHTGREEN] "bright green",
> - [MSG_COLOR_BRIGHTCYAN] "bright cyan",
> - [MSG_COLOR_BRIGHTRED] "bright red",
> - [MSG_COLOR_BRIGHTMAGENTA] "bright magenta",
> - [MSG_COLOR_BRIGHTYELLOW] "bright yellow",
> - [MSG_COLOR_BRIGHTWHITE] "bright white",
> + [MSG_COLOR_BRIGHTBLUE] = "bright blue",
> + [MSG_COLOR_BRIGHTGREEN] = "bright green",
> + [MSG_COLOR_BRIGHTCYAN] = "bright cyan",
> + [MSG_COLOR_BRIGHTRED] = "bright red",
> + [MSG_COLOR_BRIGHTMAGENTA] = "bright magenta",
> + [MSG_COLOR_BRIGHTYELLOW] = "bright yellow",
> + [MSG_COLOR_BRIGHTWHITE] = "bright white",
>
> /* Names of key states. */
> [MSG_STATE_DOUBLE] = "double",
> --
> 2.31.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-16 8:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-15 16:31 [PATCH] speakup: use C99 syntax for array initializers Colin King
2021-07-16 8:35 ` Samuel Thibault
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).