From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Gene Chen <gene.chen.richtek@gmail.com>
Cc: "Vaittinen, Matti" <matti.vaittinen@fi.rohmeurope.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
devicetree <devicetree@vger.kernel.org>,
inux-pm@vger.kernel.org,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Randy Dunlap <rdunlap@infradead.org>,
Gene Chen <gene_chen@richtek.com>,
Wilma.Wu@mediatek.com, shufan_lee@richtek.com,
ChiYuan Huang <cy_huang@richtek.com>,
benjamin.chao@mediatek.com
Subject: Re: [PATCH v5 3/3] power: supply: mt6360_charger: add MT6360 charger support
Date: Fri, 16 Jul 2021 15:48:43 +0200 [thread overview]
Message-ID: <20210716134843.w7cl7ekkm3dm6pu5@earth.universe> (raw)
In-Reply-To: <CAE+NS36WuNkQYn8_UvsZaU5Equ9YH+Ya=c_j3cLNhuFnHT_J-g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 634 bytes --]
Hi,
On Mon, May 31, 2021 at 11:39:50AM +0800, Gene Chen wrote:
> > > +static int mt6360_charger_remove(struct platform_device *pdev)
> > > +{
> > > + struct mt6360_chg_info *mci = platform_get_drvdata(pdev);
> > > +
> > > + cancel_work_sync(&mci->chrdet_work);
> > > +
> > > + return 0;
> > > +}
> >
> > Just as a note, devm_work_autocancel() should hopefully be included at
> > next cycle. Then you might be able to drop the .remove().
>
> ACK, I will replace it, thanks.
> > FWIW:
> > Reviewed-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Did I miss a newer revision?
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-07-16 13:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 8:12 [PATCH v5 0/3] power: supply: mt6360_charger: add MT6360 charger support Gene Chen
2021-05-28 8:12 ` [PATCH v5 1/3] lib: add linear range get selector within Gene Chen
2021-05-28 9:02 ` Vaittinen, Matti
2021-05-28 8:12 ` [PATCH v5 2/3] dt-bindings: power: Add bindings document for Charger support on MT6360 PMIC Gene Chen
2021-05-28 8:13 ` [PATCH v5 3/3] power: supply: mt6360_charger: add MT6360 charger support Gene Chen
2021-05-28 9:47 ` Matti Vaittinen
2021-05-31 3:39 ` Gene Chen
2021-07-16 13:48 ` Sebastian Reichel [this message]
2021-05-28 16:22 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210716134843.w7cl7ekkm3dm6pu5@earth.universe \
--to=sebastian.reichel@collabora.com \
--cc=Wilma.Wu@mediatek.com \
--cc=benjamin.chao@mediatek.com \
--cc=broonie@kernel.org \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=gene.chen.richtek@gmail.com \
--cc=gene_chen@richtek.com \
--cc=inux-pm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=shufan_lee@richtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).