* [PATCH] net: marvell: clean up trigraph warning on ??! string
@ 2021-07-20 13:03 Colin King
2021-07-20 14:30 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2021-07-20 13:03 UTC (permalink / raw)
To: Thomas Petazzoni, David S . Miller, Jakub Kicinski,
Nathan Chancellor, Nick Desaulniers, netdev, clang-built-linux
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The character sequence ??! is a trigraph and causes the following
clang warning:
drivers/net/ethernet/marvell/mvneta.c:2604:39: warning: trigraph ignored [-Wtrigraphs]
Clean this by replacing it with single ?.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/marvell/mvneta.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
index 76a7777c746d..fc4dbcc58f5f 100644
--- a/drivers/net/ethernet/marvell/mvneta.c
+++ b/drivers/net/ethernet/marvell/mvneta.c
@@ -2666,7 +2666,7 @@ static int mvneta_tx_tso(struct sk_buff *skb, struct net_device *dev,
return 0;
if (skb_headlen(skb) < (skb_transport_offset(skb) + tcp_hdrlen(skb))) {
- pr_info("*** Is this even possible???!?!?\n");
+ pr_info("*** Is this even possible?\n");
return 0;
}
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: marvell: clean up trigraph warning on ??! string
2021-07-20 13:03 [PATCH] net: marvell: clean up trigraph warning on ??! string Colin King
@ 2021-07-20 14:30 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-07-20 14:30 UTC (permalink / raw)
To: Colin King
Cc: thomas.petazzoni, davem, kuba, nathan, ndesaulniers, netdev,
clang-built-linux, kernel-janitors, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Tue, 20 Jul 2021 14:03:11 +0100 you wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The character sequence ??! is a trigraph and causes the following
> clang warning:
>
> drivers/net/ethernet/marvell/mvneta.c:2604:39: warning: trigraph ignored [-Wtrigraphs]
>
> [...]
Here is the summary with links:
- net: marvell: clean up trigraph warning on ??! string
https://git.kernel.org/netdev/net-next/c/fa660684e531
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-20 14:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-20 13:03 [PATCH] net: marvell: clean up trigraph warning on ??! string Colin King
2021-07-20 14:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).