[ambarus:spi-nor/next-id-collisions-v2 20/27] drivers/mtd/spi-nor/core.c:3126:6: sparse: sparse: symbol 'spi_nor_set_mtd_info' was not declared. Should it be static?

[ambarus:spi-nor/next-id-collisions-v2 20/27] drivers/mtd/spi-nor/core.c:3126:6: sparse: sparse: symbol 'spi_nor_set_mtd_info' was not declared. Should it be static?

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1363 bytes --]

tree:   https://github.com/ambarus/linux-0day spi-nor/next-id-collisions-v2
head:   b4bf25c4aeb0e9be35b688a2eaa4e9b902dff4f4
commit: 1db04a902d5710228c3172ac7113a78857a3695f [20/27] mtd: spi-nor: Introduce spi_nor_set_mtd_info()
config: x86_64-randconfig-s021-20210723 (attached as .config)
compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-341-g8af24329-dirty
        # https://github.com/ambarus/linux-0day/commit/1db04a902d5710228c3172ac7113a78857a3695f
        git remote add ambarus https://github.com/ambarus/linux-0day
        git fetch --no-tags ambarus spi-nor/next-id-collisions-v2
        git checkout 1db04a902d5710228c3172ac7113a78857a3695f
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/mtd/spi-nor/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
>> drivers/mtd/spi-nor/core.c:3126:6: sparse: sparse: symbol 'spi_nor_set_mtd_info' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29587 bytes --]

[RFC PATCH ambarus] mtd: spi-nor: spi_nor_set_mtd_info() can be static

[kernel test robot]

drivers/mtd/spi-nor/core.c:3126:6: warning: symbol 'spi_nor_set_mtd_info' was not declared. Should it be static?

Fixes: 1db04a902d57 ("mtd: spi-nor: Introduce spi_nor_set_mtd_info()")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
index 3a71d1358a38f..f43a6b3860545 100644
--- a/drivers/mtd/spi-nor/core.c
+++ b/drivers/mtd/spi-nor/core.c
@@ -3123,7 +3123,7 @@ static const struct flash_info *spi_nor_get_flash_info(struct spi_nor *nor,
 	return info;
 }
 
-void spi_nor_set_mtd_info(struct spi_nor *nor)
+static void spi_nor_set_mtd_info(struct spi_nor *nor)
 {
 	struct mtd_info *mtd = &nor->mtd;
 	struct device *dev = nor->dev;