linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [ext3:generic_block_fiemap_removal 3/4] file.c:undefined reference to `iomap_fiemap'
@ 2021-07-27  2:04 kernel test robot
  2021-07-27  6:58 ` Christoph Hellwig
  0 siblings, 1 reply; 6+ messages in thread
From: kernel test robot @ 2021-07-27  2:04 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: kbuild-all, linux-kernel, Jan Kara

[-- Attachment #1: Type: text/plain, Size: 1572 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git generic_block_fiemap_removal
head:   8f04e4d9e612244a7fea6e3db4c5f117784212e3
commit: 9432c8ae9f99993c886a7a5b4b99b8e9af491183 [3/4] hpfs: use iomap_fiemap to implement ->fiemap
config: riscv-randconfig-r035-20210726 (attached as .config)
compiler: riscv64-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git/commit/?id=9432c8ae9f99993c886a7a5b4b99b8e9af491183
        git remote add ext3 https://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git
        git fetch --no-tags ext3 generic_block_fiemap_removal
        git checkout 9432c8ae9f99993c886a7a5b4b99b8e9af491183
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross O=build_dir ARCH=riscv SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   riscv64-linux-ld: fs/ext2/inode.o: in function `.L468':
   inode.c:(.text+0x2624): undefined reference to `iomap_fiemap'
   riscv64-linux-ld: fs/hpfs/file.o: in function `.L0 ':
>> file.c:(.text+0x2a4): undefined reference to `iomap_fiemap'

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34263 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [ext3:generic_block_fiemap_removal 3/4] file.c:undefined reference to `iomap_fiemap'
  2021-07-27  2:04 [ext3:generic_block_fiemap_removal 3/4] file.c:undefined reference to `iomap_fiemap' kernel test robot
@ 2021-07-27  6:58 ` Christoph Hellwig
  2021-07-27  8:55   ` Jan Kara
  0 siblings, 1 reply; 6+ messages in thread
From: Christoph Hellwig @ 2021-07-27  6:58 UTC (permalink / raw)
  To: kernel test robot; +Cc: Christoph Hellwig, kbuild-all, linux-kernel, Jan Kara

Oops, hpfs now needs to select FS_IOMAP:

diff --git a/fs/hpfs/Kconfig b/fs/hpfs/Kconfig
index 2b36dc6f0a10..ec975f466877 100644
--- a/fs/hpfs/Kconfig
+++ b/fs/hpfs/Kconfig
@@ -2,6 +2,7 @@
 config HPFS_FS
 	tristate "OS/2 HPFS file system support"
 	depends on BLOCK
+	select FS_IOMAP
 	help
 	  OS/2 is IBM's operating system for PC's, the same as Warp, and HPFS
 	  is the file system used for organizing files on OS/2 hard disk

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [ext3:generic_block_fiemap_removal 3/4] file.c:undefined reference to `iomap_fiemap'
  2021-07-27  6:58 ` Christoph Hellwig
@ 2021-07-27  8:55   ` Jan Kara
  2021-07-27  8:57     ` Christoph Hellwig
  0 siblings, 1 reply; 6+ messages in thread
From: Jan Kara @ 2021-07-27  8:55 UTC (permalink / raw)
  To: Christoph Hellwig
  Cc: kernel test robot, Christoph Hellwig, kbuild-all, linux-kernel, Jan Kara

On Tue 27-07-21 07:58:33, Christoph Hellwig wrote:
> Oops, hpfs now needs to select FS_IOMAP:

And I assume ext2 as well, right? So far ext2 needed iomap only for DAX
which selects FS_IOMAP itself. But now ext2 needs iomap also without DAX...

								Honza

> diff --git a/fs/hpfs/Kconfig b/fs/hpfs/Kconfig
> index 2b36dc6f0a10..ec975f466877 100644
> --- a/fs/hpfs/Kconfig
> +++ b/fs/hpfs/Kconfig
> @@ -2,6 +2,7 @@
>  config HPFS_FS
>  	tristate "OS/2 HPFS file system support"
>  	depends on BLOCK
> +	select FS_IOMAP
>  	help
>  	  OS/2 is IBM's operating system for PC's, the same as Warp, and HPFS
>  	  is the file system used for organizing files on OS/2 hard disk
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [ext3:generic_block_fiemap_removal 3/4] file.c:undefined reference to `iomap_fiemap'
  2021-07-27  8:55   ` Jan Kara
@ 2021-07-27  8:57     ` Christoph Hellwig
  2021-07-27  9:07       ` Jan Kara
  0 siblings, 1 reply; 6+ messages in thread
From: Christoph Hellwig @ 2021-07-27  8:57 UTC (permalink / raw)
  To: Jan Kara
  Cc: Christoph Hellwig, kernel test robot, Christoph Hellwig,
	kbuild-all, linux-kernel

On Tue, Jul 27, 2021 at 10:55:51AM +0200, Jan Kara wrote:
> On Tue 27-07-21 07:58:33, Christoph Hellwig wrote:
> > Oops, hpfs now needs to select FS_IOMAP:
> 
> And I assume ext2 as well, right? So far ext2 needed iomap only for DAX
> which selects FS_IOMAP itself. But now ext2 needs iomap also without DAX...

Indeed.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [ext3:generic_block_fiemap_removal 3/4] file.c:undefined reference to `iomap_fiemap'
  2021-07-27  8:57     ` Christoph Hellwig
@ 2021-07-27  9:07       ` Jan Kara
  2021-07-27 18:32         ` Naresh Kamboju
  0 siblings, 1 reply; 6+ messages in thread
From: Jan Kara @ 2021-07-27  9:07 UTC (permalink / raw)
  To: Christoph Hellwig
  Cc: Jan Kara, Christoph Hellwig, kernel test robot, kbuild-all, linux-kernel

On Tue 27-07-21 10:57:42, Christoph Hellwig wrote:
> On Tue, Jul 27, 2021 at 10:55:51AM +0200, Jan Kara wrote:
> > On Tue 27-07-21 07:58:33, Christoph Hellwig wrote:
> > > Oops, hpfs now needs to select FS_IOMAP:
> > 
> > And I assume ext2 as well, right? So far ext2 needed iomap only for DAX
> > which selects FS_IOMAP itself. But now ext2 needs iomap also without DAX...
> 
> Indeed.

I've ammended the two commits and pushed the result out.
								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [ext3:generic_block_fiemap_removal 3/4] file.c:undefined reference to `iomap_fiemap'
  2021-07-27  9:07       ` Jan Kara
@ 2021-07-27 18:32         ` Naresh Kamboju
  0 siblings, 0 replies; 6+ messages in thread
From: Naresh Kamboju @ 2021-07-27 18:32 UTC (permalink / raw)
  To: Jan Kara
  Cc: Christoph Hellwig, Christoph Hellwig, kernel test robot,
	kbuild-all, open list, Linux-Next Mailing List, Stephen Rothwell

On Tue, 27 Jul 2021 at 14:37, Jan Kara <jack@suse.cz> wrote:
>
> On Tue 27-07-21 10:57:42, Christoph Hellwig wrote:
> > On Tue, Jul 27, 2021 at 10:55:51AM +0200, Jan Kara wrote:
> > > On Tue 27-07-21 07:58:33, Christoph Hellwig wrote:
> > > > Oops, hpfs now needs to select FS_IOMAP:
> > >
> > > And I assume ext2 as well, right? So far ext2 needed iomap only for DAX
> > > which selects FS_IOMAP itself. But now ext2 needs iomap also without DAX...
> >
> > Indeed.
>
> I've ammended the two commits and pushed the result out.

Thank you !

FYI,
The reported build failures noticed today's linux next 20210727 tag on
 - arc (defconfig) with gcc-9
 - sparc (defconfig) with gcc-10

arc-elf32-ld: fs/ext2/inode.o: in function `ext2_fiemap':
inode.c:(.text+0x1c24): undefined reference to `iomap_fiemap'
arc-elf32-ld: inode.c:(.text+0x1c24): undefined reference to `iomap_fiemap'

- Naresh

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-07-27 18:32 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-27  2:04 [ext3:generic_block_fiemap_removal 3/4] file.c:undefined reference to `iomap_fiemap' kernel test robot
2021-07-27  6:58 ` Christoph Hellwig
2021-07-27  8:55   ` Jan Kara
2021-07-27  8:57     ` Christoph Hellwig
2021-07-27  9:07       ` Jan Kara
2021-07-27 18:32         ` Naresh Kamboju

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).