* [PATCH -next] filesystems/locking: fix Malformed table warning
@ 2021-07-27 23:22 Randy Dunlap
2021-07-28 0:04 ` Darrick J. Wong
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2021-07-27 23:22 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Darrick J . Wong, Christoph Hellwig, Jan Kara,
linux-fsdevel
Update the bottom border to be the same as the top border.
Documentation/filesystems/locking.rst:274: WARNING: Malformed table.
Bottom/header table border does not match top border.
Fixes: 730633f0b7f9 ("mm: Protect operations adding pages to page cache with invalidate_lock")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Darrick J. Wong <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org
---
Documentation/filesystems/locking.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linext-20210727.orig/Documentation/filesystems/locking.rst
+++ linext-20210727/Documentation/filesystems/locking.rst
@@ -295,7 +295,7 @@ is_partially_uptodate: yes
error_remove_page: yes
swap_activate: no
swap_deactivate: no
-====================== ======================== =========
+====================== ======================== ========= ===============
->write_begin(), ->write_end() and ->readpage() may be called from
the request handler (/dev/loop).
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] filesystems/locking: fix Malformed table warning
2021-07-27 23:22 [PATCH -next] filesystems/locking: fix Malformed table warning Randy Dunlap
@ 2021-07-28 0:04 ` Darrick J. Wong
2021-07-28 13:20 ` Jan Kara
0 siblings, 1 reply; 3+ messages in thread
From: Darrick J. Wong @ 2021-07-28 0:04 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-kernel, Christoph Hellwig, Jan Kara, linux-fsdevel
On Tue, Jul 27, 2021 at 04:22:12PM -0700, Randy Dunlap wrote:
> Update the bottom border to be the same as the top border.
>
> Documentation/filesystems/locking.rst:274: WARNING: Malformed table.
> Bottom/header table border does not match top border.
>
> Fixes: 730633f0b7f9 ("mm: Protect operations adding pages to page cache with invalidate_lock")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Darrick J. Wong <djwong@kernel.org>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Jan Kara <jack@suse.cz>
> Cc: linux-fsdevel@vger.kernel.org
Looks ugly but probably correct
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> Documentation/filesystems/locking.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linext-20210727.orig/Documentation/filesystems/locking.rst
> +++ linext-20210727/Documentation/filesystems/locking.rst
> @@ -295,7 +295,7 @@ is_partially_uptodate: yes
> error_remove_page: yes
> swap_activate: no
> swap_deactivate: no
> -====================== ======================== =========
> +====================== ======================== ========= ===============
>
> ->write_begin(), ->write_end() and ->readpage() may be called from
> the request handler (/dev/loop).
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] filesystems/locking: fix Malformed table warning
2021-07-28 0:04 ` Darrick J. Wong
@ 2021-07-28 13:20 ` Jan Kara
0 siblings, 0 replies; 3+ messages in thread
From: Jan Kara @ 2021-07-28 13:20 UTC (permalink / raw)
To: Darrick J. Wong
Cc: Randy Dunlap, linux-kernel, Christoph Hellwig, Jan Kara, linux-fsdevel
On Tue 27-07-21 17:04:09, Darrick J. Wong wrote:
> On Tue, Jul 27, 2021 at 04:22:12PM -0700, Randy Dunlap wrote:
> > Update the bottom border to be the same as the top border.
> >
> > Documentation/filesystems/locking.rst:274: WARNING: Malformed table.
> > Bottom/header table border does not match top border.
> >
> > Fixes: 730633f0b7f9 ("mm: Protect operations adding pages to page cache with invalidate_lock")
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > Cc: Darrick J. Wong <djwong@kernel.org>
> > Cc: Christoph Hellwig <hch@lst.de>
> > Cc: Jan Kara <jack@suse.cz>
> > Cc: linux-fsdevel@vger.kernel.org
>
> Looks ugly but probably correct
> Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Thanks for the fix and for review! I've added the patch to my branch with
hole punch fixes.
Honza
> > ---
> > Documentation/filesystems/locking.rst | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- linext-20210727.orig/Documentation/filesystems/locking.rst
> > +++ linext-20210727/Documentation/filesystems/locking.rst
> > @@ -295,7 +295,7 @@ is_partially_uptodate: yes
> > error_remove_page: yes
> > swap_activate: no
> > swap_deactivate: no
> > -====================== ======================== =========
> > +====================== ======================== ========= ===============
> >
> > ->write_begin(), ->write_end() and ->readpage() may be called from
> > the request handler (/dev/loop).
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-28 13:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-27 23:22 [PATCH -next] filesystems/locking: fix Malformed table warning Randy Dunlap
2021-07-28 0:04 ` Darrick J. Wong
2021-07-28 13:20 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).