From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Daniel Wagner <wagi@monom.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
linux-rt-users@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Peter Zijlstra <peterz@infradead.org>,
Jens Axboe <axboe@kernel.dk>
Subject: Re: [ANNOUNCE] v5.14-rc4-rt4
Date: Wed, 4 Aug 2021 13:00:57 +0200 [thread overview]
Message-ID: <20210804110057.chsvt7l5xpw7bo5r@linutronix.de> (raw)
In-Reply-To: <20210804104803.4nwxi74sa2vwiujd@linutronix.de>
On 2021-08-04 12:48:05 [+0200], To Daniel Wagner wrote:
> On 2021-08-04 12:43:42 [+0200], To Daniel Wagner wrote:
> > Odd. Do you have a config for that, please?
>
> No need.
> | [ 90.202543] BUG: sleeping function called from invalid context at kernel/locking/spinlock_rt.c:35
> | [ 90.202549] in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 2047, name: iou-wrk-2041
> | [ 90.202555] CPU: 5 PID: 2047 Comm: iou-wrk-2041 Tainted: G W 5.14.0-rc4-rt4+ #89
> | [ 90.202561] Call Trace:
…
> | [ 90.202588] rt_spin_lock+0x19/0x70
> | [ 90.202593] ___slab_alloc+0xcb/0x7d0
…
> | [ 90.202618] kmem_cache_alloc_trace+0x79/0x1f0
> | [ 90.202621] io_wqe_dec_running.isra.0+0x98/0xe0
> | [ 90.202625] io_wq_worker_sleeping+0x37/0x50
> | [ 90.202628] schedule+0x30/0xd0
>
> le look.
So this is due to commit
685fe7feedb96 ("io-wq: eliminate the need for a manager thread")
introduced in the v5.13-rc1 merge window. The call chain is
schedule()
sched_submit_work()
preempt_disable();
io_wq_worker_sleeping()
raw_spin_lock_irq(&worker->wqe->lock);
io_wqe_dec_running(worker);
io_queue_worker_create()
kmalloc(sizeof(*cwd), GFP_ATOMIC);
The lock wqe::lock has been turned into a raw_spinlock_t in commit
95da84659226d ("io_wq: Make io_wqe::lock a raw_spinlock_t")
after a careful analysis of the code at that time. This commit breaks
things. Is this really needed?
> > > Thanks,
> > > Daniel
Sebastian
next prev parent reply other threads:[~2021-08-04 11:01 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-02 16:27 [ANNOUNCE] v5.14-rc4-rt4 Sebastian Andrzej Siewior
2021-08-04 8:24 ` Daniel Wagner
2021-08-04 10:43 ` Sebastian Andrzej Siewior
2021-08-04 10:48 ` Sebastian Andrzej Siewior
2021-08-04 11:00 ` Sebastian Andrzej Siewior [this message]
2021-08-04 13:17 ` Peter Zijlstra
2021-08-04 13:32 ` Jens Axboe
2021-08-04 14:23 ` Jens Axboe
2021-08-04 15:33 ` Sebastian Andrzej Siewior
2021-08-04 15:39 ` Jens Axboe
2021-08-04 15:47 ` Sebastian Andrzej Siewior
2021-08-04 15:49 ` Jens Axboe
2021-08-04 15:57 ` Sebastian Andrzej Siewior
2021-08-04 16:05 ` Jens Axboe
2021-08-04 16:20 ` Sebastian Andrzej Siewior
2021-08-04 16:20 ` Jens Axboe
2021-08-04 16:20 ` Steven Rostedt
2021-08-04 16:22 ` Jens Axboe
2021-08-04 16:47 ` Sebastian Andrzej Siewior
2021-08-04 16:57 ` Jens Axboe
2021-08-04 17:02 ` Sebastian Andrzej Siewior
2021-08-10 7:40 ` Sebastian Andrzej Siewior
2021-08-10 11:22 ` [PATCH] io-wq: remove GFP_ATOMIC allocation off schedule out path kernel test robot
2021-08-10 15:22 ` kernel test robot
2021-08-04 16:17 ` [ANNOUNCE] v5.14-rc4-rt4 Steven Rostedt
2021-08-04 16:22 ` Sebastian Andrzej Siewior
2021-08-04 16:25 ` Steven Rostedt
2021-08-04 16:31 ` Sebastian Andrzej Siewior
2021-08-04 16:47 ` Steven Rostedt
2021-08-04 16:57 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210804110057.chsvt7l5xpw7bo5r@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=wagi@monom.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).