From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Jens Axboe <axboe@kernel.dk>,
Peter Zijlstra <peterz@infradead.org>,
Daniel Wagner <wagi@monom.org>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
linux-rt-users@vger.kernel.org
Subject: Re: [ANNOUNCE] v5.14-rc4-rt4
Date: Wed, 4 Aug 2021 18:22:31 +0200 [thread overview]
Message-ID: <20210804162231.rfj5i736lqc4nsio@linutronix.de> (raw)
In-Reply-To: <20210804121704.1587c41b@oasis.local.home>
On 2021-08-04 12:17:04 [-0400], Steven Rostedt wrote:
> Perhaps in this situation, we could open code it to:
>
> if (stall_hash != -1U) {
> raw_spin_unlock(&wqe->lock);
>
> /* On RT the spin_lock_irq() does not disable interrupts */
> if (IS_ENABLED(CONFIG_PREEMPT_RT))
> local_irq_enable();
no preemption happens here with NEED_RESCHED set.
> io_wait_on_hash(wqe, stall_hash);
>
> if (IS_ENABLED(CONFIG_PREEMPT_RT))
> local_irq_disable();
> raw_spin_lock(&wqe->lock);
> }
>
> Note, I haven't looked at the rest of the code to know the ripple
> effect of this, but I'm just suggesting the idea.
>
Sebastian
next prev parent reply other threads:[~2021-08-04 16:22 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-02 16:27 [ANNOUNCE] v5.14-rc4-rt4 Sebastian Andrzej Siewior
2021-08-04 8:24 ` Daniel Wagner
2021-08-04 10:43 ` Sebastian Andrzej Siewior
2021-08-04 10:48 ` Sebastian Andrzej Siewior
2021-08-04 11:00 ` Sebastian Andrzej Siewior
2021-08-04 13:17 ` Peter Zijlstra
2021-08-04 13:32 ` Jens Axboe
2021-08-04 14:23 ` Jens Axboe
2021-08-04 15:33 ` Sebastian Andrzej Siewior
2021-08-04 15:39 ` Jens Axboe
2021-08-04 15:47 ` Sebastian Andrzej Siewior
2021-08-04 15:49 ` Jens Axboe
2021-08-04 15:57 ` Sebastian Andrzej Siewior
2021-08-04 16:05 ` Jens Axboe
2021-08-04 16:20 ` Sebastian Andrzej Siewior
2021-08-04 16:20 ` Jens Axboe
2021-08-04 16:20 ` Steven Rostedt
2021-08-04 16:22 ` Jens Axboe
2021-08-04 16:47 ` Sebastian Andrzej Siewior
2021-08-04 16:57 ` Jens Axboe
2021-08-04 17:02 ` Sebastian Andrzej Siewior
2021-08-10 7:40 ` Sebastian Andrzej Siewior
2021-08-10 11:22 ` [PATCH] io-wq: remove GFP_ATOMIC allocation off schedule out path kernel test robot
2021-08-10 15:22 ` kernel test robot
2021-08-04 16:17 ` [ANNOUNCE] v5.14-rc4-rt4 Steven Rostedt
2021-08-04 16:22 ` Sebastian Andrzej Siewior [this message]
2021-08-04 16:25 ` Steven Rostedt
2021-08-04 16:31 ` Sebastian Andrzej Siewior
2021-08-04 16:47 ` Steven Rostedt
2021-08-04 16:57 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210804162231.rfj5i736lqc4nsio@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=wagi@monom.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).