* [PATCH v1] drm: bridge: it66121: Check drm_bridge_attach retval
@ 2021-08-05 18:50 Robert Foss
2021-08-05 20:37 ` Jernej Škrabec
0 siblings, 1 reply; 3+ messages in thread
From: Robert Foss @ 2021-08-05 18:50 UTC (permalink / raw)
To: ple, narmstrong, a.hajda, robert.foss, Laurent.pinchart, jonas,
jernej.skrabec, airlied, daniel, dri-devel, linux-kernel,
Dan Carpenter
The return value of drm_bridge_attach() is ignored during
the it66121_bridge_attach() call, which is incorrect.
Fixes: 988156dc2fc9 ("drm: bridge: add it66121 driver")
Signed-off-by: Robert Foss <robert.foss@linaro.org>
---
drivers/gpu/drm/bridge/ite-it66121.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c
index 7149ed40af83..2f2a09adb4bc 100644
--- a/drivers/gpu/drm/bridge/ite-it66121.c
+++ b/drivers/gpu/drm/bridge/ite-it66121.c
@@ -536,6 +536,8 @@ static int it66121_bridge_attach(struct drm_bridge *bridge,
return -EINVAL;
ret = drm_bridge_attach(bridge->encoder, ctx->next_bridge, bridge, flags);
+ if (ret)
+ return ret;
ret = regmap_write_bits(ctx->regmap, IT66121_CLK_BANK_REG,
IT66121_CLK_BANK_PWROFF_RCLK, 0);
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] drm: bridge: it66121: Check drm_bridge_attach retval
2021-08-05 18:50 [PATCH v1] drm: bridge: it66121: Check drm_bridge_attach retval Robert Foss
@ 2021-08-05 20:37 ` Jernej Škrabec
2021-08-06 8:49 ` Robert Foss
0 siblings, 1 reply; 3+ messages in thread
From: Jernej Škrabec @ 2021-08-05 20:37 UTC (permalink / raw)
To: ple, narmstrong, a.hajda, robert.foss, Laurent.pinchart, jonas,
airlied, daniel, dri-devel, linux-kernel, Dan Carpenter,
Robert Foss
Hi!
Dne četrtek, 05. avgust 2021 ob 20:50:39 CEST je Robert Foss napisal(a):
> The return value of drm_bridge_attach() is ignored during
> the it66121_bridge_attach() call, which is incorrect.
>
> Fixes: 988156dc2fc9 ("drm: bridge: add it66121 driver")
> Signed-off-by: Robert Foss <robert.foss@linaro.org>
> ---
> drivers/gpu/drm/bridge/ite-it66121.c | 2 ++
> 1 file changed, 2 insertions(+)
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards,
Jernej
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] drm: bridge: it66121: Check drm_bridge_attach retval
2021-08-05 20:37 ` Jernej Škrabec
@ 2021-08-06 8:49 ` Robert Foss
0 siblings, 0 replies; 3+ messages in thread
From: Robert Foss @ 2021-08-06 8:49 UTC (permalink / raw)
To: Jernej Škrabec
Cc: Phong LE, Neil Armstrong, Andrzej Hajda, Laurent Pinchart,
Jonas Karlman, David Airlie, Daniel Vetter, dri-devel,
linux-kernel, Dan Carpenter
On Thu, 5 Aug 2021 at 22:37, Jernej Škrabec <jernej.skrabec@gmail.com> wrote:
>
> Hi!
>
> Dne četrtek, 05. avgust 2021 ob 20:50:39 CEST je Robert Foss napisal(a):
> > The return value of drm_bridge_attach() is ignored during
> > the it66121_bridge_attach() call, which is incorrect.
> >
> > Fixes: 988156dc2fc9 ("drm: bridge: add it66121 driver")
> > Signed-off-by: Robert Foss <robert.foss@linaro.org>
> > ---
> > drivers/gpu/drm/bridge/ite-it66121.c | 2 ++
> > 1 file changed, 2 insertions(+)
>
> Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
>
Applied to drm-misc-next
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-06 8:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-05 18:50 [PATCH v1] drm: bridge: it66121: Check drm_bridge_attach retval Robert Foss
2021-08-05 20:37 ` Jernej Škrabec
2021-08-06 8:49 ` Robert Foss
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).