From: Mark Brown <broonie@kernel.org>
To: Ravikumar Kattekola <callmerk1986@gmail.com>
Cc: Peter Geis <pgwipeout@gmail.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-mmc@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
devicetree@vger.kernel.org
Subject: Re: [BUG] mmc_regulator_set_ocr can't cope with regulator-fixed
Date: Fri, 6 Aug 2021 11:59:54 +0100 [thread overview]
Message-ID: <20210806105954.GV26252@sirena.org.uk> (raw)
In-Reply-To: <81006771-99bf-a5f9-4001-2cf3dc84f69d@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 278 bytes --]
On Fri, Aug 06, 2021 at 01:44:45PM +0530, Ravikumar Kattekola wrote:
> But, IMO mmc core should check if the voltage can be changed or not
>
> before trying to do regulator_set_voltage() in mmc_regulator_set_ocr().
It does exactly that in mmc_regulator_get_ocrmask().
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2021-08-06 11:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210804143357epcas1p1c67eca591d8bb557c11b8175baaa8550@epcas1p1.samsung.com>
2021-08-04 14:32 ` [BUG] mmc_regulator_set_ocr can't cope with regulator-fixed Peter Geis
2021-08-04 16:15 ` Mark Brown
2021-08-05 10:00 ` Jaehoon Chung
2021-08-05 11:38 ` Peter Geis
2021-08-05 12:46 ` Mark Brown
2021-08-05 12:58 ` Peter Geis
2021-08-05 13:08 ` Mark Brown
2021-08-06 8:14 ` Ravikumar Kattekola
2021-08-06 10:59 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210806105954.GV26252@sirena.org.uk \
--to=broonie@kernel.org \
--cc=callmerk1986@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jh80.chung@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=pgwipeout@gmail.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).