From: Peter Geis <pgwipeout@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Jaehoon Chung <jh80.chung@samsung.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-mmc@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
devicetree@vger.kernel.org
Subject: Re: [BUG] mmc_regulator_set_ocr can't cope with regulator-fixed
Date: Thu, 5 Aug 2021 08:58:58 -0400 [thread overview]
Message-ID: <CAMdYzYpR6br7s1RD2ze92WzJjtEDZwy9qS6YhghgXy7F91keFg@mail.gmail.com> (raw)
In-Reply-To: <20210805124650.GM26252@sirena.org.uk>
On Thu, Aug 5, 2021 at 8:47 AM Mark Brown <broonie@kernel.org> wrote:
>
> On Thu, Aug 05, 2021 at 07:38:06AM -0400, Peter Geis wrote:
>
> > Also, I've got a possible fix to the dw-mmc issue, the following patch
> > changes the behavior to only enable a fixed regulator, not try to set
> > the voltage. It's a split between the behavior when vmmc isn't defined
> > at all and when its a variable regulator:
>
> One thing to watch out for with this approach is if there's things that
> really need a specific voltage to be set then you'll have to stop those
> things happening if you've got a voltage regulator that can't deliver a
> voltage in the required range. I don't know if this affects MMC or not,
> if it's just a case of being less efficient it's not such an issue.
Yeah, but if this is a fixed regulator and it's a problem, then the
hardware is screwed anyways.
>
> > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> > index d333130d1531..b30102980261 100644
> > --- a/drivers/mmc/host/dw_mmc.c
> > +++ b/drivers/mmc/host/dw_mmc.c
> > @@ -1446,11 +1446,13 @@ static void dw_mci_set_ios(struct mmc_host
> > *mmc, struct mmc_ios *ios)
> > switch (ios->power_mode) {
> > case MMC_POWER_UP:
> > if (!IS_ERR(mmc->supply.vmmc)) {
> > - ret = mmc_regulator_set_ocr(mmc, mmc->supply.vmmc,
>
> This patch is very whitespace damaged FWIW.
Unfortunately gmail doesn't let you reply with patch sets without
mangling them, so it's only useful as an example.
If it seems sane I'll send it as a proper patch.
next prev parent reply other threads:[~2021-08-05 12:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210804143357epcas1p1c67eca591d8bb557c11b8175baaa8550@epcas1p1.samsung.com>
2021-08-04 14:32 ` [BUG] mmc_regulator_set_ocr can't cope with regulator-fixed Peter Geis
2021-08-04 16:15 ` Mark Brown
2021-08-05 10:00 ` Jaehoon Chung
2021-08-05 11:38 ` Peter Geis
2021-08-05 12:46 ` Mark Brown
2021-08-05 12:58 ` Peter Geis [this message]
2021-08-05 13:08 ` Mark Brown
2021-08-06 8:14 ` Ravikumar Kattekola
2021-08-06 10:59 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMdYzYpR6br7s1RD2ze92WzJjtEDZwy9qS6YhghgXy7F91keFg@mail.gmail.com \
--to=pgwipeout@gmail.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jh80.chung@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).