* [PATCH v1 1/1] platform/x86/intel: pmt: Use y instead of objs in Makefile
@ 2021-08-06 15:50 Andy Shevchenko
2021-08-09 9:00 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2021-08-06 15:50 UTC (permalink / raw)
To: Andy Shevchenko, David E. Box, platform-driver-x86, linux-kernel
Cc: Hans de Goede, Mark Gross
The 'objs' is for user space tools, for the kernel modules
we should use 'y'.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
Hans, feel free to fold in the original commit
drivers/platform/x86/intel/pmt/Makefile | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/intel/pmt/Makefile b/drivers/platform/x86/intel/pmt/Makefile
index 019103ee6522..279e158c7c23 100644
--- a/drivers/platform/x86/intel/pmt/Makefile
+++ b/drivers/platform/x86/intel/pmt/Makefile
@@ -4,9 +4,9 @@
# Intel Platform Monitoring Technology Drivers
#
-pmt_class-objs += class.o
obj-$(CONFIG_INTEL_PMT_CLASS) += pmt_class.o
-pmt_telemetry-objs += telemetry.o
+pmt_class-y := class.o
obj-$(CONFIG_INTEL_PMT_TELEMETRY) += pmt_telemetry.o
-pmt_crashlog-objs += crashlog.o
+pmt_telemetry-y := telemetry.o
obj-$(CONFIG_INTEL_PMT_CRASHLOG) += pmt_crashlog.o
+pmt_crashlog-y := crashlog.o
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1 1/1] platform/x86/intel: pmt: Use y instead of objs in Makefile
2021-08-06 15:50 [PATCH v1 1/1] platform/x86/intel: pmt: Use y instead of objs in Makefile Andy Shevchenko
@ 2021-08-09 9:00 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2021-08-09 9:00 UTC (permalink / raw)
To: Andy Shevchenko, David E. Box, platform-driver-x86, linux-kernel
Cc: Mark Gross
Hi,
On 8/6/21 5:50 PM, Andy Shevchenko wrote:
> The 'objs' is for user space tools, for the kernel modules
> we should use 'y'.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
>
> Hans, feel free to fold in the original commit
>
> drivers/platform/x86/intel/pmt/Makefile | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/platform/x86/intel/pmt/Makefile b/drivers/platform/x86/intel/pmt/Makefile
> index 019103ee6522..279e158c7c23 100644
> --- a/drivers/platform/x86/intel/pmt/Makefile
> +++ b/drivers/platform/x86/intel/pmt/Makefile
> @@ -4,9 +4,9 @@
> # Intel Platform Monitoring Technology Drivers
> #
>
> -pmt_class-objs += class.o
> obj-$(CONFIG_INTEL_PMT_CLASS) += pmt_class.o
> -pmt_telemetry-objs += telemetry.o
> +pmt_class-y := class.o
> obj-$(CONFIG_INTEL_PMT_TELEMETRY) += pmt_telemetry.o
> -pmt_crashlog-objs += crashlog.o
> +pmt_telemetry-y := telemetry.o
> obj-$(CONFIG_INTEL_PMT_CRASHLOG) += pmt_crashlog.o
> +pmt_crashlog-y := crashlog.o
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-09 9:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-06 15:50 [PATCH v1 1/1] platform/x86/intel: pmt: Use y instead of objs in Makefile Andy Shevchenko
2021-08-09 9:00 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).