* [PATCH 1/3] net: Kconfig: remove obsolete reference to config MICROBLAZE_64K_PAGES
2021-08-12 8:38 [PATCH 0/3] Kconfig symbol clean-up on net Lukas Bulwahn
@ 2021-08-12 8:38 ` Lukas Bulwahn
2021-08-12 8:38 ` [PATCH 2/3] net: 802: remove dead leftover after ipx driver removal Lukas Bulwahn
` (3 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Lukas Bulwahn @ 2021-08-12 8:38 UTC (permalink / raw)
To: David S . Miller, Jakub Kicinski, netdev
Cc: Madalin Bucur, Randy Dunlap, kernel-janitors, linux-kernel,
Lukas Bulwahn
Commit 05cdf457477d ("microblaze: Remove noMMU code") removes config
MICROBLAZE_64K_PAGES in arch/microblaze/Kconfig. However, there is still
a reference to MICROBLAZE_64K_PAGES in the config VMXNET3 in
./drivers/net/Kconfig.
Remove this obsolete reference to config MICROBLAZE_64K_PAGES.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
drivers/net/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 995c613086aa..f37b1c56f7c4 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -551,8 +551,8 @@ config VMXNET3
tristate "VMware VMXNET3 ethernet driver"
depends on PCI && INET
depends on !(PAGE_SIZE_64KB || ARM64_64K_PAGES || \
- IA64_PAGE_SIZE_64KB || MICROBLAZE_64K_PAGES || \
- PARISC_PAGE_SIZE_64KB || PPC_64K_PAGES)
+ IA64_PAGE_SIZE_64KB || PARISC_PAGE_SIZE_64KB || \
+ PPC_64K_PAGES)
help
This driver supports VMware's vmxnet3 virtual ethernet NIC.
To compile this driver as a module, choose M here: the
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 2/3] net: 802: remove dead leftover after ipx driver removal
2021-08-12 8:38 [PATCH 0/3] Kconfig symbol clean-up on net Lukas Bulwahn
2021-08-12 8:38 ` [PATCH 1/3] net: Kconfig: remove obsolete reference to config MICROBLAZE_64K_PAGES Lukas Bulwahn
@ 2021-08-12 8:38 ` Lukas Bulwahn
2021-08-12 8:38 ` [PATCH 3/3] net: dpaa_eth: remove dead select in menuconfig FSL_DPAA_ETH Lukas Bulwahn
` (2 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Lukas Bulwahn @ 2021-08-12 8:38 UTC (permalink / raw)
To: David S . Miller, Jakub Kicinski, netdev
Cc: Madalin Bucur, Randy Dunlap, kernel-janitors, linux-kernel,
Lukas Bulwahn
Commit 7a2e838d28cf ("staging: ipx: delete it from the tree") removes the
ipx driver and the config IPX. Since then, there is some dead leftover in
./net/802/, that was once used by the IPX driver, but has no other user.
Remove this dead leftover.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
net/802/Makefile | 1 -
net/802/p8023.c | 60 ------------------------------------------------
2 files changed, 61 deletions(-)
delete mode 100644 net/802/p8023.c
diff --git a/net/802/Makefile b/net/802/Makefile
index 19406a87bdaa..bfed80221b8b 100644
--- a/net/802/Makefile
+++ b/net/802/Makefile
@@ -8,7 +8,6 @@ obj-$(CONFIG_LLC) += p8022.o psnap.o
obj-$(CONFIG_NET_FC) += fc.o
obj-$(CONFIG_FDDI) += fddi.o
obj-$(CONFIG_HIPPI) += hippi.o
-obj-$(CONFIG_IPX) += p8022.o psnap.o p8023.o
obj-$(CONFIG_ATALK) += p8022.o psnap.o
obj-$(CONFIG_STP) += stp.o
obj-$(CONFIG_GARP) += garp.o
diff --git a/net/802/p8023.c b/net/802/p8023.c
deleted file mode 100644
index 19cd56990db2..000000000000
--- a/net/802/p8023.c
+++ /dev/null
@@ -1,60 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0-or-later
-/*
- * NET3: 802.3 data link hooks used for IPX 802.3
- *
- * 802.3 isn't really a protocol data link layer. Some old IPX stuff
- * uses it however. Note that there is only one 802.3 protocol layer
- * in the system. We don't currently support different protocols
- * running raw 802.3 on different devices. Thankfully nobody else
- * has done anything like the old IPX.
- */
-
-#include <linux/in.h>
-#include <linux/mm.h>
-#include <linux/module.h>
-#include <linux/netdevice.h>
-#include <linux/skbuff.h>
-#include <linux/slab.h>
-
-#include <net/datalink.h>
-#include <net/p8022.h>
-
-/*
- * Place an 802.3 header on a packet. The driver will do the mac
- * addresses, we just need to give it the buffer length.
- */
-static int p8023_request(struct datalink_proto *dl,
- struct sk_buff *skb, unsigned char *dest_node)
-{
- struct net_device *dev = skb->dev;
-
- dev_hard_header(skb, dev, ETH_P_802_3, dest_node, NULL, skb->len);
- return dev_queue_xmit(skb);
-}
-
-/*
- * Create an 802.3 client. Note there can be only one 802.3 client
- */
-struct datalink_proto *make_8023_client(void)
-{
- struct datalink_proto *proto = kmalloc(sizeof(*proto), GFP_ATOMIC);
-
- if (proto) {
- proto->header_length = 0;
- proto->request = p8023_request;
- }
- return proto;
-}
-
-/*
- * Destroy the 802.3 client.
- */
-void destroy_8023_client(struct datalink_proto *dl)
-{
- kfree(dl);
-}
-
-EXPORT_SYMBOL(destroy_8023_client);
-EXPORT_SYMBOL(make_8023_client);
-
-MODULE_LICENSE("GPL");
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 3/3] net: dpaa_eth: remove dead select in menuconfig FSL_DPAA_ETH
2021-08-12 8:38 [PATCH 0/3] Kconfig symbol clean-up on net Lukas Bulwahn
2021-08-12 8:38 ` [PATCH 1/3] net: Kconfig: remove obsolete reference to config MICROBLAZE_64K_PAGES Lukas Bulwahn
2021-08-12 8:38 ` [PATCH 2/3] net: 802: remove dead leftover after ipx driver removal Lukas Bulwahn
@ 2021-08-12 8:38 ` Lukas Bulwahn
2021-08-12 8:42 ` Madalin Bucur (OSS)
2021-08-13 23:34 ` [PATCH 0/3] Kconfig symbol clean-up on net Jakub Kicinski
2021-08-13 23:40 ` patchwork-bot+netdevbpf
4 siblings, 1 reply; 7+ messages in thread
From: Lukas Bulwahn @ 2021-08-12 8:38 UTC (permalink / raw)
To: David S . Miller, Jakub Kicinski, netdev
Cc: Madalin Bucur, Randy Dunlap, kernel-janitors, linux-kernel,
Lukas Bulwahn
The menuconfig FSL_DPAA_ETH selects config FSL_FMAN_MAC, but the config
FSL_FMAN_MAC never existed in the kernel tree.
Hence, ./scripts/checkkconfigsymbols.py warns:
FSL_FMAN_MAC
Referencing files: drivers/net/ethernet/freescale/dpaa/Kconfig
Remove this dead select in menuconfig FSL_DPAA_ETH.
Fixes: 9ad1a3749333 ("dpaa_eth: add support for DPAA Ethernet")
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
drivers/net/ethernet/freescale/dpaa/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/dpaa/Kconfig b/drivers/net/ethernet/freescale/dpaa/Kconfig
index 626ec58a0afc..0e1439fd00bd 100644
--- a/drivers/net/ethernet/freescale/dpaa/Kconfig
+++ b/drivers/net/ethernet/freescale/dpaa/Kconfig
@@ -4,7 +4,6 @@ menuconfig FSL_DPAA_ETH
depends on FSL_DPAA && FSL_FMAN
select PHYLIB
select FIXED_PHY
- select FSL_FMAN_MAC
help
Data Path Acceleration Architecture Ethernet driver,
supporting the Freescale QorIQ chips.
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* RE: [PATCH 3/3] net: dpaa_eth: remove dead select in menuconfig FSL_DPAA_ETH
2021-08-12 8:38 ` [PATCH 3/3] net: dpaa_eth: remove dead select in menuconfig FSL_DPAA_ETH Lukas Bulwahn
@ 2021-08-12 8:42 ` Madalin Bucur (OSS)
0 siblings, 0 replies; 7+ messages in thread
From: Madalin Bucur (OSS) @ 2021-08-12 8:42 UTC (permalink / raw)
To: Lukas Bulwahn, David S . Miller, Jakub Kicinski, netdev,
Camelia Alexandra Groza (OSS)
Cc: Randy Dunlap, kernel-janitors, linux-kernel
> -----Original Message-----
> From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> Sent: 12 August 2021 11:38
> To: David S . Miller <davem@davemloft.net>; Jakub Kicinski
> <kuba@kernel.org>; netdev@vger.kernel.org
> Cc: Madalin Bucur <madalin.bucur@nxp.com>; Randy Dunlap
> <rdunlap@infradead.org>; kernel-janitors@vger.kernel.org; linux-
> kernel@vger.kernel.org; Lukas Bulwahn <lukas.bulwahn@gmail.com>
> Subject: [PATCH 3/3] net: dpaa_eth: remove dead select in menuconfig
> FSL_DPAA_ETH
>
> The menuconfig FSL_DPAA_ETH selects config FSL_FMAN_MAC, but the config
> FSL_FMAN_MAC never existed in the kernel tree.
>
> Hence, ./scripts/checkkconfigsymbols.py warns:
>
> FSL_FMAN_MAC
> Referencing files: drivers/net/ethernet/freescale/dpaa/Kconfig
>
> Remove this dead select in menuconfig FSL_DPAA_ETH.
>
> Fixes: 9ad1a3749333 ("dpaa_eth: add support for DPAA Ethernet")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> drivers/net/ethernet/freescale/dpaa/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/dpaa/Kconfig
> b/drivers/net/ethernet/freescale/dpaa/Kconfig
> index 626ec58a0afc..0e1439fd00bd 100644
> --- a/drivers/net/ethernet/freescale/dpaa/Kconfig
> +++ b/drivers/net/ethernet/freescale/dpaa/Kconfig
> @@ -4,7 +4,6 @@ menuconfig FSL_DPAA_ETH
> depends on FSL_DPAA && FSL_FMAN
> select PHYLIB
> select FIXED_PHY
> - select FSL_FMAN_MAC
> help
> Data Path Acceleration Architecture Ethernet driver,
> supporting the Freescale QorIQ chips.
> --
> 2.17.1
Acked-by: Madalin Bucur <madalin.bucur@oss.nxp.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/3] Kconfig symbol clean-up on net
2021-08-12 8:38 [PATCH 0/3] Kconfig symbol clean-up on net Lukas Bulwahn
` (2 preceding siblings ...)
2021-08-12 8:38 ` [PATCH 3/3] net: dpaa_eth: remove dead select in menuconfig FSL_DPAA_ETH Lukas Bulwahn
@ 2021-08-13 23:34 ` Jakub Kicinski
2021-08-13 23:40 ` patchwork-bot+netdevbpf
4 siblings, 0 replies; 7+ messages in thread
From: Jakub Kicinski @ 2021-08-13 23:34 UTC (permalink / raw)
To: Lukas Bulwahn
Cc: David S . Miller, netdev, Madalin Bucur, Randy Dunlap,
kernel-janitors, linux-kernel
On Thu, 12 Aug 2021 10:38:03 +0200 Lukas Bulwahn wrote:
> The script ./scripts/checkkconfigsymbols.py warns on invalid references to
> Kconfig symbols (often, minor typos, name confusions or outdated references).
>
> This patch series addresses all issues reported by
> ./scripts/checkkconfigsymbols.py in ./net/ and ./drivers/net/ for Kconfig
> and Makefile files. Issues in the Kconfig and Makefile files indicate some
> shortcomings in the overall build definitions, and often are true actionable
> issues to address.
>
> These issues can be identified and filtered by:
>
> ./scripts/checkkconfigsymbols.py \
> | grep -E "(drivers/)?net/.*(Kconfig|Makefile)" -B 1 -A 1
>
> After applying this patch series on linux-next (next-20210811), the command
> above yields no further issues to address.
FWIW there's also:
arch/arm/configs/ixp4xx_defconfig:79:CONFIG_IPX=m
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 0/3] Kconfig symbol clean-up on net
2021-08-12 8:38 [PATCH 0/3] Kconfig symbol clean-up on net Lukas Bulwahn
` (3 preceding siblings ...)
2021-08-13 23:34 ` [PATCH 0/3] Kconfig symbol clean-up on net Jakub Kicinski
@ 2021-08-13 23:40 ` patchwork-bot+netdevbpf
4 siblings, 0 replies; 7+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-08-13 23:40 UTC (permalink / raw)
To: Lukas Bulwahn
Cc: davem, kuba, netdev, madalin.bucur, rdunlap, kernel-janitors,
linux-kernel
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Thu, 12 Aug 2021 10:38:03 +0200 you wrote:
> Dear David, dear Jakub,
>
> The script ./scripts/checkkconfigsymbols.py warns on invalid references to
> Kconfig symbols (often, minor typos, name confusions or outdated references).
>
> This patch series addresses all issues reported by
> ./scripts/checkkconfigsymbols.py in ./net/ and ./drivers/net/ for Kconfig
> and Makefile files. Issues in the Kconfig and Makefile files indicate some
> shortcomings in the overall build definitions, and often are true actionable
> issues to address.
>
> [...]
Here is the summary with links:
- [1/3] net: Kconfig: remove obsolete reference to config MICROBLAZE_64K_PAGES
https://git.kernel.org/netdev/net-next/c/4fb464db9c72
- [2/3] net: 802: remove dead leftover after ipx driver removal
https://git.kernel.org/netdev/net-next/c/d8d9ba8dc9c7
- [3/3] net: dpaa_eth: remove dead select in menuconfig FSL_DPAA_ETH
https://git.kernel.org/netdev/net-next/c/f75d81556a38
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 7+ messages in thread