* [PATCH] fix slab-out-of-bounds in betopff_init function
@ 2021-08-15 8:31 F.A.Sulaiman
0 siblings, 0 replies; 2+ messages in thread
From: F.A.Sulaiman @ 2021-08-15 8:31 UTC (permalink / raw)
To: jikos, benjamin.tissoires; +Cc: F.A.Sulaiman, linux-input, linux-kernel
This patch resolves the bug 'KASAN: slab-out-of-bounds Write in betop_probe' reported by Syzbot.
Patch resolve the bug by checking hid_device's hid_input is non empty before it's been used.
Signed-off-by: F.A. SULAIMAN <asha.16@itfac.mrt.ac.lk>
---
drivers/hid/hid-betopff.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/hid/hid-betopff.c b/drivers/hid/hid-betopff.c
index 0790fbd3fc9a..6a1f894b0e97 100644
--- a/drivers/hid/hid-betopff.c
+++ b/drivers/hid/hid-betopff.c
@@ -56,19 +56,20 @@ static int betopff_init(struct hid_device *hid)
{
struct betopff_device *betopff;
struct hid_report *report;
- struct hid_input *hidinput =
- list_first_entry(&hid->inputs, struct hid_input, list);
+ struct hid_input *hidinput;
struct list_head *report_list =
&hid->report_enum[HID_OUTPUT_REPORT].report_list;
- struct input_dev *dev = hidinput->input;
+ struct input_dev *dev;
int field_count = 0;
int error;
int i, j;
- if (list_empty(report_list)) {
+ if (list_empty(&hid->inputs)) {
hid_err(hid, "no output reports found\n");
return -ENODEV;
}
+ hidinput = list_entry(hid->inputs.next, struct hid_input, list);
+ dev = hidinput->input;
report = list_first_entry(report_list, struct hid_report, list);
/*
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] fix slab-out-of-bounds in betopff_init function
@ 2021-08-15 14:07 F.A.Sulaiman
0 siblings, 0 replies; 2+ messages in thread
From: F.A.Sulaiman @ 2021-08-15 14:07 UTC (permalink / raw)
To: jikos, benjamin.tissoires; +Cc: F.A.Sulaiman, linux-input, linux-kernel
This patch resolves the bug 'KASAN: slab-out-of-bounds Write in betop_probe' reported by Syzbot.
Patch resolve the bug by checking hid_device's hid_input is non empty before it's been used.
Signed-off-by: F.A. SULAIMAN <asha.16@itfac.mrt.ac.lk>
---
drivers/hid/hid-betopff.c | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/drivers/hid/hid-betopff.c b/drivers/hid/hid-betopff.c
index 0790fbd3fc9a..467d789f9bc2 100644
--- a/drivers/hid/hid-betopff.c
+++ b/drivers/hid/hid-betopff.c
@@ -56,15 +56,22 @@ static int betopff_init(struct hid_device *hid)
{
struct betopff_device *betopff;
struct hid_report *report;
- struct hid_input *hidinput =
- list_first_entry(&hid->inputs, struct hid_input, list);
+ struct hid_input *hidinput;
struct list_head *report_list =
&hid->report_enum[HID_OUTPUT_REPORT].report_list;
- struct input_dev *dev = hidinput->input;
+ struct input_dev *dev;
int field_count = 0;
int error;
int i, j;
+ if (list_empty(&hid->inputs)) {
+ hid_err(hid, "no inputs found\n");
+ return -ENODEV;
+ }
+
+ hidinput = list_first_entry(&hid->inputs, struct hid_input, list);
+ dev = hidinput->input;
+
if (list_empty(report_list)) {
hid_err(hid, "no output reports found\n");
return -ENODEV;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-15 14:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-15 8:31 [PATCH] fix slab-out-of-bounds in betopff_init function F.A.Sulaiman
2021-08-15 14:07 F.A.Sulaiman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).