* [PATCH] leds: flash: Remove redundant initialization of variable ret
@ 2021-06-12 13:25 Colin King
2021-08-16 6:51 ` Pavel Machek
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2021-06-12 13:25 UTC (permalink / raw)
To: Pavel Machek, linux-leds; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The variable ret is being initialized with a value that is never read,
it is being updated later on. The assignment is redundant and can be
removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/leds/led-class-flash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/leds/led-class-flash.c b/drivers/leds/led-class-flash.c
index 6eeb9effcf65..e4c4fd97bf30 100644
--- a/drivers/leds/led-class-flash.c
+++ b/drivers/leds/led-class-flash.c
@@ -92,7 +92,7 @@ static ssize_t flash_strobe_store(struct device *dev,
struct led_classdev *led_cdev = dev_get_drvdata(dev);
struct led_classdev_flash *fled_cdev = lcdev_to_flcdev(led_cdev);
unsigned long state;
- ssize_t ret = -EINVAL;
+ ssize_t ret;
mutex_lock(&led_cdev->led_access);
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] leds: flash: Remove redundant initialization of variable ret
2021-06-12 13:25 [PATCH] leds: flash: Remove redundant initialization of variable ret Colin King
@ 2021-08-16 6:51 ` Pavel Machek
2021-08-16 7:55 ` Colin Ian King
0 siblings, 1 reply; 3+ messages in thread
From: Pavel Machek @ 2021-08-16 6:51 UTC (permalink / raw)
To: Colin King; +Cc: linux-leds, kernel-janitors, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1532 bytes --]
Hi!
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable ret is being initialized with a value that is never read,
> it is being updated later on. The assignment is redundant and can be
> removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
I did this instead; hopefully that's okay with everyone.
Best regards,
Pavel
commit 654933ae7d32f278eecd0bb0f175785574ac4775
Author: Pavel Machek <pavel@ucw.cz>
Date: Mon Aug 16 08:47:08 2021 +0200
leds: flash: Remove redundant initialization of variable ret
Adjust initialization not to trigger Coverity warnings.
Reported-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
diff --git a/drivers/leds/led-class-flash.c b/drivers/leds/led-class-flash.c
index 6eeb9effcf65..185e17055317 100644
--- a/drivers/leds/led-class-flash.c
+++ b/drivers/leds/led-class-flash.c
@@ -92,14 +92,12 @@ static ssize_t flash_strobe_store(struct device *dev,
struct led_classdev *led_cdev = dev_get_drvdata(dev);
struct led_classdev_flash *fled_cdev = lcdev_to_flcdev(led_cdev);
unsigned long state;
- ssize_t ret = -EINVAL;
+ ssize_t ret = -EBUSY;
mutex_lock(&led_cdev->led_access);
- if (led_sysfs_is_disabled(led_cdev)) {
- ret = -EBUSY;
+ if (led_sysfs_is_disabled(led_cdev))
goto unlock;
- }
ret = kstrtoul(buf, 10, &state);
if (ret)
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] leds: flash: Remove redundant initialization of variable ret
2021-08-16 6:51 ` Pavel Machek
@ 2021-08-16 7:55 ` Colin Ian King
0 siblings, 0 replies; 3+ messages in thread
From: Colin Ian King @ 2021-08-16 7:55 UTC (permalink / raw)
To: Pavel Machek; +Cc: linux-leds, kernel-janitors, linux-kernel
On 16/08/2021 07:51, Pavel Machek wrote:
> Hi!
>
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The variable ret is being initialized with a value that is never read,
>> it is being updated later on. The assignment is redundant and can be
>> removed.
>>
>> Addresses-Coverity: ("Unused value")
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> I did this instead; hopefully that's okay with everyone.
>
> Best regards,
> Pavel
Thanks, looks good to me.
Colin
>
> commit 654933ae7d32f278eecd0bb0f175785574ac4775
> Author: Pavel Machek <pavel@ucw.cz>
> Date: Mon Aug 16 08:47:08 2021 +0200
>
> leds: flash: Remove redundant initialization of variable ret
>
> Adjust initialization not to trigger Coverity warnings.
>
> Reported-by: Colin Ian King <colin.king@canonical.com>
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
>
> diff --git a/drivers/leds/led-class-flash.c b/drivers/leds/led-class-flash.c
> index 6eeb9effcf65..185e17055317 100644
> --- a/drivers/leds/led-class-flash.c
> +++ b/drivers/leds/led-class-flash.c
> @@ -92,14 +92,12 @@ static ssize_t flash_strobe_store(struct device *dev,
> struct led_classdev *led_cdev = dev_get_drvdata(dev);
> struct led_classdev_flash *fled_cdev = lcdev_to_flcdev(led_cdev);
> unsigned long state;
> - ssize_t ret = -EINVAL;
> + ssize_t ret = -EBUSY;
>
> mutex_lock(&led_cdev->led_access);
>
> - if (led_sysfs_is_disabled(led_cdev)) {
> - ret = -EBUSY;
> + if (led_sysfs_is_disabled(led_cdev))
> goto unlock;
> - }
>
> ret = kstrtoul(buf, 10, &state);
> if (ret)
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-16 7:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-12 13:25 [PATCH] leds: flash: Remove redundant initialization of variable ret Colin King
2021-08-16 6:51 ` Pavel Machek
2021-08-16 7:55 ` Colin Ian King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).