From: "HORIGUCHI NAOYA(堀口 直也)" <naoya.horiguchi@nec.com>
To: David Hildenbrand <david@redhat.com>
Cc: Naoya Horiguchi <naoya.horiguchi@linux.dev>,
Yang Shi <shy828301@gmail.com>,
"osalvador@suse.de" <osalvador@suse.de>,
"tdmackey@twitter.com" <tdmackey@twitter.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"corbet@lwn.net" <corbet@lwn.net>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] mm: hwpoison: don't drop slab caches for offlining non-LRU page
Date: Wed, 18 Aug 2021 07:53:17 +0000 [thread overview]
Message-ID: <20210818075316.GB501393@hori.linux.bs1.fc.nec.co.jp> (raw)
In-Reply-To: <dd225992-ec89-a911-b318-f4a91c70ed42@redhat.com>
On Wed, Aug 18, 2021 at 09:24:01AM +0200, David Hildenbrand wrote:
...
>
> Might we want to add a TODO in the code? We have a similar one in
> mm/page_isolation.c:set_migratetype_isolate() and it's certainly a reminder
> that something of value is missing.
Yes, that will be helpful. The below's what's in my mind, but if someone
has better idea, that's fine.
@@ -296,11 +296,9 @@ void shake_page(struct page *p, int access)
}
/*
- * Only call shrink_node_slabs here (which would also shrink
- * other caches) if access is not potentially fatal.
+ * TODO: Could shrink slab caches here if a lightweight range-based
+ * shrinker will be available.
*/
- if (access)
- drop_slab_node(page_to_nid(p));
}
EXPORT_SYMBOL_GPL(shake_page);
- Naoya Horiguchi
next prev parent reply other threads:[~2021-08-18 7:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 18:09 [PATCH 1/2] mm: hwpoison: don't drop slab caches for offlining non-LRU page Yang Shi
2021-08-16 18:09 ` [PATCH 2/2] doc: hwpoison: correct the support for hugepage Yang Shi
2021-08-18 6:36 ` HORIGUCHI NAOYA(堀口 直也)
2021-08-16 19:02 ` [PATCH 1/2] mm: hwpoison: don't drop slab caches for offlining non-LRU page David Hildenbrand
2021-08-16 19:04 ` David Hildenbrand
2021-08-16 19:15 ` David Hildenbrand
2021-08-16 19:37 ` Yang Shi
2021-08-16 19:40 ` David Hildenbrand
2021-08-16 19:37 ` Matthew Wilcox
2021-08-16 20:24 ` Yang Shi
2021-08-18 5:02 ` HORIGUCHI NAOYA(堀口 直也)
2021-08-18 17:45 ` Yang Shi
2021-08-18 6:30 ` Naoya Horiguchi
2021-08-18 7:24 ` David Hildenbrand
2021-08-18 7:53 ` HORIGUCHI NAOYA(堀口 直也) [this message]
2021-08-18 7:55 ` David Hildenbrand
2021-08-18 17:04 ` Yang Shi
2021-08-18 17:02 ` Yang Shi
2021-08-18 18:01 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210818075316.GB501393@hori.linux.bs1.fc.nec.co.jp \
--to=naoya.horiguchi@nec.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naoya.horiguchi@linux.dev \
--cc=osalvador@suse.de \
--cc=shy828301@gmail.com \
--cc=tdmackey@twitter.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).