From: Yang Shi <shy828301@gmail.com>
To: "HORIGUCHI NAOYA(堀口 直也)" <naoya.horiguchi@nec.com>
Cc: Matthew Wilcox <willy@infradead.org>,
Oscar Salvador <osalvador@suse.de>,
"tdmackey@twitter.com" <tdmackey@twitter.com>,
Andrew Morton <akpm@linux-foundation.org>,
Jonathan Corbet <corbet@lwn.net>, Linux MM <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] mm: hwpoison: don't drop slab caches for offlining non-LRU page
Date: Wed, 18 Aug 2021 10:45:08 -0700 [thread overview]
Message-ID: <CAHbLzkqHJ6imN_T2UwgJErj6eBuMx-mLY7=e_dU0cL-7hNkirg@mail.gmail.com> (raw)
In-Reply-To: <20210818050239.GA496938@hori.linux.bs1.fc.nec.co.jp>
On Tue, Aug 17, 2021 at 10:02 PM HORIGUCHI NAOYA(堀口 直也)
<naoya.horiguchi@nec.com> wrote:
>
> On Mon, Aug 16, 2021 at 01:24:25PM -0700, Yang Shi wrote:
> > On Mon, Aug 16, 2021 at 12:38 PM Matthew Wilcox <willy@infradead.org> wrote:
> > >
> > > On Mon, Aug 16, 2021 at 11:09:08AM -0700, Yang Shi wrote:
> > > > But the most disappointing thing is all the effort doesn't make the page
> > > > offline, it just returns:
> > > >
> > > > soft_offline: 0x1469f2: unknown non LRU page type 5ffff0000000000 ()
> > >
> > > It's a shame it doesn't call dump_page(). There might be more
> > > interesting information somewhere in struct page that would help us
> > > figure out what kind of page it was in your environment. For example,
> > > it might be a page table page or a page allocated for vmalloc(), and
> > > in both those cases, there are things we might be able to do (we'd
> > > certainly be able to figure out that it isn't worth shrinking slab!)
> >
> > Yes, dump_page() could provide more information to us. I could add a
> > new patch or just update this patch to call dump_page() if offline is
> > failed if the hwpoison maintainer agrees to this as well.
>
> I agree with showing more information in failure case. Thanks for the input.
By reading the code, it seems get_any_page() is called to shake the
page for both soft offline and memory_failure(), so it seems like a
good place to call dump_page() if -EIO is going to be returned, which
hwpoison can't handle the page, otherwise we may need call dump_page()
in a couple of different places.
Although dump_page() will be called with pcp disabled and holding
memory hotplug lock if it is called by get_any_page(), but I'm
supposed it should be not a big deal.
>
> - Naoya Horiguchi
next prev parent reply other threads:[~2021-08-18 17:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 18:09 [PATCH 1/2] mm: hwpoison: don't drop slab caches for offlining non-LRU page Yang Shi
2021-08-16 18:09 ` [PATCH 2/2] doc: hwpoison: correct the support for hugepage Yang Shi
2021-08-18 6:36 ` HORIGUCHI NAOYA(堀口 直也)
2021-08-16 19:02 ` [PATCH 1/2] mm: hwpoison: don't drop slab caches for offlining non-LRU page David Hildenbrand
2021-08-16 19:04 ` David Hildenbrand
2021-08-16 19:15 ` David Hildenbrand
2021-08-16 19:37 ` Yang Shi
2021-08-16 19:40 ` David Hildenbrand
2021-08-16 19:37 ` Matthew Wilcox
2021-08-16 20:24 ` Yang Shi
2021-08-18 5:02 ` HORIGUCHI NAOYA(堀口 直也)
2021-08-18 17:45 ` Yang Shi [this message]
2021-08-18 6:30 ` Naoya Horiguchi
2021-08-18 7:24 ` David Hildenbrand
2021-08-18 7:53 ` HORIGUCHI NAOYA(堀口 直也)
2021-08-18 7:55 ` David Hildenbrand
2021-08-18 17:04 ` Yang Shi
2021-08-18 17:02 ` Yang Shi
2021-08-18 18:01 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHbLzkqHJ6imN_T2UwgJErj6eBuMx-mLY7=e_dU0cL-7hNkirg@mail.gmail.com' \
--to=shy828301@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naoya.horiguchi@nec.com \
--cc=osalvador@suse.de \
--cc=tdmackey@twitter.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).