From: Eryu Guan <eguan@linux.alibaba.com>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: Eryu Guan <guan@eryu.me>,
fstests@vger.kernel.org, hare@suse.de, dgilbert@interlog.com,
jeyu@kernel.org, lucas.demarchi@intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] common/module: add patient module rmmod support
Date: Thu, 19 Aug 2021 10:26:44 +0800 [thread overview]
Message-ID: <20210819022644.GP60846@e18g06458.et15sqa> (raw)
In-Reply-To: <YR0TEE8lUwo6QlHw@bombadil.infradead.org>
On Wed, Aug 18, 2021 at 07:02:56AM -0700, Luis Chamberlain wrote:
> On Sun, Aug 15, 2021 at 08:29:42PM +0800, Eryu Guan wrote:
> > On Wed, Aug 11, 2021 at 08:45:11AM -0700, Luis Chamberlain wrote:
> > > common/config | 31 +++++++++++++++
> > > common/module | 107 ++++++++++++++++++++++++++++++++++++++++++++++++++
> >
> > Please also update README to document the new configurable variables.
>
> Got it.
>
> > > 2 files changed, 138 insertions(+)
> > >
> > > diff --git a/common/config b/common/config
> > > index 005fd50a..9b8a2bc4 100644
> > > --- a/common/config
> > > +++ b/common/config
> >
> > 100s as default seems a bit long to me, use 10s as in v1 patch?
>
> In practice I tried using 10s and from my observations we *still* ran
> into false positives. So from my own testing peace of mind I'd prefer at
> least something higher, and if its going to be higher might as well go
> with something which at least makes painfully safe. I'll go with 50s
> for my next submission.
>
> > > + fi
> > > +else
> > > + MODPROBE_RM_PATIENT_TIMEOUT_ARGS=""
> > > + if [[ ! -z "$MODPROBE_PATIENT_RM_TIMEOUT_SECONDS" ]]; then
> > > + if [[ "$MODPROBE_PATIENT_RM_TIMEOUT_MS" != "forever" ]]; then
> >
> > Should check MODPROBE_PATIENT_RM_TIMEOUT_SECONDS instead?
>
> Indeed will fix.
>
> > > diff --git a/common/module b/common/module
> > > index 39e4e793..03953fa1 100644
> > > --- a/common/module
> > > +++ b/common/module
> > > @@ -4,6 +4,8 @@
> > > #
> > > # Routines for messing around with loadable kernel modules
> > >
> > > +source common/config
> > > +
> >
> > Seems there's no need to source common/config here, as it's sourced in
> > common/rc, which is sourced by every test.
>
> OK.
>
> > > + local max_tries_max=$MODPROBE_PATIENT_RM_TIMEOUT_SECONDS
> <-- snip -->
>
> > > + local max_tries=0
> <-- snip -->
>
> > > + max_tries=$max_tries_max
> > > +
> > > + while [[ "$max_tries" != "0" ]]; do
> >
> > Use "$max_tries -ne 0" to check inters seems better.
>
> max_tries can be "forever", in which case this is -eq 0:
>
> $ foo="forever"; if [[ $foo -eq 0 ]]; then echo buggy; else echo ok; fi
> buggy
I see, that makes sense. Then perhaps some comments would help.
Thanks,
Eryu
>
> > > + refcnt_is_zero=1
> > > + break
> > > + fi
> > > + sleep 1
> > > + if [[ "$max_tries" == "forever" ]]; then
> > > + continue
> > > + fi
> > > + let max_tries=$max_tries-1
> > > + done
> > > +
> > > + if [[ $refcnt_is_zero -ne 1 ]]; then
> > > + echo "custom patient module removal for $module timed out waiting for refcnt to become 0 using timeout of $max_tries_max"
> > > + return -1
> > > + fi
> > > +
> > > + # If we ran out of time but our refcnt check confirms we had
> > > + # a refcnt of 0, just try to remove the module once.
> > > + if [[ "$max_tries" == "0" ]]; then
> >
> > $max_tries -eq 0
>
> Same issue.
>
> Luis
next prev parent reply other threads:[~2021-08-19 2:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 15:45 [PATCH v2 0/3] fstests: add patient module remover Luis Chamberlain
2021-08-11 15:45 ` [PATCH v2 1/3] fstests: use udevadm settle after pvremove Luis Chamberlain
2021-08-15 12:36 ` Eryu Guan
2021-08-11 15:45 ` [PATCH v2 2/3] common/module: add patient module rmmod support Luis Chamberlain
2021-08-15 12:29 ` Eryu Guan
2021-08-18 14:02 ` Luis Chamberlain
2021-08-19 2:26 ` Eryu Guan [this message]
2021-08-19 23:58 ` Luis Chamberlain
2021-08-11 15:45 ` [PATCH v2 3/3] common/scsi_debug: use the patient module remover Luis Chamberlain
2021-08-15 12:35 ` Eryu Guan
2021-08-20 0:33 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210819022644.GP60846@e18g06458.et15sqa \
--to=eguan@linux.alibaba.com \
--cc=dgilbert@interlog.com \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=hare@suse.de \
--cc=jeyu@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).