From: Luis Chamberlain <mcgrof@kernel.org>
To: Eryu Guan <eguan@linux.alibaba.com>
Cc: Eryu Guan <guan@eryu.me>,
fstests@vger.kernel.org, hare@suse.de, dgilbert@interlog.com,
jeyu@kernel.org, lucas.demarchi@intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] common/module: add patient module rmmod support
Date: Thu, 19 Aug 2021 16:58:52 -0700 [thread overview]
Message-ID: <YR7wPBGu1Ba/4kzR@bombadil.infradead.org> (raw)
In-Reply-To: <20210819022644.GP60846@e18g06458.et15sqa>
On Thu, Aug 19, 2021 at 10:26:44AM +0800, Eryu Guan wrote:
> On Wed, Aug 18, 2021 at 07:02:56AM -0700, Luis Chamberlain wrote:
> > On Sun, Aug 15, 2021 at 08:29:42PM +0800, Eryu Guan wrote:
> > >
> > > Use "$max_tries -ne 0" to check inters seems better.
> >
> > max_tries can be "forever", in which case this is -eq 0:
> >
> > $ foo="forever"; if [[ $foo -eq 0 ]]; then echo buggy; else echo ok; fi
> > buggy
>
> I see, that makes sense. Then perhaps some comments would help.
I had sent out a v3 before seeing this request. I'll send a v4 with
a comment clarifying this.
Luis
next prev parent reply other threads:[~2021-08-19 23:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 15:45 [PATCH v2 0/3] fstests: add patient module remover Luis Chamberlain
2021-08-11 15:45 ` [PATCH v2 1/3] fstests: use udevadm settle after pvremove Luis Chamberlain
2021-08-15 12:36 ` Eryu Guan
2021-08-11 15:45 ` [PATCH v2 2/3] common/module: add patient module rmmod support Luis Chamberlain
2021-08-15 12:29 ` Eryu Guan
2021-08-18 14:02 ` Luis Chamberlain
2021-08-19 2:26 ` Eryu Guan
2021-08-19 23:58 ` Luis Chamberlain [this message]
2021-08-11 15:45 ` [PATCH v2 3/3] common/scsi_debug: use the patient module remover Luis Chamberlain
2021-08-15 12:35 ` Eryu Guan
2021-08-20 0:33 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YR7wPBGu1Ba/4kzR@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=dgilbert@interlog.com \
--cc=eguan@linux.alibaba.com \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=hare@suse.de \
--cc=jeyu@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).