From: Maxime Ripard <maxime@cerno.tech>
To: dri-devel@lists.freedesktop.org,
Daniel Vetter <daniel.vetter@intel.com>,
David Airlie <airlied@linux.ie>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Maxime Ripard <maxime@cerno.tech>
Cc: linux-kernel@vger.kernel.org,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Phil Elwell <phil@raspberrypi.com>,
Tim Gover <tim.gover@raspberrypi.com>,
Dom Cobley <dom@raspberrypi.com>,
Boris Brezillon <bbrezillon@kernel.org>,
linux-rpi-kernel@lists.infradead.org,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
bcm-kernel-feedback-list@broadcom.com,
Emma Anholt <emma@anholt.net>,
Nicolas Saenz Julienne <nsaenz@kernel.org>,
Maxime Ripard <mripard@kernel.org>
Subject: [PATCH v3 1/6] drm/vc4: select PM
Date: Thu, 19 Aug 2021 15:59:26 +0200 [thread overview]
Message-ID: <20210819135931.895976-2-maxime@cerno.tech> (raw)
In-Reply-To: <20210819135931.895976-1-maxime@cerno.tech>
We already depend on runtime PM to get the power domains and clocks for
most of the devices supported by the vc4 driver, so let's just select it
to make sure it's there, and remove the ifdef.
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
drivers/gpu/drm/vc4/Kconfig | 1 +
drivers/gpu/drm/vc4/vc4_hdmi.c | 2 --
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/vc4/Kconfig b/drivers/gpu/drm/vc4/Kconfig
index 118e8a426b1a..f774ab340863 100644
--- a/drivers/gpu/drm/vc4/Kconfig
+++ b/drivers/gpu/drm/vc4/Kconfig
@@ -9,6 +9,7 @@ config DRM_VC4
select DRM_KMS_CMA_HELPER
select DRM_GEM_CMA_HELPER
select DRM_PANEL_BRIDGE
+ select PM
select SND_PCM
select SND_PCM_ELD
select SND_SOC_GENERIC_DMAENGINE_PCM
diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
index c2876731ee2d..602203b2d8e1 100644
--- a/drivers/gpu/drm/vc4/vc4_hdmi.c
+++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
@@ -2107,7 +2107,6 @@ static int vc5_hdmi_init_resources(struct vc4_hdmi *vc4_hdmi)
return 0;
}
-#ifdef CONFIG_PM
static int vc4_hdmi_runtime_suspend(struct device *dev)
{
struct vc4_hdmi *vc4_hdmi = dev_get_drvdata(dev);
@@ -2128,7 +2127,6 @@ static int vc4_hdmi_runtime_resume(struct device *dev)
return 0;
}
-#endif
static int vc4_hdmi_bind(struct device *dev, struct device *master, void *data)
{
--
2.31.1
next prev parent reply other threads:[~2021-08-19 13:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 13:59 [PATCH v3 0/6] drm/vc4: hdmi: Fix CEC access while disabled Maxime Ripard
2021-08-19 13:59 ` Maxime Ripard [this message]
2021-09-10 13:40 ` [PATCH v3 1/6] drm/vc4: select PM Dave Stevenson
2021-09-19 16:40 ` [PATCH v3 1/6] drm/vc4: select PM (openrisc) Randy Dunlap
2021-09-22 8:41 ` Maxime Ripard
2021-09-22 15:49 ` Nathan Chancellor
2021-09-23 14:52 ` Maxime Ripard
2021-09-23 14:55 ` Nathan Chancellor
2021-09-23 15:58 ` Maxime Ripard
2021-08-19 13:59 ` [PATCH v3 2/6] drm/vc4: hdmi: Make sure the controller is powered up during bind Maxime Ripard
2021-08-19 13:59 ` [PATCH v3 3/6] drm/vc4: hdmi: Rework the pre_crtc_configure error handling Maxime Ripard
2021-08-19 13:59 ` [PATCH v3 4/6] drm/vc4: hdmi: Split the CEC disable / enable functions in two Maxime Ripard
2021-08-19 13:59 ` [PATCH v3 5/6] drm/vc4: hdmi: Make sure the device is powered with CEC Maxime Ripard
2021-08-19 13:59 ` [PATCH v3 6/6] drm/vc4: hdmi: Warn if we access the controller while disabled Maxime Ripard
2021-09-14 7:55 ` [PATCH v3 0/6] drm/vc4: hdmi: Fix CEC access " Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210819135931.895976-2-maxime@cerno.tech \
--to=maxime@cerno.tech \
--cc=airlied@linux.ie \
--cc=bbrezillon@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=daniel.vetter@intel.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=dom@raspberrypi.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=nsaenz@kernel.org \
--cc=phil@raspberrypi.com \
--cc=tim.gover@raspberrypi.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).