* [PATCH 1/2] staging: r8188eu: remove dead code
@ 2021-08-22 11:40 Michael Straube
2021-08-22 11:40 ` [PATCH 2/2] staging: r8188eu: remove unnecessary parentheses Michael Straube
0 siblings, 1 reply; 2+ messages in thread
From: Michael Straube @ 2021-08-22 11:40 UTC (permalink / raw)
To: gregkh
Cc: Larry.Finger, phil, martin, fmdefrancesco, linux-staging,
linux-kernel, Michael Straube
if (0) is never true, remove code that is never executed.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
drivers/staging/r8188eu/core/rtw_led.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/r8188eu/core/rtw_led.c b/drivers/staging/r8188eu/core/rtw_led.c
index 306862aec53a..29c48f1a4fec 100644
--- a/drivers/staging/r8188eu/core/rtw_led.c
+++ b/drivers/staging/r8188eu/core/rtw_led.c
@@ -121,10 +121,7 @@ static void SwLedBlink(struct LED_871x *pLed)
}
if (bStopBlinking) {
- /* if (padapter->pwrctrlpriv.cpwm >= PS_STATE_S2) */
- if (0) {
- SwLedOff(padapter, pLed);
- } else if ((check_fwstate(pmlmepriv, _FW_LINKED)) && (!pLed->bLedOn)) {
+ if ((check_fwstate(pmlmepriv, _FW_LINKED)) && (!pLed->bLedOn)) {
SwLedOn(padapter, pLed);
} else if ((check_fwstate(pmlmepriv, _FW_LINKED)) && pLed->bLedOn) {
SwLedOff(padapter, pLed);
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 2/2] staging: r8188eu: remove unnecessary parentheses
2021-08-22 11:40 [PATCH 1/2] staging: r8188eu: remove dead code Michael Straube
@ 2021-08-22 11:40 ` Michael Straube
0 siblings, 0 replies; 2+ messages in thread
From: Michael Straube @ 2021-08-22 11:40 UTC (permalink / raw)
To: gregkh
Cc: Larry.Finger, phil, martin, fmdefrancesco, linux-staging,
linux-kernel, Michael Straube
Remove unnecessary parentheses to improve readability.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
drivers/staging/r8188eu/core/rtw_led.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/r8188eu/core/rtw_led.c b/drivers/staging/r8188eu/core/rtw_led.c
index 29c48f1a4fec..cd27873c3e63 100644
--- a/drivers/staging/r8188eu/core/rtw_led.c
+++ b/drivers/staging/r8188eu/core/rtw_led.c
@@ -121,9 +121,9 @@ static void SwLedBlink(struct LED_871x *pLed)
}
if (bStopBlinking) {
- if ((check_fwstate(pmlmepriv, _FW_LINKED)) && (!pLed->bLedOn)) {
+ if (check_fwstate(pmlmepriv, _FW_LINKED) && !pLed->bLedOn) {
SwLedOn(padapter, pLed);
- } else if ((check_fwstate(pmlmepriv, _FW_LINKED)) && pLed->bLedOn) {
+ } else if (check_fwstate(pmlmepriv, _FW_LINKED) && pLed->bLedOn) {
SwLedOff(padapter, pLed);
}
pLed->BlinkTimes = 0;
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-22 11:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-22 11:40 [PATCH 1/2] staging: r8188eu: remove dead code Michael Straube
2021-08-22 11:40 ` [PATCH 2/2] staging: r8188eu: remove unnecessary parentheses Michael Straube
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).