* [PATCH] iio: adc: twl6030-gpadc: Use the defined variable to clean code
@ 2021-08-23 9:59 Tang Bin
2021-08-30 11:32 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Tang Bin @ 2021-08-23 9:59 UTC (permalink / raw)
To: jic23, lars; +Cc: linux-iio, linux-kernel, Tang Bin
Use the defined variable "dev" to make the code cleaner.
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
drivers/iio/adc/twl6030-gpadc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/iio/adc/twl6030-gpadc.c b/drivers/iio/adc/twl6030-gpadc.c
index 0859f3f7d..5e4fbb033 100644
--- a/drivers/iio/adc/twl6030-gpadc.c
+++ b/drivers/iio/adc/twl6030-gpadc.c
@@ -897,7 +897,7 @@ static int twl6030_gpadc_probe(struct platform_device *pdev)
ret = pdata->calibrate(gpadc);
if (ret < 0) {
- dev_err(&pdev->dev, "failed to read calibration registers\n");
+ dev_err(dev, "failed to read calibration registers\n");
return ret;
}
@@ -911,14 +911,14 @@ static int twl6030_gpadc_probe(struct platform_device *pdev)
ret = twl6030_gpadc_enable_irq(TWL6030_GPADC_RT_SW1_EOC_MASK);
if (ret < 0) {
- dev_err(&pdev->dev, "failed to enable GPADC interrupt\n");
+ dev_err(dev, "failed to enable GPADC interrupt\n");
return ret;
}
ret = twl_i2c_write_u8(TWL6030_MODULE_ID1, TWL6030_GPADCS,
TWL6030_REG_TOGGLE1);
if (ret < 0) {
- dev_err(&pdev->dev, "failed to enable GPADC module\n");
+ dev_err(dev, "failed to enable GPADC module\n");
return ret;
}
--
2.20.1.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: adc: twl6030-gpadc: Use the defined variable to clean code
2021-08-23 9:59 [PATCH] iio: adc: twl6030-gpadc: Use the defined variable to clean code Tang Bin
@ 2021-08-30 11:32 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2021-08-30 11:32 UTC (permalink / raw)
To: Tang Bin; +Cc: lars, linux-iio, linux-kernel
On Mon, 23 Aug 2021 17:59:21 +0800
Tang Bin <tangbin@cmss.chinamobile.com> wrote:
> Use the defined variable "dev" to make the code cleaner.
>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
Applied.
Thanks,
> ---
> drivers/iio/adc/twl6030-gpadc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/twl6030-gpadc.c b/drivers/iio/adc/twl6030-gpadc.c
> index 0859f3f7d..5e4fbb033 100644
> --- a/drivers/iio/adc/twl6030-gpadc.c
> +++ b/drivers/iio/adc/twl6030-gpadc.c
> @@ -897,7 +897,7 @@ static int twl6030_gpadc_probe(struct platform_device *pdev)
>
> ret = pdata->calibrate(gpadc);
> if (ret < 0) {
> - dev_err(&pdev->dev, "failed to read calibration registers\n");
> + dev_err(dev, "failed to read calibration registers\n");
> return ret;
> }
>
> @@ -911,14 +911,14 @@ static int twl6030_gpadc_probe(struct platform_device *pdev)
>
> ret = twl6030_gpadc_enable_irq(TWL6030_GPADC_RT_SW1_EOC_MASK);
> if (ret < 0) {
> - dev_err(&pdev->dev, "failed to enable GPADC interrupt\n");
> + dev_err(dev, "failed to enable GPADC interrupt\n");
> return ret;
> }
>
> ret = twl_i2c_write_u8(TWL6030_MODULE_ID1, TWL6030_GPADCS,
> TWL6030_REG_TOGGLE1);
> if (ret < 0) {
> - dev_err(&pdev->dev, "failed to enable GPADC module\n");
> + dev_err(dev, "failed to enable GPADC module\n");
> return ret;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-30 11:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-23 9:59 [PATCH] iio: adc: twl6030-gpadc: Use the defined variable to clean code Tang Bin
2021-08-30 11:32 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).