* [PATCH] staging: rtl8723bs: remove sdio_osintf.h
@ 2021-08-23 22:12 Bryan Brattlof
2021-08-26 10:07 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Bryan Brattlof @ 2021-08-23 22:12 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-kernel, linux-staging, Bryan Brattlof
All definitions inside sdio_osintf.h are unused. Remove it.
Signed-off-by: Bryan Brattlof <hello@bryanbrattlof.com>
---
drivers/staging/rtl8723bs/include/drv_types.h | 1 -
drivers/staging/rtl8723bs/include/sdio_osintf.h | 16 ----------------
2 files changed, 17 deletions(-)
delete mode 100644 drivers/staging/rtl8723bs/include/sdio_osintf.h
diff --git a/drivers/staging/rtl8723bs/include/drv_types.h b/drivers/staging/rtl8723bs/include/drv_types.h
index 580028d28c42..0e6741db95bf 100644
--- a/drivers/staging/rtl8723bs/include/drv_types.h
+++ b/drivers/staging/rtl8723bs/include/drv_types.h
@@ -489,7 +489,6 @@ static inline u8 *myid(struct eeprom_priv *peepriv)
}
/* HCI Related header file */
-#include <sdio_osintf.h>
#include <sdio_ops.h>
#include <sdio_hal.h>
diff --git a/drivers/staging/rtl8723bs/include/sdio_osintf.h b/drivers/staging/rtl8723bs/include/sdio_osintf.h
deleted file mode 100644
index 146b44f95e29..000000000000
--- a/drivers/staging/rtl8723bs/include/sdio_osintf.h
+++ /dev/null
@@ -1,16 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-/******************************************************************************
- *
- * Copyright(c) 2007 - 2011 Realtek Corporation. All rights reserved.
- *
- ******************************************************************************/
-#ifndef __SDIO_OSINTF_H__
-#define __SDIO_OSINTF_H__
-
-
-
-u8 sd_hal_bus_init(struct adapter *padapter);
-u8 sd_hal_bus_deinit(struct adapter *padapter);
-void sd_c2h_hdl(struct adapter *padapter);
-
-#endif
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rtl8723bs: remove sdio_osintf.h
2021-08-23 22:12 [PATCH] staging: rtl8723bs: remove sdio_osintf.h Bryan Brattlof
@ 2021-08-26 10:07 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2021-08-26 10:07 UTC (permalink / raw)
To: Bryan Brattlof; +Cc: linux-kernel, linux-staging
On Mon, Aug 23, 2021 at 10:12:21PM +0000, Bryan Brattlof wrote:
> All definitions inside sdio_osintf.h are unused. Remove it.
>
> Signed-off-by: Bryan Brattlof <hello@bryanbrattlof.com>
> ---
> drivers/staging/rtl8723bs/include/drv_types.h | 1 -
> drivers/staging/rtl8723bs/include/sdio_osintf.h | 16 ----------------
> 2 files changed, 17 deletions(-)
> delete mode 100644 drivers/staging/rtl8723bs/include/sdio_osintf.h
>
> diff --git a/drivers/staging/rtl8723bs/include/drv_types.h b/drivers/staging/rtl8723bs/include/drv_types.h
> index 580028d28c42..0e6741db95bf 100644
> --- a/drivers/staging/rtl8723bs/include/drv_types.h
> +++ b/drivers/staging/rtl8723bs/include/drv_types.h
> @@ -489,7 +489,6 @@ static inline u8 *myid(struct eeprom_priv *peepriv)
> }
>
> /* HCI Related header file */
> -#include <sdio_osintf.h>
> #include <sdio_ops.h>
> #include <sdio_hal.h>
>
> diff --git a/drivers/staging/rtl8723bs/include/sdio_osintf.h b/drivers/staging/rtl8723bs/include/sdio_osintf.h
> deleted file mode 100644
> index 146b44f95e29..000000000000
> --- a/drivers/staging/rtl8723bs/include/sdio_osintf.h
> +++ /dev/null
> @@ -1,16 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0 */
> -/******************************************************************************
> - *
> - * Copyright(c) 2007 - 2011 Realtek Corporation. All rights reserved.
> - *
> - ******************************************************************************/
> -#ifndef __SDIO_OSINTF_H__
> -#define __SDIO_OSINTF_H__
> -
> -
> -
> -u8 sd_hal_bus_init(struct adapter *padapter);
> -u8 sd_hal_bus_deinit(struct adapter *padapter);
> -void sd_c2h_hdl(struct adapter *padapter);
What about the instances in
drivers/staging/rtl8723bs/include/sdio_hal.h? Please remove them at the
same time.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-26 10:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-23 22:12 [PATCH] staging: rtl8723bs: remove sdio_osintf.h Bryan Brattlof
2021-08-26 10:07 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).