linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Zijun Hu <zijuhu@codeaurora.org>,
	marcel@holtmann.org, johan.hedberg@gmail.com,
	luiz.dentz@gmail.com
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	linux-bluetooth@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	bgodavar@codeaurora.org, c-hbandi@codeaurora.org,
	hemantg@codeaurora.org, mka@chromium.org
Subject: Re: [PATCH v4] Bluetooth: btusb: Add support using different nvm for variant WCN6855 controller
Date: Mon, 23 Aug 2021 23:25:50 +0800	[thread overview]
Message-ID: <202108232323.lgmdBIyf-lkp@intel.com> (raw)
In-Reply-To: <1629709100-9099-1-git-send-email-zijuhu@codeaurora.org>

[-- Attachment #1: Type: text/plain, Size: 7478 bytes --]

Hi Zijun,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on bluetooth-next/master]
[also build test ERROR on linus/master v5.14-rc7 next-20210823]
[cannot apply to linux/master bluetooth/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Zijun-Hu/Bluetooth-btusb-Add-support-using-different-nvm-for-variant-WCN6855-controller/20210823-170111
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/0e2a1544bcc7d3ffac1bd4c27614c8d892933ed3
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Zijun-Hu/Bluetooth-btusb-Add-support-using-different-nvm-for-variant-WCN6855-controller/20210823-170111
        git checkout 0e2a1544bcc7d3ffac1bd4c27614c8d892933ed3
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/bluetooth/btusb.c: In function 'btusb_generate_qca_nvm_name':
>> drivers/bluetooth/btusb.c:3342:34: error: passing argument 1 of 'snprintf' from incompatible pointer type [-Werror=incompatible-pointer-types]
    3342 |                         snprintf(fwname, sizeof(fwname), "qca/nvm_usb_%08x%s%s.bin",
         |                                  ^~~~~~
         |                                  |
         |                                  char **
   In file included from include/linux/list.h:9,
                    from include/linux/dmi.h:5,
                    from drivers/bluetooth/btusb.c:9:
   include/linux/kernel.h:204:20: note: expected 'char *' but argument is of type 'char **'
     204 | int snprintf(char *buf, size_t size, const char *fmt, ...);
         |              ~~~~~~^~~
   drivers/bluetooth/btusb.c:3347:34: error: passing argument 1 of 'snprintf' from incompatible pointer type [-Werror=incompatible-pointer-types]
    3347 |                         snprintf(fwname, sizeof(fwname), "qca/nvm_usb_%08x%s%s%04x.bin",
         |                                  ^~~~~~
         |                                  |
         |                                  char **
   In file included from include/linux/list.h:9,
                    from include/linux/dmi.h:5,
                    from drivers/bluetooth/btusb.c:9:
   include/linux/kernel.h:204:20: note: expected 'char *' but argument is of type 'char **'
     204 | int snprintf(char *buf, size_t size, const char *fmt, ...);
         |              ~~~~~~^~~
   drivers/bluetooth/btusb.c:3354:26: error: passing argument 1 of 'snprintf' from incompatible pointer type [-Werror=incompatible-pointer-types]
    3354 |                 snprintf(fwname, sizeof(fwname), "qca/nvm_usb_%08x.bin",
         |                          ^~~~~~
         |                          |
         |                          char **
   In file included from include/linux/list.h:9,
                    from include/linux/dmi.h:5,
                    from drivers/bluetooth/btusb.c:9:
   include/linux/kernel.h:204:20: note: expected 'char *' but argument is of type 'char **'
     204 | int snprintf(char *buf, size_t size, const char *fmt, ...);
         |              ~~~~~~^~~
   drivers/bluetooth/btusb.c: In function 'btusb_setup_qca_load_nvm':
>> drivers/bluetooth/btusb.c:3371:53: error: passing argument 1 of 'btusb_generate_qca_nvm_name' from incompatible pointer type [-Werror=incompatible-pointer-types]
    3371 |                         btusb_generate_qca_nvm_name(&fwname, sizeof(fwname), ver, "_", "gf");
         |                                                     ^~~~~~~
         |                                                     |
         |                                                     char (*)[64]
   drivers/bluetooth/btusb.c:3333:48: note: expected 'char **' but argument is of type 'char (*)[64]'
    3333 | static void btusb_generate_qca_nvm_name(char **fwname,
         |                                         ~~~~~~~^~~~~~
   drivers/bluetooth/btusb.c:3374:53: error: passing argument 1 of 'btusb_generate_qca_nvm_name' from incompatible pointer type [-Werror=incompatible-pointer-types]
    3374 |                         btusb_generate_qca_nvm_name(&fwname, sizeof(fwname), ver, NULL, NULL);
         |                                                     ^~~~~~~
         |                                                     |
         |                                                     char (*)[64]
   drivers/bluetooth/btusb.c:3333:48: note: expected 'char **' but argument is of type 'char (*)[64]'
    3333 | static void btusb_generate_qca_nvm_name(char **fwname,
         |                                         ~~~~~~~^~~~~~
   cc1: some warnings being treated as errors


vim +/snprintf +3342 drivers/bluetooth/btusb.c

  3332	
  3333	static void btusb_generate_qca_nvm_name(char **fwname,
  3334						int max_size,
  3335						struct qca_version *ver,
  3336						char *separator,
  3337						char *vendor)
  3338	{
  3339		if (((ver->flag >> 8) & 0xff) == QCA_FLAG_MULTI_NVM) {
  3340			/* if boardid equal 0, use default nvm without surfix */
  3341			if (le16_to_cpu(ver->board_id) == 0x0) {
> 3342				snprintf(fwname, sizeof(fwname), "qca/nvm_usb_%08x%s%s.bin",
  3343					 le32_to_cpu(ver->rom_version),
  3344					 separator,
  3345					 vendor);
  3346			} else {
  3347				snprintf(fwname, sizeof(fwname), "qca/nvm_usb_%08x%s%s%04x.bin",
  3348					le32_to_cpu(ver->rom_version),
  3349					separator,
  3350					vendor,
  3351					le16_to_cpu(ver->board_id));
  3352			}
  3353		} else {
  3354			snprintf(fwname, sizeof(fwname), "qca/nvm_usb_%08x.bin",
  3355				 le32_to_cpu(ver->rom_version));
  3356		}
  3357	
  3358	}
  3359	
  3360	static int btusb_setup_qca_load_nvm(struct hci_dev *hdev,
  3361					    struct qca_version *ver,
  3362					    const struct qca_device_info *info)
  3363	{
  3364		const struct firmware *fw;
  3365		char fwname[64];
  3366		int err;
  3367	
  3368		switch (ver->ram_version) {
  3369		case WCN6855_2_0_RAM_VERSION_GF:
  3370		case WCN6855_2_1_RAM_VERSION_GF:
> 3371				btusb_generate_qca_nvm_name(&fwname, sizeof(fwname), ver, "_", "gf");
  3372			break;
  3373		default:
  3374				btusb_generate_qca_nvm_name(&fwname, sizeof(fwname), ver, NULL, NULL);
  3375			break;
  3376		}
  3377	
  3378		err = request_firmware(&fw, fwname, &hdev->dev);
  3379		if (err) {
  3380			bt_dev_err(hdev, "failed to request NVM file: %s (%d)",
  3381				   fwname, err);
  3382			return err;
  3383		}
  3384	
  3385		bt_dev_info(hdev, "using NVM file: %s", fwname);
  3386	
  3387		err = btusb_setup_qca_download_fw(hdev, fw, info->nvm_hdr);
  3388	
  3389		release_firmware(fw);
  3390	
  3391		return err;
  3392	}
  3393	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 68484 bytes --]

  parent reply	other threads:[~2021-08-23 15:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-23  8:58 [PATCH v4] Bluetooth: btusb: Add support using different nvm for variant WCN6855 controller Zijun Hu
2021-08-23 13:58 ` kernel test robot
2021-08-23 15:25 ` kernel test robot [this message]
2021-08-23 17:43 ` Matthias Kaehlcke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202108232323.lgmdBIyf-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=bgodavar@codeaurora.org \
    --cc=c-hbandi@codeaurora.org \
    --cc=hemantg@codeaurora.org \
    --cc=johan.hedberg@gmail.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    --cc=mka@chromium.org \
    --cc=zijuhu@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).