* [PATCH] driver core: clean up open-coded NUMA_NO_NODE in device_initialize()
@ 2021-08-24 10:30 Julian Wiedmann
2021-08-24 13:10 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Julian Wiedmann @ 2021-08-24 10:30 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Julian Wiedmann, Rafael J. Wysocki, linux-kernel
Use the right macro to get rid of a magic number.
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
---
drivers/base/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/core.c b/drivers/base/core.c
index f6360490a4a3..fa1043d74e36 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -2835,7 +2835,7 @@ void device_initialize(struct device *dev)
spin_lock_init(&dev->devres_lock);
INIT_LIST_HEAD(&dev->devres_head);
device_pm_init(dev);
- set_dev_node(dev, -1);
+ set_dev_node(dev, NUMA_NO_NODE);
#ifdef CONFIG_GENERIC_MSI_IRQ
INIT_LIST_HEAD(&dev->msi_list);
#endif
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] driver core: clean up open-coded NUMA_NO_NODE in device_initialize()
2021-08-24 10:30 [PATCH] driver core: clean up open-coded NUMA_NO_NODE in device_initialize() Julian Wiedmann
@ 2021-08-24 13:10 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2021-08-24 13:10 UTC (permalink / raw)
To: Julian Wiedmann; +Cc: Rafael J. Wysocki, linux-kernel
On Tue, Aug 24, 2021 at 12:30:55PM +0200, Julian Wiedmann wrote:
> Use the right macro to get rid of a magic number.
That is a very vague changelog comment. You can do better :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-24 13:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-24 10:30 [PATCH] driver core: clean up open-coded NUMA_NO_NODE in device_initialize() Julian Wiedmann
2021-08-24 13:10 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).