[PATCH] mmc: pwrseq: sd8787: fix compilation warning

[PATCH] mmc: pwrseq: sd8787: fix compilation warning

[Claudiu Beznea]

Fixed compilation warning "cast from pointer to integer of
different size [-Wpointer-to-int-cast]"

Fixes: b2832b96fcf5 ("mmc: pwrseq: sd8787: add support for wilc1000")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
---
 drivers/mmc/core/pwrseq_sd8787.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/mmc/core/pwrseq_sd8787.c b/drivers/mmc/core/pwrseq_sd8787.c
index 264e48067af2..2e120ad83020 100644
--- a/drivers/mmc/core/pwrseq_sd8787.c
+++ b/drivers/mmc/core/pwrseq_sd8787.c
@@ -56,9 +56,12 @@ static const struct mmc_pwrseq_ops mmc_pwrseq_sd8787_ops = {
 	.power_off = mmc_pwrseq_sd8787_power_off,
 };
 
+static const u32 sd8787_delay_ms = 300;
+static const u32 wilc1000_delay_ms = 5;
+
 static const struct of_device_id mmc_pwrseq_sd8787_of_match[] = {
-	{ .compatible = "mmc-pwrseq-sd8787", .data = (void *)300 },
-	{ .compatible = "mmc-pwrseq-wilc1000", .data = (void *)5 },
+	{ .compatible = "mmc-pwrseq-sd8787", .data = &sd8787_delay_ms },
+	{ .compatible = "mmc-pwrseq-wilc1000", .data = &wilc1000_delay_ms },
 	{/* sentinel */},
 };
 MODULE_DEVICE_TABLE(of, mmc_pwrseq_sd8787_of_match);
@@ -74,7 +77,7 @@ static int mmc_pwrseq_sd8787_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	match = of_match_node(mmc_pwrseq_sd8787_of_match, pdev->dev.of_node);
-	pwrseq->reset_pwrdwn_delay_ms = (u32)match->data;
+	pwrseq->reset_pwrdwn_delay_ms = *(u32 *)match->data;
 
 	pwrseq->pwrdn_gpio = devm_gpiod_get(dev, "powerdown", GPIOD_OUT_LOW);
 	if (IS_ERR(pwrseq->pwrdn_gpio))
-- 
2.25.1

Re: [PATCH] mmc: pwrseq: sd8787: fix compilation warning

[Ulf Hansson]

On Wed, 25 Aug 2021 at 10:21, Claudiu Beznea
<claudiu.beznea@microchip.com> wrote:
>
> Fixed compilation warning "cast from pointer to integer of
> different size [-Wpointer-to-int-cast]"
>
> Fixes: b2832b96fcf5 ("mmc: pwrseq: sd8787: add support for wilc1000")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/core/pwrseq_sd8787.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/core/pwrseq_sd8787.c b/drivers/mmc/core/pwrseq_sd8787.c
> index 264e48067af2..2e120ad83020 100644
> --- a/drivers/mmc/core/pwrseq_sd8787.c
> +++ b/drivers/mmc/core/pwrseq_sd8787.c
> @@ -56,9 +56,12 @@ static const struct mmc_pwrseq_ops mmc_pwrseq_sd8787_ops = {
>         .power_off = mmc_pwrseq_sd8787_power_off,
>  };
>
> +static const u32 sd8787_delay_ms = 300;
> +static const u32 wilc1000_delay_ms = 5;
> +
>  static const struct of_device_id mmc_pwrseq_sd8787_of_match[] = {
> -       { .compatible = "mmc-pwrseq-sd8787", .data = (void *)300 },
> -       { .compatible = "mmc-pwrseq-wilc1000", .data = (void *)5 },
> +       { .compatible = "mmc-pwrseq-sd8787", .data = &sd8787_delay_ms },
> +       { .compatible = "mmc-pwrseq-wilc1000", .data = &wilc1000_delay_ms },
>         {/* sentinel */},
>  };
>  MODULE_DEVICE_TABLE(of, mmc_pwrseq_sd8787_of_match);
> @@ -74,7 +77,7 @@ static int mmc_pwrseq_sd8787_probe(struct platform_device *pdev)
>                 return -ENOMEM;
>
>         match = of_match_node(mmc_pwrseq_sd8787_of_match, pdev->dev.of_node);
> -       pwrseq->reset_pwrdwn_delay_ms = (u32)match->data;
> +       pwrseq->reset_pwrdwn_delay_ms = *(u32 *)match->data;
>
>         pwrseq->pwrdn_gpio = devm_gpiod_get(dev, "powerdown", GPIOD_OUT_LOW);
>         if (IS_ERR(pwrseq->pwrdn_gpio))
> --
> 2.25.1
>