From: Eizan Miyamoto <eizan@chromium.org>
To: linux-kernel@vger.kernel.org
Cc: chunkuang.hu@kernel.org, yong.wu@mediatek.com,
wenst@chromium.org, ck.hu@mediatek.com, houlong.wei@mediatek.com,
enric.balletbo@collabora.com, yongqiang.niu@mediatek.com,
Eizan Miyamoto <eizan@chromium.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: [PATCH v7 6/7] soc: mediatek: mmsys: instantiate mdp virtual device from mmsys
Date: Wed, 25 Aug 2021 16:33:22 +1000 [thread overview]
Message-ID: <20210825163247.v7.6.Ie4214d2cc73ab276dd7c41d4f63c98e011fb42d4@changeid> (raw)
In-Reply-To: <20210825063323.3607738-1-eizan@chromium.org>
A virtual device that is probed by the mtk_mdp_core driver is
instantiated by the mtk_mmsys driver.
This better reflects the logical organization of the hardware and
driver: there are a number of hardware blocks that are used by the MDP
that have no strict hierarchy, and the software driver is responsible
for driving them properly.
Signed-off-by: Eizan Miyamoto <eizan@chromium.org>
Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: Houlong Wei <houlong.wei@mediatek.com>
---
(no changes since v1)
drivers/soc/mediatek/mtk-mmsys.c | 20 +++++++++++++++++++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c
index 080660ef11bf..e681029fe804 100644
--- a/drivers/soc/mediatek/mtk-mmsys.c
+++ b/drivers/soc/mediatek/mtk-mmsys.c
@@ -97,6 +97,7 @@ static int mtk_mmsys_probe(struct platform_device *pdev)
struct platform_device *clks;
struct platform_device *drm;
struct mtk_mmsys *mmsys;
+ struct platform_device *mdp;
int ret;
mmsys = devm_kzalloc(dev, sizeof(*mmsys), GFP_KERNEL);
@@ -122,10 +123,27 @@ static int mtk_mmsys_probe(struct platform_device *pdev)
PLATFORM_DEVID_AUTO, NULL, 0);
if (IS_ERR(drm)) {
platform_device_unregister(clks);
- return PTR_ERR(drm);
+ ret = PTR_ERR(drm);
+ goto err_drm;
+ }
+
+ mdp = platform_device_register_data(&pdev->dev, "mtk-mdp",
+ PLATFORM_DEVID_AUTO, NULL, 0);
+ if (IS_ERR(mdp)) {
+ ret = PTR_ERR(mdp);
+ dev_err(dev, "Failed to register mdp: %d\n", ret);
+ goto err_mdp;
}
return 0;
+
+err_mdp:
+ platform_device_unregister(drm);
+
+err_drm:
+ platform_device_unregister(clks);
+
+ return ret;
}
static const struct of_device_id of_match_mtk_mmsys[] = {
--
2.33.0.rc2.250.ged5fa647cd-goog
next prev parent reply other threads:[~2021-08-25 6:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 6:33 [PATCH v7 0/7] Refactor MTK MDP driver into core/components Eizan Miyamoto
2021-08-25 6:33 ` [PATCH v7 1/7] mtk-mdp: propagate errors from clock_on Eizan Miyamoto
2021-08-25 6:33 ` [PATCH v7 2/7] mtk-mdp: add driver to probe mdp components Eizan Miyamoto
2021-09-04 12:34 ` Ezequiel Garcia
2021-09-05 16:23 ` houlong wei
2021-09-05 16:39 ` houlong wei
2021-12-07 12:37 ` Hans Verkuil
2021-12-07 12:46 ` Ezequiel Garcia
2021-12-07 13:02 ` Hans Verkuil
2021-12-08 2:00 ` Yong Wu
2021-08-25 6:33 ` [PATCH v7 3/7] mtk-mdp: use pm_runtime in MDP component driver Eizan Miyamoto
2021-08-25 6:33 ` [PATCH v7 4/7] media: mtk-mdp: don't pm_run_time_get/put for master comp in clock_on Eizan Miyamoto
2021-08-25 6:33 ` [PATCH v7 5/7] mtk-mdp: make mdp driver to be loadable by platform_device_register*() Eizan Miyamoto
2021-08-25 8:18 ` houlong wei
2021-08-25 6:33 ` Eizan Miyamoto [this message]
2021-08-25 6:33 ` [PATCH v7 7/7] media: mtk-mdp: use mdp-rdma0 alias to point to MDP master Eizan Miyamoto
2021-08-25 8:43 ` houlong wei
2021-08-25 9:07 ` Enric Balletbo i Serra
2021-08-25 15:18 ` houlong wei
2021-08-25 16:54 ` Enric Balletbo i Serra
2021-08-30 17:14 ` houlong wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210825163247.v7.6.Ie4214d2cc73ab276dd7c41d4f63c98e011fb42d4@changeid \
--to=eizan@chromium.org \
--cc=chunkuang.hu@kernel.org \
--cc=ck.hu@mediatek.com \
--cc=enric.balletbo@collabora.com \
--cc=houlong.wei@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=wenst@chromium.org \
--cc=yong.wu@mediatek.com \
--cc=yongqiang.niu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).