linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/3] dt-bindings: memory: fsl: convert DDR controller to dtschema
@ 2021-08-26 11:30 Krzysztof Kozlowski
  2021-08-26 11:30 ` [PATCH 2/3] ARM: dts: ls1021a: drop unused big-endian property from DDR controller Krzysztof Kozlowski
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2021-08-26 11:30 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Rob Herring, Shawn Guo, Li Yang,
	Borislav Petkov, York Sun, linux-kernel, devicetree,
	linux-arm-kernel

Convert Freescale/NXP DDR memory controller bindings to DT schema format
using json-schema.

Previous bindings were not listing all compatibles, so scan through
devicetree sources and drivers to get these.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 .../bindings/memory-controllers/fsl/ddr.txt   | 29 -------
 .../memory-controllers/fsl/fsl,ddr.yaml       | 83 +++++++++++++++++++
 2 files changed, 83 insertions(+), 29 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/memory-controllers/fsl/ddr.txt
 create mode 100644 Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ddr.yaml

diff --git a/Documentation/devicetree/bindings/memory-controllers/fsl/ddr.txt b/Documentation/devicetree/bindings/memory-controllers/fsl/ddr.txt
deleted file mode 100644
index dde6d837083a..000000000000
--- a/Documentation/devicetree/bindings/memory-controllers/fsl/ddr.txt
+++ /dev/null
@@ -1,29 +0,0 @@
-Freescale DDR memory controller
-
-Properties:
-
-- compatible	: Should include "fsl,chip-memory-controller" where
-		  chip is the processor (bsc9132, mpc8572 etc.), or
-		  "fsl,qoriq-memory-controller".
-- reg		: Address and size of DDR controller registers
-- interrupts	: Error interrupt of DDR controller
-- little-endian	: Specifies little-endian access to registers
-		  If omitted, big-endian will be used.
-
-Example 1:
-
-	memory-controller@2000 {
-		compatible = "fsl,bsc9132-memory-controller";
-		reg = <0x2000 0x1000>;
-		interrupts = <16 2 1 8>;
-	};
-
-
-Example 2:
-
-	ddr1: memory-controller@8000 {
-		compatible = "fsl,qoriq-memory-controller-v4.7",
-				"fsl,qoriq-memory-controller";
-		reg = <0x8000 0x1000>;
-		interrupts = <16 2 1 23>;
-	};
diff --git a/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ddr.yaml b/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ddr.yaml
new file mode 100644
index 000000000000..af5147f9da72
--- /dev/null
+++ b/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ddr.yaml
@@ -0,0 +1,83 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/memory-controllers/fsl/fsl,ddr.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Freescale DDR memory controller
+
+maintainers:
+  - Borislav Petkov <bp@alien8.de>
+  - York Sun <york.sun@nxp.com>
+
+properties:
+  $nodename:
+    pattern: "^memory-controller@[0-9a-f]+$"
+
+  compatible:
+    oneOf:
+      - items:
+          - enum:
+              - fsl,qoriq-memory-controller-v4.4
+              - fsl,qoriq-memory-controller-v4.5
+              - fsl,qoriq-memory-controller-v4.7
+              - fsl,qoriq-memory-controller-v5.0
+          - const: fsl,qoriq-memory-controller
+      - enum:
+          - fsl,bsc9132-memory-controller
+          - fsl,8540-memory-controller
+          - fsl,8541-memory-controller
+          - fsl,8544-memory-controller
+          - fsl,8548-memory-controller
+          - fsl,8555-memory-controller
+          - fsl,8568-memory-controller
+          - fsl,mpc8536-memory-controller
+          - fsl,mpc8540-memory-controller
+          - fsl,mpc8541-memory-controller
+          - fsl,mpc8544-memory-controller
+          - fsl,mpc8548-memory-controller
+          - fsl,mpc8555-memory-controller
+          - fsl,mpc8560-memory-controller
+          - fsl,mpc8568-memory-controller
+          - fsl,mpc8569-memory-controller
+          - fsl,mpc8572-memory-controller
+          - fsl,mpc8349-memory-controller
+          - fsl,p1020-memory-controller
+          - fsl,p1021-memory-controller
+          - fsl,p2020-memory-controller
+          - fsl,qoriq-memory-controller
+
+  interrupts:
+    maxItems: 1
+
+  little-endian:
+    description:
+      Specifies little-endian access to registers. If omitted, big-endian will
+      be used.
+    type: boolean
+
+  reg:
+    maxItems: 1
+
+required:
+  - compatible
+  - interrupts
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    memory-controller@2000 {
+        compatible = "fsl,bsc9132-memory-controller";
+        reg = <0x2000 0x1000>;
+        interrupts = <16 2 1 8>;
+    };
+
+  - |
+    memory-controller@8000 {
+        compatible = "fsl,qoriq-memory-controller-v4.7",
+                     "fsl,qoriq-memory-controller";
+        reg = <0x8000 0x1000>;
+        interrupts = <16 2 1 23>;
+    };
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/3] ARM: dts: ls1021a: drop unused big-endian property from DDR controller
  2021-08-26 11:30 [PATCH 1/3] dt-bindings: memory: fsl: convert DDR controller to dtschema Krzysztof Kozlowski
@ 2021-08-26 11:30 ` Krzysztof Kozlowski
  2021-08-26 11:32 ` [PATCH 3/3] arm64: dts: freescale: ls1046a: " Krzysztof Kozlowski
  2021-09-03 17:45 ` [PATCH 1/3] dt-bindings: memory: fsl: convert DDR controller to dtschema Rob Herring
  2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2021-08-26 11:30 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Rob Herring, Shawn Guo, Li Yang,
	Borislav Petkov, York Sun, linux-kernel, devicetree,
	linux-arm-kernel

The big-endian is default setting for DDR controller as expressed in
bindings and such property was never documented for Freescale DDR memory
controller.  The driver also does not parse this property at all.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 arch/arm/boot/dts/ls1021a.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
index 4fce81422943..0f759bc81239 100644
--- a/arch/arm/boot/dts/ls1021a.dtsi
+++ b/arch/arm/boot/dts/ls1021a.dtsi
@@ -136,7 +136,6 @@ ddr: memory-controller@1080000 {
 			compatible = "fsl,qoriq-memory-controller";
 			reg = <0x0 0x1080000 0x0 0x1000>;
 			interrupts = <GIC_SPI 176 IRQ_TYPE_LEVEL_HIGH>;
-			big-endian;
 		};
 
 		gic: interrupt-controller@1400000 {
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 3/3] arm64: dts: freescale: ls1046a: drop unused big-endian property from DDR controller
  2021-08-26 11:30 [PATCH 1/3] dt-bindings: memory: fsl: convert DDR controller to dtschema Krzysztof Kozlowski
  2021-08-26 11:30 ` [PATCH 2/3] ARM: dts: ls1021a: drop unused big-endian property from DDR controller Krzysztof Kozlowski
@ 2021-08-26 11:32 ` Krzysztof Kozlowski
  2021-09-03 17:45 ` [PATCH 1/3] dt-bindings: memory: fsl: convert DDR controller to dtschema Rob Herring
  2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2021-08-26 11:32 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Rob Herring, Shawn Guo, Li Yang,
	Borislav Petkov, York Sun, linux-kernel, devicetree,
	linux-arm-kernel

The big-endian is default setting for DDR controller as expressed in
bindings and such property was never documented for Freescale DDR memory
controller.  The driver also does not parse this property at all.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
index 687fea6d8afa..b06c285b6534 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
@@ -277,7 +277,6 @@ ddr: memory-controller@1080000 {
 			compatible = "fsl,qoriq-memory-controller";
 			reg = <0x0 0x1080000 0x0 0x1000>;
 			interrupts = <GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>;
-			big-endian;
 		};
 
 		ifc: ifc@1530000 {
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/3] dt-bindings: memory: fsl: convert DDR controller to dtschema
  2021-08-26 11:30 [PATCH 1/3] dt-bindings: memory: fsl: convert DDR controller to dtschema Krzysztof Kozlowski
  2021-08-26 11:30 ` [PATCH 2/3] ARM: dts: ls1021a: drop unused big-endian property from DDR controller Krzysztof Kozlowski
  2021-08-26 11:32 ` [PATCH 3/3] arm64: dts: freescale: ls1046a: " Krzysztof Kozlowski
@ 2021-09-03 17:45 ` Rob Herring
  2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2021-09-03 17:45 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: York Sun, Rob Herring, Li Yang, linux-kernel, linux-arm-kernel,
	Borislav Petkov, Shawn Guo, devicetree

On Thu, 26 Aug 2021 13:30:47 +0200, Krzysztof Kozlowski wrote:
> Convert Freescale/NXP DDR memory controller bindings to DT schema format
> using json-schema.
> 
> Previous bindings were not listing all compatibles, so scan through
> devicetree sources and drivers to get these.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  .../bindings/memory-controllers/fsl/ddr.txt   | 29 -------
>  .../memory-controllers/fsl/fsl,ddr.yaml       | 83 +++++++++++++++++++
>  2 files changed, 83 insertions(+), 29 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/memory-controllers/fsl/ddr.txt
>  create mode 100644 Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ddr.yaml
> 

Applied, thanks!

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-09-03 17:45 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-26 11:30 [PATCH 1/3] dt-bindings: memory: fsl: convert DDR controller to dtschema Krzysztof Kozlowski
2021-08-26 11:30 ` [PATCH 2/3] ARM: dts: ls1021a: drop unused big-endian property from DDR controller Krzysztof Kozlowski
2021-08-26 11:32 ` [PATCH 3/3] arm64: dts: freescale: ls1046a: " Krzysztof Kozlowski
2021-09-03 17:45 ` [PATCH 1/3] dt-bindings: memory: fsl: convert DDR controller to dtschema Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).