From: Kai Huang <kai.huang@intel.com>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: linux-sgx@vger.kernel.org,
Dave Hansen <dave.hansen@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Jonathan Corbet <corbet@lwn.net>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Shuah Khan <shuah@kernel.org>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v3 2/2] x86/sgx: Add SGX_MemTotal to /proc/meminfo
Date: Sat, 28 Aug 2021 00:03:35 +1200 [thread overview]
Message-ID: <20210828000335.1d40dfff0f408b2d91467491@intel.com> (raw)
In-Reply-To: <54923ac01fc303e5105cadca06b7c5cbd322d815.camel@kernel.org>
> > > -/* The free page list lock protected variables prepend the lock. */
> > > +/* The number of usable EPC pages in the system. */
> > > +unsigned long sgx_nr_all_pages;
> > > +
> > > +/* The number of free EPC pages in all nodes. */
> > > static unsigned long sgx_nr_free_pages;
> > >
> > > /* Nodes with one or more EPC sections. */
> > > @@ -656,6 +659,8 @@ static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size,
> > > list_add_tail(§ion->pages[i].list, &sgx_dirty_page_list);
> > > }
> > >
> > > + sgx_nr_all_pages += nr_pages;
> > > +
> >
> > EPC sections can be freed again in sgx_init() after they are successfully
> > initialized, when any further initialization fails (i.e. when fails to create
> > ksgxd, or fails to register /dev/sgx_provision). In which case, I think
> > sgx_nr_all_pages should also be cleared. But current sgx_init() seems doesn't
> > reset it. Do you need to fix that too?
>
> sgx_nr_all_pages tells just the total pages in the system, i.e. it's a constant.
>
> Maybe a rename to "sgx_nr_total_pages" would be a good idea? Would match with
> the meminfo field better too.
I don't have preference on name. I just think if there's no actual user of
EPC (when both driver and KVM SGX cannot be enabled), it's pointless to print
number of EPC pages.
>
> >
> > > return true;
> > > }
> > >
> > > diff --git a/arch/x86/mm/pat/set_memory.c b/arch/x86/mm/pat/set_memory.c
> > > index ad8a5c586a35..82bb09c298de 100644
> > > --- a/arch/x86/mm/pat/set_memory.c
> > > +++ b/arch/x86/mm/pat/set_memory.c
> > > @@ -29,6 +29,7 @@
> > > #include <asm/proto.h>
> > > #include <asm/memtype.h>
> > > #include <asm/set_memory.h>
> > > +#include <asm/sgx.h>
> >
> > How about only include <asm/sgx.h> when CONFIG_X86_SGX is on, then you don't
> > have to do #ifdef CONFIG_X86_SGX changes to sgx.h?
>
> Why do it that way instead of doing it once in sgx.h for every site that wants
> to include the file?
Just my preference. You only need sgx_nr_all_pages here, while <asm/sgx.h>
has bunch of others such as SGX data structures. It seems it's not worth to
include <asm/sgx.h> directly.
next prev parent reply other threads:[~2021-08-27 12:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 23:52 [PATCH v3 1/2] x86/sgx: Add the missing ifdef for sgx_set_attribute() Jarkko Sakkinen
2021-08-25 23:52 ` [PATCH v3 2/2] x86/sgx: Add SGX_MemTotal to /proc/meminfo Jarkko Sakkinen
2021-08-26 0:39 ` Randy Dunlap
2021-08-26 16:17 ` Jarkko Sakkinen
2021-08-26 20:27 ` Dave Hansen
2021-08-26 22:27 ` Randy Dunlap
2021-09-01 1:51 ` Jarkko Sakkinen
2021-08-26 2:19 ` Kai Huang
2021-08-26 16:27 ` Jarkko Sakkinen
2021-08-27 12:03 ` Kai Huang [this message]
2021-09-01 2:02 ` Jarkko Sakkinen
2021-09-01 5:33 ` Kai Huang
2021-09-01 5:41 ` Jarkko Sakkinen
2021-09-01 5:47 ` Kai Huang
2021-09-02 12:15 ` Jarkko Sakkinen
2021-09-02 21:56 ` Kai Huang
2021-09-02 22:14 ` Jarkko Sakkinen
2021-08-26 9:58 ` [PATCH v3 1/2] x86/sgx: Add the missing ifdef for sgx_set_attribute() Borislav Petkov
2021-08-26 16:08 ` Jarkko Sakkinen
2021-08-26 16:35 ` Borislav Petkov
2021-08-26 17:11 ` Jarkko Sakkinen
2021-08-26 17:24 ` Borislav Petkov
2021-08-26 17:31 ` Jarkko Sakkinen
2021-08-26 17:53 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210828000335.1d40dfff0f408b2d91467491@intel.com \
--to=kai.huang@intel.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jarkko@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).