From: Borislav Petkov <bp@alien8.de>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: linux-sgx@vger.kernel.org,
Dave Hansen <dave.hansen@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Sean Christopherson <seanjc@google.com>,
Kai Huang <kai.huang@intel.com>, Shuah Khan <shuah@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] x86/sgx: Add the missing ifdef for sgx_set_attribute()
Date: Thu, 26 Aug 2021 19:53:59 +0200 [thread overview]
Message-ID: <YSfVN16aZbe1TXO0@zn.tnic> (raw)
In-Reply-To: <3980adde9c05963790215e99d566740059da6870.camel@kernel.org>
On Thu, Aug 26, 2021 at 08:31:13PM +0300, Jarkko Sakkinen wrote:
> The actual problem is to use it in set_memory.c.
So I asked you in the first mail:
"Please explain what exactly is this fixing."
> This the unsplit version:
>
> https://lore.kernel.org/linux-sgx/20210818132509.545997-1-jarkko@kernel.org/
But you're still feeding me some pieces of the puzzle piecemeal.
> Should I just squash them again into one patch?
You should explain *why* you're fixing whatever you're fixing and your
commit message should explain exactly how the bug is triggered so that
the reader of that commit message can reproduce it on their end.
Otherwise it'll get ignored until you do it right.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2021-08-26 17:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 23:52 [PATCH v3 1/2] x86/sgx: Add the missing ifdef for sgx_set_attribute() Jarkko Sakkinen
2021-08-25 23:52 ` [PATCH v3 2/2] x86/sgx: Add SGX_MemTotal to /proc/meminfo Jarkko Sakkinen
2021-08-26 0:39 ` Randy Dunlap
2021-08-26 16:17 ` Jarkko Sakkinen
2021-08-26 20:27 ` Dave Hansen
2021-08-26 22:27 ` Randy Dunlap
2021-09-01 1:51 ` Jarkko Sakkinen
2021-08-26 2:19 ` Kai Huang
2021-08-26 16:27 ` Jarkko Sakkinen
2021-08-27 12:03 ` Kai Huang
2021-09-01 2:02 ` Jarkko Sakkinen
2021-09-01 5:33 ` Kai Huang
2021-09-01 5:41 ` Jarkko Sakkinen
2021-09-01 5:47 ` Kai Huang
2021-09-02 12:15 ` Jarkko Sakkinen
2021-09-02 21:56 ` Kai Huang
2021-09-02 22:14 ` Jarkko Sakkinen
2021-08-26 9:58 ` [PATCH v3 1/2] x86/sgx: Add the missing ifdef for sgx_set_attribute() Borislav Petkov
2021-08-26 16:08 ` Jarkko Sakkinen
2021-08-26 16:35 ` Borislav Petkov
2021-08-26 17:11 ` Jarkko Sakkinen
2021-08-26 17:24 ` Borislav Petkov
2021-08-26 17:31 ` Jarkko Sakkinen
2021-08-26 17:53 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSfVN16aZbe1TXO0@zn.tnic \
--to=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jarkko@kernel.org \
--cc=kai.huang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=seanjc@google.com \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).